The cherry-pick of 923ce7e588
("Fix password field in lock screen not clearing after failed login attempt")
introduced two assignments to properties which don't exist in 5.25 yet. This
causes execution of those blocks to abort early, resulting in a bad state,
like hadPrompt never getting set to true.
BUG: 456639
PreviewWidget has a timer that advances to the next frame of the current
cursor.
"current" can change in setTheme, we need to stop the animation timer
BUG: 456526
(cherry picked from commit ddf88d2148)
This one-liner fix is from Aleix Pol, and fixes the following:
- Crashes when deleting panels with Panel Spacer instances on them
(as described in the bug ID named above)
- Potentially endless crash looping when running `plasmashell --replace`
while a Panel Spacer is on at least one panel
Co-authored-by: Aleix Pol <aleixpol@kde.org>
BUG: 450663
FIXED-IN: 5.25.3
(cherry picked from commit 65fe6b864d)
This was incorrectly put behind Mode::Apply in commit 34e2541b
("kcms/lookandfeel: allow users to choose what part of a Global Theme to apply")
BUG: 456275
(cherry picked from commit 14f0611e6e)
Tint the window titlebars only when either the option to tint all colors with
accent color or the option to apply accent color to window titlebars is enabled
or both), and in the latter case, the active window titlebars should be painted
in the accent color.
BUG: 455395
BUG: 454047
FIXED-IN: 5.25.3
(cherry picked from commit 00a18a8c5a)
This bug was introduced by plasma/plasma-workspace!1754.
`lockScreenUi.hadPrompt` was set to `false` in `onFailed()` to avoid
unintentionally clearing the password after the text field had faded
out after 10 seconds and the user pressed a button. Unfortunately this
also caused the password field to not clear right after the failed event.
So instead the statement is moved into the trigger of `fadeoutTimer` which
fixes both issues.
BUG: 455227
FIXED-IN: 5.25.3
(cherry picked from commit 923ce7e588)
In `ShellCorona::handleScreenRemoved(QScreen*)` the panel was removed by a timer, which can cause null QScreen pointer. This fix is explicitly merged for 5.25 and should not be cherry-picked to master branch.
BUG: 455328
FIXED-IN: 5.25.3
Whilst iterating through m_proccesses we make them finish. An existing
connect removes them from the vector.
Iterating through a volatile vector is unsafe.
BUG: 454159
(cherry picked from commit 3692ff7ca4)
Tint the window titlebars even if the option to make them accent-colored is not
explicitly enabled; in this case you want them tinted anyway because they're a
part of the fill window which will get tinted.
BUG: 455395
FIXED-IN: 5.25.2
(cherry picked from commit 2d272745eb)
KSMServer sets which session to use on startup
`KSmServer::restoreSession(QString)`
When the session is up and ready either systemd or plasma-session invoke
`restoreSession()` that actively starts restoring clients.
At some point we need to notify kwin which session we're using so that
it can handle restorng window properties such as the virtual desktop.
This was done in the first call, but this has no guarantee that kwin has
started yet. Without kwin getting the DBus call it has no information to
match up restoration information.
The state RestoringWMSession is dropped as it does nothing useful.
BUG: 442380
(cherry picked from commit a22ff36edf)
In `combineImages`, the width and the height were calculated
incorrectly. This makes the preview image correctly obey the device
pixel ratio of the primary screen, so the preview image can be clear
and sharp.
BUG: 413673
FIXED-IN: 5.25.1
(cherry picked from commit b96d56ae17)
This makes the code and user-facing configuration for accent coloured titlebars
unable to produce some bad results that it previously could.
(cherry picked from commit a671178a8f)
Clipboard history item actions are added to the menu by
KlipperPopup::rebuild() or PopupProxy::tryInsertItem().
The actions are removed from the menu again at the start
of KlipperPopup::rebuild(), but were never deleted.
(cherry picked from commit 80539089c9)
After location is set, one layout script will usually start adding widgets.
It's required to emit formFactorChanged() to update plasmoid.formFactor bindings
in QML side to avoid Layout issues.
See isHorizontal in plasma-desktop/containments/panel/contents/ui/main.qml
(cherry picked from commit 871d6104d3)
Unfortunately, the list<> basic QML type is too primitive, it does not
even expose any kind of remove() functionality, so the only supported
way is to create a new list and assign it instead.
This fixes the bug when there may appear multiple empty or duplicating
actions in the expanded view due to the fact they they were only added
to but never cleaned up / removed from the list of contextual actions.
BUG: 449778
(cherry picked from commit af98cef3ef)
If the time between logout and relogin is short enough or a separate session
is open during that time, the systemd user instance keeps running. This means
that generators like the one for XDG autostart handling aren't run again, which
effectively means it's still using the configuration from the previous session.
Just reload systemd on every login to make sure its state is fresh.
(cherry picked from commit e1b146551a)
A few KDE versions ago, the KCM and app results were provided by the same plugin.
To make sure they do not appear very far down the list, the plugin id is inserted right after the services runner.
CCBUG: 446239
(cherry picked from commit fcbb1de7a8)
Fabian Vogt
Jonathan Esk-Riddell
David Edmundson
l10n daemon script
Dominic Hayes
Chris Holland
Alessandro Astone
Eugene Popov
Nicolas Fella
ivan tkachenko
Derek Christ
Fushan Wen
Aleix Pol
Tanbir Jishan
Jan Blackquill
Jonathan Marten
Alexander Lohnau
Devin Lin