Summary:
BUG: 400663
FIXED-IN: 5.15.0
Test Plan:
Before: {F6455075}
After: {F6459462}
(label alignment being a bit off is unrelated to this patch)
Everything still works.
Reviewers: #plasma, #vdg, mart, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: alexde, mvourlakos, abetts, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17354
Summary:
use QQC2 and FormLayout for alignment
also, qqc2 combobox doesn't suffer from 390801 anymore
BUG: 390801
Test Plan: tried to set all the options
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17333
Also, when an appointment has no description, let the title use both lines of text,
and center them vertically if it doesn't need both lines.
The tooltip is only enabled if the title is actually elided, otherwise it could be bothersome to have.
BUG: 378970
FIXED-IN: 5.12.0
Differential Revision: https://phabricator.kde.org/D9641
This patch makes the digital clock use a smaller font when used in a
horizontal form factor.
BUG:375969
Test Plan: Play with the widget settings in different panels/desktop
Reviewers: #plasma, #vdg, romangg
Reviewed By: #plasma, romangg
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6764
Summary:
A user can "pin" the calendar so that it won't get closed on focus
change, but only when the clock is clicked again.
This persists across open/close operations, but currently doesn't
persist across Plasma restarts.
This patch loads the saved config value of the last pinned state.
Test Plan:
Opened calendar, set pin, closed it, reopened and it was still pinned
(which is the current state)
killed plasma, restarted plasma, was still pinned (new)
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8252
This makes the font selector more compact and moves it to the end of the dialog.
Settings like show seconds and date are more important than using a custom font for the clock.
Differential Revision: https://phabricator.kde.org/D7633
This replaces the loop with fixed values by an Instantiator creating bindings on the model.
CCBUG: 372090
Differential Revision: https://phabricator.kde.org/D7603
Summary:
- Fixed timezone size and alignment in vertical mode
- Instead of `Flow` use `Grid` for labels as it's simpler and gives better
control over alignment
- Seperator in small horizontal mode centered between date and time and in
height now dependent on label size
- Less empty space around time in small horizontal mode
- Binding loop and initlializting anchor errors fixed
- Elements now size completely down and have always the same ratio to each other
with the time label being the largest
- Round functions removed since they disrupted the resizing for small sizes
- Introduce max font size values for text elements in panel mode
BUG: 367585
BUG: 360059
BUG: 373396
Reviewers: #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3630
When opening the calendar popup of the digital clock plasmoid, the
selection is on the day the popup was last opened -- possibly days or
weeks ago. This patch fixes that.
REVIEW: 129308
Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled
CCBUG:372721
Test Plan: opened all config dialogs both in ltr and ltr layouts
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3456
Summary:
anchor the layouts of config dialogs to left
this way they will look the same normally (they
are positioned at x 0 normally) but will be
anchored to right instead if layout mirroring is enabled
CCBUG:372721
Test Plan: opened all config dialogs both in ltr and ltr layouts
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3456
Summary:
on Qt 5.6/5.7 changed signal was emitted at startup as well,
triggering plasmoid.configuration.onSelectedTimeZonesChanged
in Qt 5.8 this doesn't happen, giving an empty clock at startup
this makes sure allTimezones gets built
Test Plan: with Qt 5.8 the clock is shown correctly
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2946
Summary:
on Qt 5.6/5.7 changed signal was emitted at startup as well,
triggering plasmoid.configuration.onSelectedTimeZonesChanged
in Qt 5.8 this doesn't happen, giving an empty clock at startup
this makes sure allTimezones gets built
Test Plan: with Qt 5.8 the clock is shown correctly
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2946
Summary:
We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user
Test Plan:
tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2936
Summary:
We need Local to be *always* present, even if not disaplayed as
it's used for formatting in ToolTip.dateTimeChanged()
this makes sure local is always in the connected sources, even if
it's not explicitly shown to the user
Test Plan:
tested, local timezone is not shown in clock/tooltip when
selected, and no warnings from dateTimeChanged()
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2936
Summary:
The clock in the vertical panel can't fit, it won't word wrap as the
clock is only one word long - so it needs to have a horizontalFit size
mode (without a minimum size) so that the text always fits without being
clipped.
This brings the vertical state in line with the horizontalSmall state
which also sets a minimumPointSize of 0.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2644
This flips the tooltip when using right-to-left languages
CHANGELOG: Digital clock tooltip is now mirrored when in right-to-left language
Differential Revision: https://phabricator.kde.org/D2421
This flips the tooltip when using right-to-left languages
CHANGELOG: Digital clock tooltip is now mirrored when in right-to-left language
Differential Revision: https://phabricator.kde.org/D2421
The agenda doesn't add a lot of usefulness if there aren't any appointments to be shown.
The weekday and date is also shown in the tooltip and I can see that people might prefer
the older more compact look.
BUG: 364455
FIXED-IN: 5.7.1
Differential Revision: https://phabricator.kde.org/D2056
Summary:
Digital Clock sets fontSizeMode, this scales the font to fit between a
tiny size and a the given size.
In older Qt this used to be between 0 and pixel size - but because
Plasma.Components.Label already set the pointSize we had to set both.
In Qt 5.6 it seems to handle either type of font size being set, so we can
keep with just one.
Test Plan:
Clock still scales to fill space
Clock still switches into compact mode if needed
Reviewers: #plasma, sebas
Reviewed By: #plasma, sebas
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1974
Changing calendar plugins and holidays regions now enables Apply
button in configuration and correctly saves it.
Differential Revision: https://phabricator.kde.org/D1651
Fills the big block of empty space with some nice string.
"No events for today" when today is selected and "No events for this
day" when other day is selected.
REVIEW: 127818
Currently, "Show seconds" has no effect with certain locales (C e.g.)
that already contain the seconds in the ShortFormat.
The reason is that the seconds are only added to the format string
that's used to display the time if they are not part of timeFormatString
already (which is not used at all for the display).
This patch fixes that check and adds them only depending on the
showSeconds config option.
REVIEW: 127623
In kde4 times, the layout of clock's tooltip was nicely arranged using a
table. Now it's a bit of a mess so this brings back some nice layout.
Also simplifies the timeForZone function which is used only for the
tooltip.
BUG: 357005
BUG: 351472
CCBUG: 357004
FIXED-IN: 5.6.0
REVIEW: 124047
Because this code depends on plasma-framework and kdeclarative versions
that will not be released before Plasma 5.5 beta, this needs to be
reverted.
And because beta is also feature and string freeze, this will be
postponed to 5.6.
Reverts these commits:
a179d512b469e13f67374b631f8c5c7232b798d5ea6691a307
Creates separate category for Calendar config, currently
only with "Show week numbers" and a list of calendar
plugins to enable/disable.
REVIEW: 126010
Nate Graham
Marco Martin
Yuri Chornoivan
Bernhard Schiffner
Kai Uwe Broulik
Diego Gangl
David Edmundson
Roman Gilg
Miklós Máté
Jacopo De Simoi
Daniel Vrátil
David Faure
David Rosca
Martin Klapetek
Wolfgang Bauer
Daniel Faust