With shared QML engine this would affect all applets and since we properly escape HTML in notifications now this is unneccessary.
Differential Revision: https://phabricator.kde.org/D11109
Qt's Drag attached property doesn't like it at all when it gets deleted during drag. (QTBUG-65701)
Even though we try very hard to keep the popup open, when you have multiple notification applets, their dialogs don't know each
other but access a shared data engine.
This means that, since there can only we one hovered dialog at a time, another notification applet might still dismiss the
notification and have our dialog close.
By using a singleton NotificationHelper we 1.) decouple the Drag from the item and 2.) share the "is dragging" state between applets.
BUG: 388684
FIXED-IN: 5.12.0
Differential Revision: https://phabricator.kde.org/D9754
When a notification contains URLs, they will be shown as a large preview (in case of one
thumbnail) or multiple in a strip (similar to what Klipper does).
The previews can be clicked to open the file and can be dragged anywhere (e.g. to a
webbrowser or chat window).
Differential Revision: https://phabricator.kde.org/D3539
When a job finishes, it has an Open button. But we need to check if we
actually have a valid URL first. QUrl::fromUserInput().isValid() seems
like a perfect fit, but as it's not available in QML, I've added it as a
singleton to the notifications helper.
Reviewed-by: Kai Uwe Broulik
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Kai Uwe Broulik
Montel Laurent
Martin Klapetek
Aleix Pol