The current wallpaper image can be set by a Plasma script. In that case,
the wallpaper is not added to the list, so also check the current image
is already added after opening the config dialog.
BUG: 458364
FIXED-IN: 5.26
Dark wallpapers are put in contents/images_dark folder. The dark
wallpaper will be used when system color scheme is dark.
FEATURE: 207976
FIXED-IN: 5.26
`wallpaper.configuration.Image` has string type, and assigning a string
value from QML to a url in C++ will truncate the string at the hash char.
This changes `image` data type to string to fix the bug.
BUG: 454692
FIXED-IN: 5.26
So far we were loading the slideshow model right at startup which
iterates through all the backgrounds on the system.
This changes so that it's only created when it's needed, which helps to
remove some startup disk accesses.
It should also give us less background-related warnings at startup as
they won't be all checked immediately.
BUG: 371455
The QStringView::to<Number>() methods in Qt5 cause one extra allocation
compared to the QStringRef counter-part. As long as we aren't on a hot
path this is probably not worth the extra #ifdef though.
This allows people to specify that all of the wallpapers in each folder
need to be displayed before moving onto wallpapers in the next folder.
BUG: 426529
FIXED-IN: 5.23
Summary:
Instead of loading the model and then showing the last shown image, we can show
it early so that we signal "wallpaper.loading = false" earlier.
CCBUG: 371455
Test Plan: Have massive slideshow, login
Reviewers: davidedmundson, broulik, #plasma
Reviewed By: davidedmundson, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27084
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
Summary:
- Correct the destination path when downloading images.
- Switch from FileCopyJob to CopyJob to allow showing file overwrite dialog.
BUG: 379469
Test Plan: Drop files from Firefox to the desktop to set the wallpaper successfully.
Reviewers: #plasma, mart, ngraham
Reviewed By: #plasma, mart, ngraham
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26525
Summary:
BUG: 415461
FIXED-IN: 5.18.0
Depends on D26510
Right now when you first change the wallpaper plugin to slideshow, no locations are
pre-configured, so you have to add one yourself. This patch adds a
`preferred:wallpaperlocations` token as the default that gets replaced in the user's
config file at runtime with the XDG wallpaper locations.
Test Plan:
Log in as new user > right-click desktop > configure > change to slideshow wallpaper
See that`/usr/share/wallpapers` is already in the list of wallpaper locations; how nice
Reviewers: #plasma, #vdg, ndavis, davidedmundson
Reviewed By: #plasma, #vdg, ndavis, davidedmundson
Subscribers: davidre, broulik, davidedmundson, ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26483
Summary:
This switches the image plugin to using KNewStuffQuick instead of
launching the widget dialog through that ol' widget dialog hack.
It further uses the big preview mode by default, which just seems
to make a lot of sense for wallpapers.
Test Plan:
Without: Uses the old dialog
With: Uses the new dialog, as seen below
{F7882885}
Reviewers: mart, #plasma, ngraham
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26665
Summary:
QSortFilterProxyModel uses std::stable_sort internally which requires that the
comparison function generates a strict weak ordering. Returning true or false
randomly didn't fullfil this requirement causing a crash in some calls to invalidate.
To keep the random order consistent a vector of row indices is used which records
the current random order.
BUG: 413018
FIXED-IN: 5.17.1
Test Plan:
To reproduce the bug use a slideshow in random order with few pictures and a small
time intervall.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: davidedmundson, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24723
Summary:
Allows setting of other sorting orders like alphabetical or last modified date.
To enable this a new ProxyModel is introduced which handles the sorting and
filtering (as indicated by the checkboxes). This is backed by the slideshowModel
whcih previously as only used for the configutation. The lists of slides and unseen
slides are dropped as now the slides that are shown are taken from the model.
FEATURE: 186181
FIXED-IN: 5.17.0
Test Plan:
{F6938259}
{F6938260}
{F6938261}
{F6938263}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22121
Summary:
This allows to exlude single images from the slideshow by unchecking the little checkbox in the top right corner.
Feature or todo?: If a folder is removed I don't touch the unchecked Slides. So the list could get very big but if a formerly removed folder is
added again an excluded image will be excluded again.
Test Plan:
{F6684113}
- Uncheck some images
- They don't appear in the slideshow
Reviewers: #plasma, #vdg, ngraham, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, davidedmundson
Subscribers: davidedmundson, filipf, abetts, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19687
Summary:
This shows all the pictures inside the folders added to the Folders list. I also tried to make single pictures excludable via a checkbox on the thumbnail. This is the first time for me programming with QT/QML/Singals-Slots and I tried to use as much existing code as possible. The thumbnail view is the same as for single images and I simply subclassed the listmodel. However even if I tried to do everything like the code for slidePaths it doesn't work correctly. The checking/unchecking of images only applies on restart of plasmashell. Maybe it's a single mistake that is easily spotted by a more experienced programmer otherwise if the thumbnail view is accepted I can also revert all the checkbox stuff.
FEATURE: 403703
FIXED-IN: 5.16.0
{F6595564}
Reviewers: #vdg, ngraham, davidedmundson
Reviewed By: #vdg, ngraham, davidedmundson
Subscribers: filipf, mart, alexde, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18809
Summary:
BUG: 402223
FIXED-IN: 5.15.0
Test Plan: Added multiple images from the file dialog. They all showed up in the wallpaper grid.
Reviewers: #konsole, broulik, davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17815
Wait for m_ready until doing anything. This keeps the slideshow from first showing the default wallpaper,
then a random slideshow image, and then fade to the next slideshow image.
Differential Revision: https://phabricator.kde.org/D9763
Fushan Wen
Volker Krause
Aleix Pol
Laurent Montel
David Edmundson
Alexander Lohnau
Mihai Sorin Dobrescu
Nicolas Fella
David Redondo
Marco Martin
Tranter Madi
Nate Graham
Dan Leinir Turthra Jensen
David Redondo
Yuri Chornoivan
Friedrich W. H. Kossebau
Kai Uwe Broulik