This reverts commit 2e4b1e1f2d.
That commit was too broad in scope and changed the sizes of more pieces
of text than were needed to fix Bug 442650. It is fixed correctly in
this commit.
CCBUG: 442650
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.
Here was my full process for making this change:
1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+ " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
On the lockscreen or on a single user system you can currently move the user
item horizontally across the screen without it doing anything. If the list only
contains one entry, disable interacting with it.
Summary:
In the lock screen the user delegate has to elide the text when there
are multiple items next to each other, otherwise it will overlap.
When there's only one item (which is quite common) we don't need to
and doing so looks weird.
Test Plan:
Modified SDDM dummydata/userModel to have one entry with a long name
and back to multiple entries.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7472
Summary:
This (optionally) appends an entry to the SessionsModel to append a "New
Session" option. The lock screen / user switcher are then modified to
use it.
Messages.sh is modified so all components are covered by the same pot.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2594
Summary:
This means if it's used elsewhere (for example the logout screen) we
don't create a pointless attached QObject.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2503
* Remove double setting of delegate width/height
* Calculate delegate height internally instead of hardcoding
* Move notificaton out of delegate so it doesn't move when scrolling
*
Nate Graham
Alexander Lohnau
David Redondo
David Edmundson
Kai Uwe Broulik
David Edmundson
Aleix Pol