This makes the config dialog more responsive when opening it multiple
times, and minimizes network traffic.
The equality check at the beginning of sourceRequestEvent was
completely wrong, if the source (DataContainer) was deleted-because-unused then
we need to proceed with the request even if it's the same as the
previous request. And if the request is ongoing then DataEngine
doesn't call us again, it connects to the existing source...
Summary:
AFAICS the only other user for the engine (other than the applet I'm
porting) is the runner for KRunner, where links don't work anyway.
Port to QRegularExpression while at it.
Test Plan: Tested with the upcoming dict applet.
Reviewers: #plasma, davidedmundson, broulik, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8534
Summary:
Instead of returning "<dl>\n<dt><b></b></dt>\n<dd></dl>"
when the word doesn't exist, return a proper readable string so users
know that the lookup is done and nothing was found.
Test Plan: I'm porting the dict applet to QtQuick, review request coming soon.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8419
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Alexander Lohnau
Nicolas Fella
Friedrich W. H. Kossebau
Laurent Montel
David Faure
Aleix Pol