Those files may be executable and the user wants them to execute. For
example:
- Shell scripts the user has written to perform commonly-used actions
- Windows executables opened with WINE
For this reason, we should stop explicitly blocking running executable
files when accessed with KRunner runners or Kicker/Kickoff/Application
Dashboard, and instead show the typical "open or execute?" dialog that
respects the user's setting for what to do in this case.
BUG: 455924
FIXED-IN: 5.26
BUG: 401579
FIXED-IN: 5.25
Best used in conjunction with with
https://invent.kde.org/frameworks/kio/-/merge_requests/780 which will
allow kicker recentUsageModel not to make any stat call but solely
base its iconName based on passed mimetype, allowing to act as if
KFileItem::SkipMimeTypeFromContent was set.
This is a more generic term that's less likely to be inappropriate
(every document is a file, but not every file is a document) and using
"Recent Files" brings Plasma into consistency with what KIO and Dolphin
call it.
CCBUG: 424007
Summary: And use KNotificationJobUiDelegate in case of errors
Test Plan: Untested other than compilation
Reviewers: broulik, davidedmundson
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29124
Summary:
RecentUsageModel can list all aps and docs,
only aps or only docs. make possible to control that from QML
Test Plan: the api works, all existing code has the same behavior as before
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27782
Summary:
Since D10835 opening urls that needed mimetype determination such as smb:/ or sftp:/ urls were always opened with a "Open With" dialog.
To keep the same security but adding some convenience, use KRun::setRunExecutables to disable executable run here.
Reviewers: #plasma, broulik, aleksejshilin, hein
Reviewed By: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26582
Summary:
Save quite a few KFileItem instanciation.
On each document hovering several KFileItem were instanciated for nothing.
Reviewers: #frameworks, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26416
Summary:
Document entries pointing to unavailable network shares freeze
the application menu, so avoid calling QT_LSTAT (lstat64())
three times for each list item and reading the first 16k of
each document when showing the recent documents list in application
menu.
The current behaviour of accessing each document in the list
just by browsing the application menu is inacceptable in large
enterprise environments where thousands of users work
with documents located on mounted network shares. This induces
additional load on filers and network, slows down working
with the menu and makes its functioning dependent on network
and remote filesystems.
Test Plan:
1. Open a document on a mounted network share, e.g. a text document
on a CIFS share with Libreoffice Writer or Kate.
2. Open the application menu (kicker), look at Recent Documents, the
document's filename should be there.
3. Pull out the network plug, open the application menu, try to open
Recent Documents. Without this patch, the application menu doesn't
work anymore and just hangs. With this patch applied, the menu
continues working.
Reviewers: #frameworks, dfaure, #dolphin
Reviewed By: dfaure
Subscribers: apol, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19784
The InvalidAppsFilterProxy and GroupSortProxy models were creating
circular parent-child relationships by setting themselves as parents
of their parent objects.
Reviewers: davidedmundson, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13856
Summary:
When one tried to open a recent document which happened to be
executable (a shell script, for example), it was run instead.
This was unexpected and could even be disastrous.
After this change, recent documents are always opened.
Reviewers: #plasma, hein, broulik
Reviewed By: #plasma, broulik
Subscribers: ngraham, hein, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10835
Summary:
The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.
This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).
{F1028047}
Test Plan:
Tested in Kicker, Dashboard and Kickoff the following:
Transitioning mechanism:
- load default favorites for the blank user
- load custom default favorites set in the plasmoidsetupscripts script for Kicker
- transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)
Favorite manipulation:
- right-click add favorite to all activities
- right-click remove favorite from all activities
- right-click add favorite to specific activity (current)
- right-click remove favorite from specific activity (current)
- right-click add favorite to specific activity (not current)
- right-click remove favorite from specific activity (not current)
- right-click move from all to specific
- right-click move from specific to all
- right-click move from one activity to another
- dnd reorder items in the model (up)
- dnd reorder items in the model (down)
- dnd add to favorites at a specific position
Other:
- launch the application
- ordering persists after restart
- ordering from the previous is kept on the activity that has no ordering
Reviewers: mart, hein
Reviewed By: hein
Subscribers: Zren, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3805
Summary: Created a new tab to show most used documents/applications, disabled by default.
Reviewers: hein, mart, sebas
Reviewed By: hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5620
Summary:
This would partially fix https://bugs.kde.org/show_bug.cgi?id=369242
Another patch is required not to show empty elements (in case `data()` returns `QVariant()`).
Reviewers: hein, #plasma, davidedmundson, mart
Reviewed By: #plasma, davidedmundson, mart
Subscribers: mart, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2846
Summary:
This would partially fix https://bugs.kde.org/show_bug.cgi?id=369242
Another patch is required not to show empty elements (in case `data()` returns `QVariant()`).
Reviewers: hein, #plasma, davidedmundson, mart
Reviewed By: #plasma, davidedmundson, mart
Subscribers: mart, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2846
"new KRun" is only meant to run absolute file paths and so breaks when we get a
service with relative entryPath() like when finding a KCModule.
The tempFile argument causes this call to be asynchronous as to not block the UI.
Once we can depend on KDE 5.24 and D1902 is merged, use KRun::runApplication instead
Differential Revision: https://phabricator.kde.org/D1898
Summary:
For the Plasma 5.7, we will be able to use the kactivities-stats
framework instead of having our internal copy
Reviewers: mart, sebas, hein
Subscribers: plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D1086
Alexander Lohnau
Nate Graham
ivan tkachenko
Laurent Montel
Aleix Pol
Volker Krause
Méven Car
Tomaz Canabrava
Oleg Solovyov
Méven Car
Nicolas Fella
David Faure
Marco Martin
Méven Car
Bhushan Shah
Robert Hoffmann
Eike Hein
Алексей Шилин
Friedrich W. H. Kossebau
Ivan Čukić
Olivier CHURLAUD
Kai Uwe Broulik