Summary:
Few unrelated fixes, bunched together:
* move some code from main.qml to PlasmoidItem where it belongs
* easier to understand item size calculation
* where possible, replace parent.parent comparisons with a property in AbstractItem
* get rid of marginHints
* Qt 5.14 compatibility fix in configuration
* formatting etc
Test Plan: Everything should work as before, this is just refactoring.
Reviewers: #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27085
This wasn't an issue before as notification popups could never have focus.
However, now with quick reply they can, leading to funky results and gaps when a notification appears while answering another one.
Differential Revision: https://phabricator.kde.org/D27134
Summary:
If StatusNotifierItem is registered and then immediately destroyed, it is possible that QDBusServiceWatcher will not emit the serviceUnregistered signal.
Add an additional check to avoid such situations.
BUG: 416652
FIXED-IN: 5.18.0
Test Plan: Telegram should not add empty items.
Reviewers: #plasma_workspaces, #plasma, davidedmundson
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27126
The category was only used for proper Plasma::Applet instances but not unloaded plasmoids from pure metadata.
BUG: 416947
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D27068
The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g. QUrl("Garbage Url") is still valid.
There is no way to change the strictness of a QUrl after creation,
so the code would enforce it by doing QUrl strictUrl(inputUrl.toString(), QUrl::StrictMode).
However, toString() defaults to PrettyDecoded which avoids percent-encoding and keeps spaces
in tact which is not a valid thing to have in a strict URL.
Effectively, we want to ensure a URL is either a valid path to a local file,
or one of the special applications (for menu ids), or preferred for preferred applications, like web browser,
BUG: 385727
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D26941
Summary:
In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.
This patch removes it from those places
BUG: 416578
FIXED-IN: 5.18.0
Test Plan:
Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.
Please review carefully as this code is fairly unfamiliar to me.
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26845
This is supposed to replace manual DBus calls to KLauncher setLaunchEnv done in e.g. the KCMs,
so this can easily be extended in the future.
Differential Revision: https://phabricator.kde.org/D26993
Summary:
ContainmentActions had some old windows code was dropped as that's
clearly unused.
logout and leave actions now enable/disable at runtime, so in future can
respond to config changes when that's added to libkworkspace.
DataEngines and the krunner code should have no visible changes
Test Plan:
Left from the desktop and from krunner
Changed the default action in ksmserver's kcm
Confirmed that changes the default leave action changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21764
Summary:
We switched to .jpg for Next but SDDM theme's code still points to .png so we got a white screen instead.
Have the code point to .jpg instead.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27018
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
Summary:
It doesn't make sense to pass const `QWindow`s to `PanelShadows` because
a `KWindowShadow` needs a mutable `QWindow` object.
Test Plan: const_cast in PanelShadows::Private::updateShadow is gone \o/
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26985
Summary:
now look and feel packages can specify a default image wallpaper.
when a new containment is created at first plasma start or at activity creation
search for a default wallpaper inthe order:
look and feel package
if fails, from the plasma theme
we are sure to find a default after it as if neither of those specify one,
the wallpaper specified by the breeze plasma theme (Next) will be used
D21225 takes care of setting the wallpaper when a lnf theme is selected by the kcm
Test Plan:
tested to start plasma with an empty config file with different themes
that do or don't include wallpapers
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: kossebau, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21226
Konrad Materka
Jonathan Riddell
l10n daemon script
Marco Martin
Kai Uwe Broulik
Nate Graham
David Edmundson
Filip Fila
Vlad Zahorodnii