The finished signal is not emitted when the dialog is just closed and neither is the reject signal.
Since the dialog is DeleteOnClose we can just connect to QObject::destroyed
Differential Revision: https://phabricator.kde.org/D1044
The KCoreAddons header was introduced with 5.20 and
839900875b266ec85c10167b48fe3988fde8b8da already #ifdefs its newly
added functionality, just not that header.
REVIEW: 127258
In the unlikely event that the user right clicks the SNI and chooses "Report Bug",
while we show a notification with exactly this option, we should still close it.
Instead of showing the full DrKonqi dialog, drawing a lot of attention to a crash,
a Status Notifier Item will be placed in system tray. For auto-restarting system
services like Plasma a crash would often go unnoticed if it weren't for the DrKonqi
dialog showing up. Additionally, regular application crashes will spawn a desktop
notification offering to report a bug or restart the application.
The Status Notifier Item hides after one minute because if the user didn't bother
within that time he probably forgot what he did to cause the crash anyway. If the
session is idle the SNI stays indefinitely so a crash of a long over-night task
like video rendering can still be reported.
If no notification service is running and the application did not auto-restart
regular DrKonqi will show up right away.
REVIEW: 126515
Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
KWebView is not used to load a page here, it is just used to display
HTML with setHtml (without baseUrl) so any external URLs (stylesheets,
images, ...) are not resolved.
Replacing it with QTextBrowser should provide similar rendering.
REVIEW: 125886
The "mappings" file is not installed in the 'GenericDataLocation', it is
installed under the drkonqi prefix in /usr/share/. We should look for it
in the correct place.
Reviewed-By: Aleix Pol
Cherry-picked from b67f430134
The "mappings" file is not installed in the 'GenericDataLocation', it is
installed under the drkonqi prefix in /usr/share/. We should look for it
in the correct place.
Reviewed-By: Aleix Pol
Only drkonqi and systemmonitor depend on it.
(systemmonitor uses libksysguard's processui lib, which is not installed
by libksysguard if webkit is not found)
REVIEW: 121718
Token-based security was failing on Linux if there were cookies in the
KCookieJar, causing crash reports not to be accepted by bugs.kde.org.
CCMAIL: iandw.au@gmail.com
In July 2014, the bugs.kde.org database switched to v4.4.5 of Bugzilla
and cookies were no longer accepted, causing bug 337742. This patch uses
the new security system, based on tokens, and implements the future use
of passwords only, whenever Bugzilla changes to the announced v4.5.x. It
also avoids a crash in Dr K on Apple OS X when KCookieJar is not found.
Forward port of review 120431 to plasma-workspace.
REVIEW: 120876
Kai Uwe Broulik
Aleix Pol
David Edmundson
Heiko Becker
David Edmundson
René J.V. Bertin
l10n daemon script
David Rosca
Montel Laurent
Elias Probst
Christoph Feck
Christoph Cullmann
Vishesh Handa
Lukáš Tinkl
Jonathan Riddell
Bhushan Shah
Hrvoje Senjan
Alex Richardson
David Faure
Ian Wadham
Christoph Feck