History doesn't use the KlipperPopup at all, it just creates it and
provides it through the ::popup() method. This can also be done by
Klipper directly turning History in a data only class.
When inserting an existing clipboard item again it became marked as a
user selected top because the call sequence to set m_topIsUserSelected
to false was incorrect.
Also when removing a user selected item it didn't get reset causing the
next (not selected) item to be marked as user selected.
The History set the m_top to the value of m_top when removing the last
history item. This would result in a crash if one would access the first
element after removing the last item (invalid pointer).
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Montel Laurent
Martin Gräßlin
Aleix Pol