Summary: The current default setting is "Scaled", which results in images that don't match the screen's aspect ratio being compressed along the X or Y axis which almost never looks good. Cropping the image instead of deforming it is a much better default setting.
Test Plan:
- Create new user account
- Right-click on desktop > Configure Desktop
- See that "Scaled and Cropped" is the default setting for the Image and Slideshow plugins
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18004
Summary:
There's a bunch of code referring to this setting but not such a setting,
so the qml engine is confused and outputs tons of warnings
Reviewers: #plasma, guoyunhe, ngraham, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8807
Summary:
Whilst using units is generally good, the wallpaper transition time is
way too short. It's a different type of animation to the others,
especially in a slideshow, where the transition is an important part of
the behaviour.
This patch loads it from a hidden configuration option with a duration
of 1000ms, if and only if animations are enabled.
Value determined through brief trial and error.
BUG: 365979
Test Plan:
Opened wallpaper. Clicked next.
Also changed static wallpaper manually, transition looked fine
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4370
Directly expose "targetSize" as property. The wallpaper is already initialized with
the correct size for some time now but the fact that we had two properties width and height
in there had it still do unneccessary work when it emitted "sizeChanged(2560, 0)" and
then the final "sizeChanged(2560, 1440)" afterwards.
Also, I didn't really see a point in storing the wallpaper size in its config,
it's overwritten by the wallpaper anyway and only used in the wallpaper config dialog
for the aspect ratio. We can just ask the view directly then.
BUG: 374689
FIXED-IN: 5.9.0
Differential Revision: https://phabricator.kde.org/D4001
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Fushan Wen
Aleix Pol
Daan De Meyer
Nate Graham
David Edmundson
Kai Uwe Broulik