The previous calculation multiplied the DPR by `units.smallSpacing`, which was not correct; we wanted DPR added to the existing margin, not multiplied by it.
Also using Math.floor is safer since Math.round sometimes rounds up (e.g. in case DPR is 2.501) which can cause undesirable effects.
BUG: 425911
This brings the PlasmoidHeading used in the notification item into
visual consistency with other PlasmoidHeadings, once we merge
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/98.
When using a color scheme that lacks Header colors, there is no visual
change whatsoever.
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
Many applets shouldn't actually appear on the phone, like
devicenotifier, the battery applet, the systray and so on
Populate all desktop files of the plasmoids with the proper
formfactors. on the desktop we keep showing everything.
on the phone most of those applets will be filtered out
Also take into account of the formfactors when populating the available
categories, wo we don't have the risk of seeing empty categories
This unit is neutral, it doesn't distinguish between e.g. file and dirs,
just counting items. Useful in e.g. notifications of batch rename jobs.
CCBUG: 422098
When calculating the popup location for center alignment, we added the
popupEdgeDistance to it, which resulted in the notifications offset by
units.largeSpacing*2 to right.
It does not make sense to add popupEdgeDistance when notification is
aligned in horizontal center.
Instead of using highlight as background and painting over that with a
transparent colour, make the chart empty out but flip it so the
direction is the same. This removes any aliasing artifacts that occur
due to antialiasing.
BUG: 423079
The available screen rect for notification popups is horizontally restricted by the panel they're in.
This way when you have a centered panel, the notification popup are "emitted from the panel" rather
than floating in mid air. The horizontal edge (left or right) is determined by which half of the
panel the notification plasmoid is in. When in System Tray, the location of System Tray is relevant.
For a vertical panel, it changes the position from bottom to top based on which half of the screen
the notification popup is on.
This affects only the default "near notification icon" placement setting. Manually setting a screen
corner still moves the notification popup all the way to the screen corner.
Summary:
CCBUG: 417836
Depends on D29711
As this will depend on Frameworks 5.71, it will be landed on master after branching,
ending up in Plasma 5.20.
Test Plan:
Right-click on applets and activate their configure menu items
Open applets and click on their settings buttons
Observe that the KCMs are opened in System Settings or Info Center
(depending on the context)
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29712
Summary:
When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.
BUG: 421344
Reviewers: ngraham, plasma-devel, broulik
Reviewed By: ngraham, broulik
Subscribers: broulik
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29651
Summary: The negative top margin was not necessary and causes missing round corners.
Test Plan:
No visual change on master
With D29479, rounded corners should appear again
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29490
Summary: This hides the plasmoidHeading on history for not grouped notifications
Test Plan:
After:
{F8288756}
Reviewers: broulik, ngraham
Reviewed By: broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D29474
When setting "until turned off" it effectively sets it to today in a year. Now with leap year this appears to have broken.
Instead, just use 100 days, which is plenty, even if we come up with a "for 1 month" option maybe.
Differential Revision: https://phabricator.kde.org/D28740
Summary:
The Clipboard and Notifications applets live in plasma-workspace; port them to use
Kirigami.PlaceholderMessage
Test Plan:
Clipboard: {F8253980}
Notifications: {F8253981}
Reviewers: #vdg, #plasma, broulik, niccolove, cblack
Reviewed By: #vdg, #plasma, niccolove, cblack
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T13021
Differential Revision: https://phabricator.kde.org/D29109
Summary:
Somehow the notification pop-up's positioning has never felt quite right to me. When it's
in a bottom corner, it blocks the view of the latest messages in chat apps, or the text
I'm searching for in Kate. When it's in a top corner, it blocks part of the open app's
toolbar or tab bar that I often use. The best place I've found for is in the top-middle,
which doesn't block very many of the thing I'm active using, and its centered position
feels aesthetically pleasing. I've been using this for a bit and quite like it.
However there is ony deficiency: the pop-up is not very wide, so it becomes quite tall
when displaying multi-line messages from chat apps in particular, which makes the
notification stack intrude into the middle of the screen where it definitely blocks things
you want to be looking at. This is annoying.
This patch resolves that issue by making the pop-up's size wider and the spacing between
pop-ups smaller when the pop-ups are positioned in the top or bottom middle.
Test Plan:
Centered pop-ups now look like this:
Single pop-up: {F8247020}
Stack of pop-ups: {F8247025}
There is no visual change for pop-ups in the corner, where they are by default.
Reviewers: #vdg, #plasma, broulik, ndavis, cblack, bshah
Reviewed By: #vdg, #plasma, broulik, ndavis, cblack, bshah
Subscribers: bshah, IlyaBizyaev, ndavis, cblack, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28989
Summary:
As per D28575, converted the FullRepr to be a Page and added a PlasmoidHeading
Result:
{F8215954}
Depends on D28575
Test Plan: Test with D28575
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D28576
This mutates the source array.
In practice actions don't really change in existing notifications but still better to not do that.
Differential Revision: https://phabricator.kde.org/D28650
This ensures that newer notification popups don't push old ones out.
Some applications are notorious for spamming the user which right now results in a firework
of notification popups. With this patch only the number that fits on screen is displayed and
everything beyond that is off screen until there's enough room for new popups which are
then gradually lowered.
It also reduces the likelihood of the notification the user is interacting with being shifted
away by an incoming notification. Furthermore, since notifications that are off screen will
have their timeout reset, it can happen that you have a bunch of recent notifications at the
bottom but then get some old ones that were off screen sliding back in because some middle ones
have expired already, leading to awkward results.
Notification scoring (e.g. critical before normal) is untouched, so a "battery is critical" notification
will show up even if it's still chugging through the backlog of browser notifications.
Differential Revision: https://phabricator.kde.org/D28646
Nate Graham
Carson Black
l10n daemon script
Kai Uwe Broulik
Riccardo Robecchi
Marco Martin
Ahmad Samir
Bhushan Shah
Arjen Hiemstra
Niccolò Venerandi
Eugene Popov