plasma-workspace

Commit Graph

Author	SHA1	Message	Date
Eike Hein	781bb34269	Expose rowCount as data role in TaskGroupingProxyModel. Summary: This adds a new data role "ChildCount" to AbstractTasksModel and implements it in TaskGroupingProxyModel. The purpose of this data role is as a means of signalling to a Qt Quick delegate for a top-level row that a property of the item - namely the number of children it has - has changed. Qt Quick's poor support for tree models makes the existing way of signaling this (rowsInserted) prohibitive to use. The Task Manager applet needs this info because it's in charge of telling the window manager about the screen coordinates of window delegates (through support code in this library). When a window is directly added to an existing group, there is no new delegate created, nor does the existing delegate change position. An increase of ChildCount will be used in this case to decide to publish delegate geo for the new window. CCBUG:372699 Reviewers: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D3482	9 years ago
Eike Hein	9314abc1c8	Expose rowCount as data role in TaskGroupingProxyModel. Summary: This adds a new data role "ChildCount" to AbstractTasksModel and implements it in TaskGroupingProxyModel. The purpose of this data role is as a means of signalling to a Qt Quick delegate for a top-level row that a property of the item - namely the number of children it has - has changed. Qt Quick's poor support for tree models makes the existing way of signaling this (rowsInserted) prohibitive to use. The Task Manager applet needs this info because it's in charge of telling the window manager about the screen coordinates of window delegates (through support code in this library). When a window is directly added to an existing group, there is no new delegate created, nor does the existing delegate change position. An increase of ChildCount will be used in this case to decide to publish delegate geo for the new window. CCBUG:372699 Reviewers: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D3482	9 years ago
Eike Hein	5e30fc609e	Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in XWindowsTasksModel. Summary: This makes grouping work for apps we can't find on the system and can't produce a launcher URL for, such as wine clients. Any better app will use our superior codepath, the wonky ones like wine then get left to making sure their WM_CLASS Class makes sense as per the ICCCM spec. Of course this doesn't work for XWayland clients on Wayland though. BUG:368078 Also nixes an obsolete FIXME and adds a small check to avoid producing launcher URLs that are only the window icon pixmap query element. Reviewers: #plasma, davidedmundson, broulik Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D2804	10 years ago
Kai Uwe Broulik	4a8877bab2	[Libtaskmanager] Add "requestOpenUrls" to open given URLs with the associated application Differential Revision: https://phabricator.kde.org/D2391	10 years ago
Eike Hein	b5cdc85975	Expose window and screen geometry; filter by screen geometry instead of number.	10 years ago
Eike Hein	b4baf3d41e	Revert "Do screen filtering by screen geometry rather than number." This reverts commit `332b96b363`.	10 years ago
Eike Hein	332b96b363	Do screen filtering by screen geometry rather than number. Summary: Avoids problems stemming from libtaskmanager and plasma-framework's AppletInterface::screen numbering screens differently (QScreen order vs. who knows what). CCBUG:365246 Reviewers: #plasma, graesslin, mart Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D2143	10 years ago
David Edmundson	b7f0f2fae7	Add TaskManager requestActivities Summary: Acts like requestVirtualDesktops only with a QStringList make runningActivities invokable Test Plan: See subsequent plasma-desktop review Reviewers: hein, #plasma Reviewed By: hein, #plasma Subscribers: hein, mart, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1814	10 years ago
Eike Hein	00fb293d79	Add a prop to toggle the special grouping behavior for tasks in demanding-attention state. Summary: This is needed for subsequent feature work which needs to be able to turn this off. This review also includes a number of bug fixes to the model: - Fix an off-by-one when explicitly breaking a group apart. - Fix rowCount() returning the value for a top-level item with the same row when called for a group member. - Fix updating/invalidating persistent indices endRemoveRows() doesn't know how to handle. - Update data for former parent item ahead of child-reparenting insert when breaking a group apart. None of these fixes actually matter for the applet view, but they obviously improve correctness, and will matter for later work. Reviewers: davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1838	10 years ago
Eike Hein	2d7b6692d3	Add missing hasChildren() implementation. Summary: QAbstractProxyModel forwards hasChildren() to the source model, which will return a wrong value for our tree-restructuring model. Current views/proxies don't call hasChildren(), which is how this oversight happened, but implementing it improves model hygiene - could blow up in the future otherwise. Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1799	10 years ago
Eike Hein	8fd9770b50	Import next-gen libtaskmanager. Summary: Depends on D1721. Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D1722	10 years ago

12 Commits (882fc8d0ff94abc0cbddb34af1b2853f89dc16ca)