Having an "Add Panel" item in the panel context menu communicates to the
user that the new panel will be placed on the existing panel somehow, or
at least will bear some relationship to it. However this is false; the
new panel is added to the desktop containment, not the panel
containment. Therefore it is inappropriate to have this item in the
panel context menu since it has nothing to do with the panel that has
been right-clicked on.
This action is the "Open in Dolphin" menu item in the context menu. This
menu item is not very useful; there is little reason to open the entire
desktop view in Dolphin because it's already visible on the desktop!
Disabling this item by default makes the context menu a tiny bit more
approachable by removing a fairly useless item from it.
With a multi-screen setup, it's possible to get into a situation where
all of your means to launch apps have gone missing because a screen
forgot its containmewt or moved the only panel onto a disabled output,
or any number of other issues that unfortunately have not yet been
resolved. In such a situation, it is common for people to try to fix it
by visiting the KScreen KCM to switch around their primary screens,
enable disabled outputs, turn it off and on again, etc.
However if your only visible means to launch apps has gone missing, you
may have a hard time accessing the KScreen KCM. In such a circumstance,
it can be helpful to have the action in the desktop context menu so that
people can right-click on the wallpaper of any screen that *is* working
and make System Settings launch with the KScreen KCM on that screen.
Co-authored-by: Nate Graham <nate@kde.org>
BUG: 355679
FIXED-IN: 5.24
This commit implements what was agreed upon in
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/690, but
does it correctly by simply disabling the menu item by default, not
removing it entirely. This ensures that the change is only made for new
installs. Existing users' configs will not be touched (because all
values are serialized to the config file already), and any new users
will be able to re-enable this item if they like it.
CCBUG: 437747
This reverts commit 1cb254416c.
This change was not implemented in the correct way. The context menu is
configurable, so instead of removing the possibility of the menu item
ever being in the menu, we should have simply removed it from the
default set of menu items.
BUG: 437747
FIXED-IN: 5.22
In the past, this was considered to be a way to make KRunner more
discoverable by users.
However today Kickoff exposes all the same runners as KRunner, so its
full functionality is therefore more discoverable in a different way,
so making the KRunner UI itelf more discoverable is not as important.
Furthermore, this was always a questionable way to increase
discoverability in the first place, because the menu item did not expose
the keyboard shortcut, which is the typical way that people show
KRunner. Also, context menus are generally considered shortcuts for
experts; novice users don't tend to use context menus very much. But
experts are the people more likely to already know about KRunner and its
keyboard shortcut, and would never invoke it using the desktop context
menu.
Removing this menu item de-clutters the desktop context menu a bit, and
we do get complaints that the menu is overwhelming because it has too
many things in it. This is a fairly unimportant item that we can remove
without any real consequences.
Finally, Marco didn't like the change to refer to KRunner using the
actual term "KRunner" in the main UI, so this change removes one of the
two places where that happened. :)
This came up in today's VDG meeting. A user who right-clicks on the
desktop is highly likely to want to change the wallpaper, but the menu
item that does this is the last item in the menu, not the first. We can
move it up to the top.
The "Open with Dolphin" item is likewise moved up too so that we don't
have two single-item sections in a row.
Summary:
In Plasma, 5.18, this ishn't a user-facing option anymore. It's still visible in the
context meny configuration dialog though, and it's still referenced in some of the
context menu building code.
This patch removes it from those places
BUG: 416578
FIXED-IN: 5.18.0
Test Plan:
Context menu still looks the same on the desktop and panel, both in and out of edit mode
The action no longer shows up in the configuration UI.
Please review carefully as this code is fairly unfamiliar to me.
Reviewers: mart, #plasma
Reviewed By: mart, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26845
Summary:
ContainmentActions had some old windows code was dropped as that's
clearly unused.
logout and leave actions now enable/disable at runtime, so in future can
respond to config changes when that's added to libkworkspace.
DataEngines and the krunner code should have no visible changes
Test Plan:
Left from the desktop and from krunner
Changed the default action in ksmserver's kcm
Confirmed that changes the default leave action changed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21764
Summary: "Edit Panel..." already enters the edit mode, so there's no need to clutter the context menu with another "Customize Layout..." menu item.
Test Plan: Open the panel context menu.
Reviewers: #plasma, #vdg, mart, ngraham
Reviewed By: #plasma, #vdg, mart, ngraham
Subscribers: mart, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25053
Summary: Not needed for normal users with the new edit mode system.
Test Plan: Lock the widgets before compiling this patch. Then compile with it, unlock widgets and see that there is no lock option in the panel context menu.
Reviewers: #plasma, #vdg, ngraham, mart
Reviewed By: #plasma, #vdg, ngraham, mart
Subscribers: broulik, mart, ngraham, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24839
Summary:
edit mode menu action
edit mode dbus property for systemsettings
containmentlayoutmanager goes out of edit mode only when the whole
plasma app loses focus, so the panel controlled doesn't make it go out
of it
Test Plan:
iaction shows in context menu, works
property exposed on dbus works
Reviewers: #plasma, #vdg, ngraham, GB_2, davidedmundson
Reviewed By: #plasma, #vdg, ngraham, GB_2, davidedmundson
Subscribers: GB_2, ngraham, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10190, T11094, T10402
Differential Revision: https://phabricator.kde.org/D24264
* Don't autostart KRunner, use actions in the desktop file to
define global shortcuts and actions
* install its desktop file in share/kglobalaccel to make shortcuts default
* expand commandline options to permit more control via commandline
Differential Revision: https://phabricator.kde.org/D9037
Summary:
We are currentlly very inconsistent how we refer to KRunner, impairing comprehensibility
among both expert users (who know it as "KRunner") and novice users (for whom "Run
Command" has a literal and somewhat scary meaning).
This patch is a part of {T10966} and standardizes on "Show KRunner", helping to turn
KRunner into a user-visible brand name like Apple's Spotlight.
Test Plan:
{F6842497}
{F6842498}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Maniphest Tasks: T10966
Differential Revision: https://phabricator.kde.org/D21341
Anyone else checks for run_command. Docs explicitly mention the fact that you have to also
disable action/run_command for the menu entry to appear but this is a bit awkward, isn't it.
Also fix logout to check for the correct place as listed in documentation and other code places.
BUG: 393329
FIXED-IN: 5.15.5
Differential Revision: https://phabricator.kde.org/D12376
We only show the "Remove this applet" option when the panel controller is opened
to prevent the user from accidentally messing up his setup.
However, the "Remove this panel" option, albeit in a submenu, was always there and
is even more destructive.
BUG: 360300
Differential Revision: https://phabricator.kde.org/D1869
Summary:
We already have code in plasma that will hide this action using the KAuthorised ID "plasma/plasmashell/unlockedDesktop".
Including a second ID that will only have an effect in one place isn't
very useful.
Test Plan:
Set
[KDE Action Restrictions][$i]
plasma/plasmashell/unlockedDesktop=false
checked I couldn't see this menu
Reviewers: #plasma
Subscribers: plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D1593
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Nate Graham
Ezike Ebuka
Alexander Lohnau
Felipe Kinoshita
David Edmundson
Björn Feber
Marco Martin
Yuri Chornoivan
Nicolas Fella
Kai Uwe Broulik
Friedrich W. H. Kossebau
Montel Laurent
Martin Gräßlin
Lukáš Tinkl
Aleix Pol