- Some minor code styling (new Array() -> [], new Object() -> {} etc)
- Pass the notification object we get from the data engine to addNotification verbatim
instead of having an ugly function with dozens of parameters we just use to construct
a similar object ourselves anyway
- Push actions into array directly instead of creating a new Object, setting its properties
and then pushing it
REVIEW: 120993
It does not provide onEntered/onExited but we can mimic that with onContainsMouseChanged
This removes the MouseArea which could never occupy the entire highlight area due to theme
margins leading to annoying flickering when moving between items because the one MouseArea
was exited before the next one was entered
Now that the AC Adapter is back in the dataengine, we can reflect the state properly again.
--Plasma Errata
This reverts commit bb6eabc0c9.
Conflicts:
applets/batterymonitor/package/contents/ui/batterymonitor.qml
If if contains HTML tags, Qt will interpret them breaking the layout or even
causing privacy issues (think of copy-pasting an img src="some remote url")
Makes it look better (no empty gap) and given you can change brightness using keyboard
shortcuts and mouse wheel, the looks outweigh the additional mouse travel
BUG: 336708
FIXED-IN: 5.1
Right now the clock applet is using one single label (besides the
sizehelper) to fit time, timezone and also date. This has several
drawbacks like for example the whole label must use one font size, one
eliding etc.
Putting everything into its own label gives way more flexibility as we
can position and size things independently - for example making the time
bigger font than the timezone or date and elide long timezone name
without omitting the date. The sizing is now also simpler and more
robust.
This patch adds the time and timezone labels into Flow which changes
direction based on the layout (in vertical panels layouts things
vertically, horizontal panels either vertically or horizontally
depending on date being shown or not), the date label is then always
appended at the bottom. The reason for dateLabel not being in the Flow
is that in horizontal panels we want the date label always go to the
bottom and be center aligned and Flow does not support horizontal
alignment of its children. Two anchors seems much easier in this case.
This removes two i18n strings and works around having to add another one
(line 352 in the patch) - it's not kosher but I did it so it can still
be merged for 5.1.
Finally, this adds states for separate handling of vertical and
horizontal panels, which has cleaned the code quite a lot from all the
"vertical ? complex_a_stuff : complex_b_stuff".
REVIEW: 120461
Kai Uwe Broulik
l10n daemon script
Martin Klapetek
Marco Martin
Marco Martin