Summary:
BUG: 345940
Move the "Enable Power Management" checkbox to the top of the window to match other applets (bluetooth, network)
Reviewers: #plasma_workspaces, broulik, mck182, davidedmundson, mart
Reviewed By: #plasma_workspaces, davidedmundson, mart
Subscribers: mart, jensreuterberg, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8607
Summary:
This was tricky bug to track down, needed to add debug statements in
literally every functions.
The flow of events is something like this, At startup:
- We don't have information about actual brightness for few seconds
- In this period, brightness slider have default value of 1
- This triggers the function which sets batterymonitor.screenBrightness
- onScreenBrightnessChanged gets called, which sets the actual
brightness
- onScreenBrightnessChanged have a guard for disableBrightnessUpdate but
since we have it marked as false initially, we proceed to set actual
brightness to 1
- However before we set value of brightness to 1, we do get actual
brightness back from dataengine, and our call overrides it to 1 later.
- On desktop we do get 2nd dataChanged event from somewhere, so
brightness is proper, but on mobile that is not case and results in
brightness staying at 1.
To fix this bug, we set disableBrightnessUpdate true at startup, and
when there is actual brightness change from powerdevil or
powermanagement engine, Logic.js takes care of enabling and disabling
brightness change.
(I quite like the boolean trap there in variable name :P .. will fix in
another change in master)
Test Plan:
Tested on desktop and mobile, verified that
- Brightness keys work
- Brightness slider works
- Scroll to change brightness works
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8462
In QtQuick Layouts implicit size, which is taken from the SVG's preferred size, takes
precedence potentially destroying the layout.
Also, it should have been medium to be consistent with the rest.
BUG: 383213
FIXED-IN: 5.8.8
Summary:
The license key is specified as GPL, while the actual code (I checked)
in all these cases is licensed under GPL version 2 or later. This commit
fixes the metadata.desktop files to reflect the actual license.
Test Plan: Manually checked, also compared to the keys looked for in kaboutdata.cpp
Reviewers: #plasma, sitter, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6627
Summary:
This makes it possible to have some more fine-grained control over
the screen brightness with scroll devices that support it, like
touchpads or trackpoints.
Test Plan: Tested with touchpad, trackpoint and scroll wheel on mouse
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5025
Summary:
if there is no battery don't show 0%, but a - on
the badge. still show the badge to show the option is not broken,
but don't show a weird 0% of a non existing battery
Test Plan: works on both systems with or without battery
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4606
Summary:
add an option to show a text label with the percentage value
in the battery icon. text will be shown bottom-right
of the icon with a background for readability, similar to
unread count for IM or email apps.
code was already there but effectively dead code
Test Plan: tried both with and without label
Reviewers: broulik, #plasma
Reviewed By: broulik, #plasma
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3603
This fixes showing "0% charging" on a desktop computer which has a
wireless mouse/keyboard. If there is no battery whatsoever it continues
to show "No batteries available" but for the aforementioned case the
generic "Battery and brightness" is shown in order not to lie to the user :)
CHANGELOG: Battery tooltip no longer shows "0% charging" for computers with wireless mouse/keyboard
BUG: 362924
Reviewed-By: mgraesslin
This fixes the battery icon errorneously showing an empty red battery on a desktop
computer with a wireless mouse/keyboard; instead the "no battery" icon with a
red cross is shown.
CHANGELOG: Battery icon no longer errorneously reports an empty battery if computer has none
CCBUG: 362924
Reviewed-By: mgraesslin
The tooltip now goes as follows, if the AC is plugged in and the battery is not full:
* Charging -> "charging"
* NoCharge -> "plugged in, not charging"
* Anything else -> "plugged in" (just not say "charging" when in doubt)
CCBUG: 350068
The tooltip would only take into account the AC adapter state and say the
battery is being charged although it isn't. This adds a "Plugged in"
state when the AC is plugged in but the battery is not charging.
BUG: 355922
FIXED-IN: 5.7.0
Calculate the plasmoid status and tooltips in a binding rather than invoking
Logic.updateFoo manually; this way we can have the QML engine do what it can do best.
Unfortunately it cannot look inside JS objects, so we cannot have the inhibitions
be handled the same way.
l10n daemon script
Marco Martin
Nathaniel Graham
Bhushan Shah
Pino Toscano
Jonathan Riddell
Kai Uwe Broulik
Sebastian Kügler
Fabian Vogt
Aleix Pol
David Edmundson