Summary:
Tell the parent Dialog class what the location is so it can configure
the dialog accordingly.
Install the desktop file where it can be found by kwin to know about
X-KDE-Wayland-Interfaces=org_kde_plasma_window_management.
While at it, make sure we don't leak if we return early.
Test Plan: Now I get the right animation
Reviewers: #plasma, cblack, davidedmundson
Reviewed By: #plasma, cblack, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28783
Summary:
We are krunner, our default config will be krunnerrc, we can load the
instance we've already loaded in the QPT instead of doing it again.
Reviewers: #plasma, apol, broulik
Reviewed By: #plasma, apol, broulik
Subscribers: apol, plasma-devel
CCBUG: 416145
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28368
Summary:
In wayland, QScreen::availableGeometry() returns QScreen::geometry(), we could get a better value from plasmashell
BUG: 386114
Test Plan: Krunner isn't overlapped by a top panel in all cases
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: meven, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27458
Summary: kcrash must be used else it will not be linked and crashes will crash instead of kcrashing
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23487
* Don't autostart KRunner, use actions in the desktop file to
define global shortcuts and actions
* install its desktop file in share/kglobalaccel to make shortcuts default
* expand commandline options to permit more control via commandline
Differential Revision: https://phabricator.kde.org/D9037
Summary:
We are currentlly very inconsistent how we refer to KRunner, impairing comprehensibility
among both expert users (who know it as "KRunner") and novice users (for whom "Run
Command" has a literal and somewhat scary meaning).
This patch is a part of {T10966} and standardizes on "Show KRunner", helping to turn
KRunner into a user-visible brand name like Apple's Spotlight.
Test Plan:
{F6842497}
{F6842498}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Maniphest Tasks: T10966
Differential Revision: https://phabricator.kde.org/D21341
Summary:
It is not uncommon to run the same command repeatedly. In this case,
the history is actually unchanged - the item is removed from the first
position, and prepended again.
Test Plan:
run the same command twice, config file is not rewritten
run a new command, config is updated
Reviewers: #plasma, broulik, apol
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D20383
Summary:
Don't go through the workaround introduced for X11 that makes it go mental.
BUG: 385693
Test Plan: Have been a happy krunner user since
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10197
Summary: QUrl::fromLocalFile can't be used when packages are qrc
Test Plan: plasashell loads correctly with packages from qrc
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9176
Summary:
enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)
Test Plan:
tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: gladhorn, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7765
Summary:
If a PlasmaShellSurface for an already mapped window is created and set
to panel it affects other windows by adjusting the maximized area. This
happens when showing KRunner for the second time and later. To prevent
this and make KWin's life slightly easier we first set the panel behavior
to windows go below and then mark it as panel. Thus other windows are not
affected by opening KRunner.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6657
Summary:
make the behavior similar to Dialog
create a plasmashell surface only when isVisible() as
some expose events can arrive there too, and also not
create the shell surface if the exposed surface is null
Test Plan: krunner seems to be more reliable
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6299
Summary:
as showEvent is too soon, create the plasma surface on
:Expose event, and reposition the surface
Test Plan: krunner is correctly positioned with correct blur and shadows
Reviewers: #plasma, #plasma_on_wayland, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, davidedmundson, graesslin, plasma-devel
Tags: #plasma_on_wayland
Differential Revision: https://phabricator.kde.org/D5748
Summary:
Panel is the best matching type which gives us the required behavior
like being on all desktops.
BUG: 370158
Reviewers: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3038
CHANGELOG: KRunner global shortcuts are listed in a "Run Command" category rather than "krunner"
Differential Revision: https://phabricator.kde.org/D2426
Summary:
Reduces code duplication and we always opperate on cached value, that
is the platform is only checked once in application life cycle.
Reviewers: #plasma, hein
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2342
Summary:
Using KDeclrative::QmlObject::rootObject before it's created blocks the
thread until it finishes so that code always "works" - but displays a
warning and is slower.
We now no longer get a warning on startup.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2086
It seems Qt removes that hint after the show event if we manually set it but Qt's
own flag is not set. This fixes KRunner showing up behind eg. Yakuake
Checks whether a PlasmaShell interface is available, if so it listens
on PlatformSurface events to create/destroy a PlasmaShellSurface and on
move events the position is updated on the PlasmaShellSurface.
On Wayland that resulted in an endless recursion and also on X11 it's
a little bit too much to update the state on every event.
Let's only do it on the show event (as the comment states) and on
PlatformSurface created events.
When a result is invoked, the query string is prepended to the history, query strings
are only added once. When KRunner is opened, the history will be displayed right away.
The old ComboBox approach caused bad usability because of two vertical lists conflicting
with each other.
REVIEW: 123888
Kai Uwe Broulik
Aleix Pol
David Edmundson
Tranter Madi
Méven Car
Jonathan Riddell
Nate Graham
Stefan Brüns
Yuri Chornoivan
Friedrich W. H. Kossebau
Marco Martin
Martin Flöser
Montel Laurent
Vishesh Handa
Lukáš Tinkl