Which does the rendering and proper sizing for us, e.g. ensure integer scaling so the barcode remains scannable.
While at it, fix supportsBarcode (wasn't routed through to the delegate component when it was split out)
and add Code 128 which is in Prison now.
Also, show a label when the barcode would become too large to display (mostly for the 1D barcodes).
The Prison item does not use a thread for generating the barcode like the dataengine does but it's super fast.
Differential Revision: https://phabricator.kde.org/D29478
Summary:
Otherwise we're discarding style information possibly set in
the user's small font choices when we want to set a smaller
font.
Test Plan: Stuff that's suposta look small still looks small
Reviewers: cblack, #plasma
Reviewed By: cblack, #plasma
Subscribers: ahiemstra, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29437
Summary:
In D29652, I made an annoying mistake: I removed the check if the clipboard is empty when initializing the **Plasmoid.status** of the Clipboard applet. If the user enables the option to save clipboard content, then after restarting the Plasma, even if the clipboard had content, the state of the applet will be **PlasmaCore.Types.PassiveStatus** and its icon will be hidden in the system tray. This patch fixes this issue. I hope it will get into Plasma 5.19.
See: https://phabricator.kde.org/D29652
Reviewers: ngraham, mart
Reviewed By: ngraham, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29818
Summary:
It would be correct to close the Clipboard applet after clearing the history or deleting the last element, since there is nothing more to do with the empty Clipboard applet (similar to how the Notification applet closes after the last notification is removed).
BUG: 421345
FIXED-IN: 5.20
Reviewers: ngraham, #plasma, broulik
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29652
Summary:
The Clipboard and Notifications applets live in plasma-workspace; port them to use
Kirigami.PlaceholderMessage
Test Plan:
Clipboard: {F8253980}
Notifications: {F8253981}
Reviewers: #vdg, #plasma, broulik, niccolove, cblack
Reviewed By: #vdg, #plasma, niccolove, cblack
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T13021
Differential Revision: https://phabricator.kde.org/D29109
Summary:
When I pin a Klipper widget and then click on a history item, the Klipper widget closes.
To fix this bug, we need to check if Klipped is pinned, but to be able to do this, we also need to "forward" the pinned state from the SystemTray applet to the Klipper applet.
BUG: 416510
FIXED-IN: 5.19.0
Reviewers: ngraham, #plasma
Reviewed By: ngraham
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28408
Summary:
Fixed clearing the clipboard when clearing history
(bug #409366 caused by 3bd6ac34ed)
Properly synchronize clipboard content and history
(deleting last item in history didn't clear the clipboard).
Keep last image in history even if we are ignoring images, but without preview
(so that we can still clear history, and the tooltip says truth about clipboard content).
Fixed tray icon tooltip text.
Do not scale small images up in clipboard Plasmoid.
BUG: 409366
{F7168503}
Test Plan:
Spectacle -> [Copy to Clipboard]
Paste into Dolphin (clipboard content)
Deleting single items from clipboard
Clearing the entire history
Reviewers: #plasma, #plasma_workspaces, ngraham, davidedmundson
Reviewed By: #plasma, #plasma_workspaces, ngraham, davidedmundson
Subscribers: GB_2, davidre, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22684
Summary: This patch adds the ellipsis (...) to the search field label in Clipboard so as to make it consistent with the labels in Kickoff, Kicker and KRunner.
Test Plan:
Before:
{F6521497}
After:
{F6521498}
Reviewers: ngraham, #plasma, #vdg
Reviewed By: ngraham, #vdg
Subscribers: abetts, filipf, plasma-devel
Tags: #plasma
Maniphest Tasks: T10258
Differential Revision: https://phabricator.kde.org/D17935
Summary: Use Breeze's new broom-style icon for the {nav Clear History} buttons in the Klipper and Notification plasmoids.
Test Plan:
With Frameworks 5.48, the broom-style icon will be shown:
{F6100570}
{F6103810}
With an earlier Frameworks version or a different icon theme, a backspace-style icon will be displayed:
{F6100573}
Reviewers: broulik, Fuchs, #plasma, davidedmundson
Reviewed By: Fuchs, #plasma, davidedmundson
Subscribers: Zren, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14105
The delegate is quite heavy with lots of seldom used items and opening the clipboard plasmoid takes a significant amount of time.
Differential Revision: https://phabricator.kde.org/D10557
Label has verticalAlignment: lineCount > 1 ? Text.AlignTop :
Text.AlignVCenter
but in this delegate the height stretches to fit the text:
- height depends on verticalAlignment
- lineCount depends on height
creating a loop with this in the middle.
In this case we always want delegates in the middle, so we can just
override the superclass.
Test Plan:
Had text in text edit
pressed escape twice.
First pressed cleared, second closed as before (but from the external handling)
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3259
Qt already did the right thing of moving the buttons to the left but the gradient did not follow.
Differential Revision: https://phabricator.kde.org/D2422
This flips the tooltip when using right-to-left languages
CHANGELOG: Digital clock tooltip is now mirrored when in right-to-left language
Differential Revision: https://phabricator.kde.org/D2421
klipper follows the pattern of a menu, in order to be consistent
with other applets that use this pattern (like launchers or
device notifier) close the menu after cliching on an item
to show the user something happened
BUG:361629
klipper follows the pattern of a menu, in order to be consistent
with other applets that use this pattern (like launchers or
device notifier) close the menu after cliching on an item
to show the user something happened
BUG:361629
We now fade out the text at the end so there's no need for the increased
contrast by the raised ToolButtons. It also makes the list appear cleaner now.
Given we don't let it overflow anyway. This should alleviate the weird
scroll behavior but still doesn't completely fix it. QtQuick ListView
just doesn't like delegates with varying sizes.
CCBUG: 354592
Leading and trailing spaces, tabs, and line-breaks are now highlighted in the
theme's highlight color (blue in Breeze) and replaced by printable characters
REVIEW: 123821
BUG: 159267
FIXED-IN: 5.4.0
Adds a hint when the clipboard history is empty to be consistent with all the
other plasmoids, it's not pixel-perfect but good enough. Also improve alignment
of the search and highlight
BUG: 344159
When clicking the barcode button, the view is changed to just show
the barcode instead of opening a dialog. By default a QR Code is
displayed.
A tool button is added which allows to change the barcode type, with
the following barcodes being supported:
* QR
* Data Matrix
* Code 39
* Code 93
REVIEW: 122402
It does not provide onEntered/onExited but we can mimic that with onContainsMouseChanged
This removes the MouseArea which could never occupy the entire highlight area due to theme
margins leading to annoying flickering when moving between items because the one MouseArea
was exited before the next one was entered
If if contains HTML tags, Qt will interpret them breaking the layout or even
causing privacy issues (think of copy-pasting an img src="some remote url")