It is not possible for the user to launch such an app from the UI, so we should not allow to launch a new instance from the task manager context menu.
BUG: 447204
The style config is saved already when the dialog closes so enabling the KCM apply button doesn't make sense
The comment suggests that this is done for a reason, but the style preview seems to refresh correctly even with this patch
BUG: 439297
We do not display the comment for desktop files
in the panel, task manager or desktop.
Because we no longer depend on desktop-to-json conversion, we
can remove the entries.
Users may complain after setting a wallpaper to all desktops if they are
using activities, so it's recommended to make the action only apply to the
current activity.
To list all activities in the context menu, it requires a new action in
kf5/kfileitemaction, which seems not possible in desktop file.
CCBUG: 358038
There are many languages (including Russian) where three three power
profile titles do take much more space than it is available in applet.
RowLayout's spacing ensures they do not stick to each other side by
side.
Ideally, we should have "shrinking labels" which are capable of
adjusting their text's kerning based on available space. In the
meantime, localization teams are advised to use as short profile names
as possible without loosing their meaning.
Layout code should avoid implicit/preferred size from being influenced
by explicit/resulting size, as it opens possibilities for binding loops
and other errors.
GIT_SILENT
QtQuick.Layouts are easier to manage, and more flexible.
In case of fillWidth+preferredWidth, preferredWidth defines a ratio
rather than an absolute value, so it was replaced with a singleton `1`
instead of a magic number `50`. Since size of this applet propagates
top-down only, it should not affect any calculations, especially
because `50` is too narrow to fit any reasonable text label, except
maybe Chinese.
Rename ids to make them easier to read. They are intentionally named
differently from their aliases to reduce potential confusion, e.g.
* icon -> image
* slider -> control
Having an "Add Panel" item in the panel context menu communicates to the
user that the new panel will be placed on the existing panel somehow, or
at least will bear some relationship to it. However this is false; the
new panel is added to the desktop containment, not the panel
containment. Therefore it is inappropriate to have this item in the
panel context menu since it has nothing to do with the panel that has
been right-clicked on.
This action is the "Open in Dolphin" menu item in the context menu. This
menu item is not very useful; there is little reason to open the entire
desktop view in Dolphin because it's already visible on the desktop!
Disabling this item by default makes the context menu a tiny bit more
approachable by removing a fairly useless item from it.
With a multi-screen setup, it's possible to get into a situation where
all of your means to launch apps have gone missing because a screen
forgot its containmewt or moved the only panel onto a disabled output,
or any number of other issues that unfortunately have not yet been
resolved. In such a situation, it is common for people to try to fix it
by visiting the KScreen KCM to switch around their primary screens,
enable disabled outputs, turn it off and on again, etc.
However if your only visible means to launch apps has gone missing, you
may have a hard time accessing the KScreen KCM. In such a circumstance,
it can be helpful to have the action in the desktop context menu so that
people can right-click on the wallpaper of any screen that *is* working
and make System Settings launch with the KScreen KCM on that screen.
Co-authored-by: Nate Graham <nate@kde.org>
BUG: 355679
FIXED-IN: 5.24
With https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/91
all ScrollView KCMs are frameless by default. This does not work with
the Users KCM due to its somewhat unusual arrangement of displaying two
pages at once, adjacent to one another. This commit opts it back into
the framed style, which looks better, until such time as the layout can
be adjusted to look good with a frameless style, should this be deemed
desirable.
For KCMs we have .desktop files in <share>/applications but with NoDisplay=true.
We still want an appId of kcm_foo to match to the service in <share>/applications/kcm_foo.desktop.
The current code however explicitly excludes those, so stop doing that.
This also allows to simplify the code from KServiceTypeTrader to KService::serviceByDesktopName
This fixes the LauncherUrl for the autostart KCM from file:kcmshell to applications:kcm_autostart.desktop
m_proxies does not always contain all players, and a player is added to
m_proxies only when it has a valid proxyPid. But the container is
ensured to be added to one of m_playing, m_paused and m_stopped.
So we need to ensure m_playing, m_paused and m_stopped are all empty
before emitting `playerListEmptied()`.
BUG: 447169
FIXED-IN: 5.24
Nicolas Fella
Dark Templar
David Edmundson
Noah Davis
Alexander Lohnau
Fushan Wen
l10n daemon script
Aleix Pol
ivan tkachenko
Nate Graham
Ezike Ebuka
Flo Edelmann
Tomasz Lemiech