The scale factor was incorrect because it always compared with 1, which
caused the background image not being resized properly when height >
width.
This commit uses the same scale factor in ToolTipInstance.qml, so the
scale factor is correct again.
1. placeholderMessage and fallbackIconItem are put in the same Loader and
loaded on demand, and they share the same icon property.
2. When getting "Desktop Icon Name", check if `mpris2Source.currentData` is
available first.
3. Hide the details column when no track is available.
BUG: 444322
BUG: 446095
FIXED-IN: 5.24
When no media player is opened and there is a media player applet on the
desktop, `mpris2Source.currentData` is undefined and plasmashell will
report some TypeErrors.
BUG: 446096
FIXED-IN: 5.24
Right now we are bodging the track label into being this, but it looks
bad and doesn't use the standardized component, which it should. So now
it does.
BUG: 444322
FIXED-IN: 5.24
Background image and album art image sometimes do not display at the same
time because there are two Image instances referring to the same path, but
cache will not work because they are loaded simultaneously. Use ShaderEffect
instead of another Image instance to provide the background to fix the bug.
Use State and PropertyChanges to avoid unnecessary reevaluation of width
and height of albumArtBackground.
BUG: 439753
FIXED-IN: 5.23
We get `sourceRemoved` emitted before the source is actually removed
from the list.
This is a change from 5984d4960fa5ecf60a20b1fbc782fb841faa4af7
in plasma-framework but better be safe than sorry.
BUG: 439309
FIXED-IN: 5.23.3
We ported units to use the PlasmaCore.Units singleton earlier; now it's
time to do the same thing for PlasmaCore.Theme.
There are no UI changes or regressions detected.
Doing so takes up extra space and I don't think it's useful information
anyway. If there's only one media player going, the user already knows
which one it is.
Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
Only remove the padding from the tabbar item, to keep the layout centered,
so new elements can be added seamlessly.
The tabbar delegates are also centered on the view by adding this padding
to the top, and removing it from the bottom.
The player buttons looked a bit too close to the footer to my eye. This
commit adds some more whitespace under them to match the whitespace
above them.
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
Many applets shouldn't actually appear on the phone, like
devicenotifier, the battery applet, the systray and so on
Populate all desktop files of the plasmoids with the proper
formfactors. on the desktop we keep showing everything.
on the phone most of those applets will be filtered out
Also take into account of the formfactors when populating the available
categories, wo we don't have the risk of seeing empty categories
With swrast (llvmpipe) the artwork blurring is enabled, which takes an eternity
(up to ~15s) to compile the shader. Improve that by only using half the
samples with half the radius, which looks nearly identical.
l10n daemon script
Bharadwaj Raju
Fushan Wen
Alexander Lohnau
Nate Graham
Kai Uwe Broulik
Aleix Pol
Mikel Johnson
Konrad Materka
Ismael Asensio
Nicolas Fella
Marco Martin
Yuri Chornoivan
Fabian Vogt