Summary:
The "Encoding" entry had been deprecated in 2006
(https://cgit.freedesktop.org/xdg/xdg-specs/commit/?id=6855384d021d88557f80674798c584c15b547f36)
and there is no current workspace known which still requires it being set
(incl. Plasma itself).
Also has the usage been incomplete and sometimes not at the beginning as
required if used (once scripty had sorted all entries in desktop files
alphabetically and it was not restored everywhere).
Removing them altogether creates consistency and avoids further confusion
about and wasted resources for this unused data bit.
Removing those entries also from Plasma/5.12 branch avoid conflicts on
merging to master, given the entries are often next to translated entries,
or generous merging which lets the entries slip back into existance.
Reviewers: #plasma, fvogt, broulik, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11563
Summary:
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.
BUG: 392197
Test Plan:
Deployed change, killed, restarted, and activated KRunner, typed a search term:
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moves to the previous item in the results list
Activating the {nav Open Containing Folder} button for the first result via the keyboard changes slightly with this patch:
- Currently, it's {nav down arrow > tab key}
- With this patch, it's {nav tab key three times} or {nav down arrow > shift + tab}
Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11611
Summary:
The wallpaper loading code expects the catalogs to follow the pattern
"plasma_wallpaper_" + pluginid. While in config QML the domain needs
to be explicitly set using i18nd, as the default textdomain is set to
that of the config container, it is not needed in the wallpaper QML.
While using a catalog with plasma_applet_* prefix works if setting
the domain explicitly, the usage goes against the design of the
naming patterns. So to give a good example and also properly marking
the usage of the catalog, the names are switched.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10850
Summary:
Currently it always passes the top left corner of the SNI icon as coordinates,
but now it passes the actual click coordinates.
They can be outside of the icon's bounds (for instance if you click on the
label in the expanded tray), but they are converted to global coordinates
anyway.
Test Plan:
Now the context menu drawn by the application properly follows the
cursor.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11600
Summary:
The getLayout response handler compares the new list of actions with the
current actions in the menu and calls deleteLater on all actions which aren't
part of the new list anymore.
Then, it adds all actions from the new list which aren't part of the menu yet.
As deleteLater only has an effect after the next event processing, the menu
still contains them together with the added actions.
This resulted in broken size calculations, as even for static menus the item
count changed during aboutToShow.
Note that this is not a proper solution for the resize issue, as the
aboutToShow handler changes the menus content for a reason, the application
is free to add/remove items at any point in time.
Test Plan:
The context menu for SNI items in the system tray shows at the
correct position now. Only tested the wayland session.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11586
Summary:
Those had no transient parent set, so they got displayed somewhere, most of the
time on the wrong screen.
Test Plan:
Works fine for spotify and kteatime now, but certain applications
which trigger a LayoutChanged signal on the opened event have a Y offset.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11584
Summary:
dbus-launch --exit-with-session behaves badly if there's no X server running.
This resulted in it breaking when being launched from gdm or lightdm.
Also, the manpage explicitly states "This option is not recommended".
Test Plan:
Using it right now, started with sddm.
Also verified that nothing remains after logout.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11478
[cherry-picked from 19bee4105f which got
lost due to scripty conflicts]
Summary:
As discussed the env variables are no longer exported. Thus Qt
applications follow the default qpa platform they are compiled with and
thus still function if they are packaged with a Qt without QtWayland.
Plasma's internal processes pick the qpa platform depending on the
session type as well as our flatpak apps.
KRunner and Plasmashell are adjusted to not leak the env variable they
set for themselves.
Test Plan:
Started a wayland session, verified with KWin's debug console
that plasmashell and krunner are wayland. Launched kwrite from both plasma
and krunner and verified that it's xcb
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11447
Summary:
Appending an empty array of actions to QQmlListModel triggers an assert
in Qt when built in debug mode, see https://codereview.qt-project.org/#/c/223985/
for details.
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: davidedmundson, apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11519
Summary: use the new install macro which compresses packages in a bundled rcc
Test Plan: tried to load and use every single plasmoids
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11514
Summary:
Original decision didn't really have a rationale:
https://git.reviewboard.kde.org/r/125648/
It's causing bugs in people doing somewhat sensible things.
BUG: 380347
If widgets are locked, the script will still fail when it tries to do
something it can't.
Reviewers: #plasma, broulik
Subscribers: mart, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11375
Summary:
With commit 945a95d908b4544f7c5dea6caacffdc0f44cffcb SDDM will now support a custom default avatar in the next release. [[ 945a95d908 | Forgot the link. ]]
Before the patch:
{F5741458}
After tha patch:
{F5741459}
Note that the above is not quite the same as the logout screen thingy. But I am not sure how to make it render the image in a way that it does not quite touch the edge of the border.
To illustrate what I mean:
{F5741460}
With the logout screen the user icon is not touching the circle border.
Test Plan: Works for me
Reviewers: #plasma, #vdg, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11057
Always redirect to the ones in m_menu in case they get deleted or otherwise altered.
Also emit dataChanged when an action changes and reset the model when it gets deleted.
This fixes the menu getting confused in LibreOffice 6 with gmenu-dbusmenu-proxy.
CCBUG: 391868
Differential Revision: https://phabricator.kde.org/D11350
Summary:
dbus-launch --exit-with-session behaves badly if there's no X server running.
This resulted in it breaking when being launched from gdm or lightdm.
Also, the manpage explicitly states "This option is not recommended".
Test Plan:
Using it right now, started with sddm.
Also verified that nothing remains after logout.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11478
With removal of default Trash and D10684 users can add the Trash link back themselves.
The file name isn't neccessarily "Trash.desktop", though, so check all desktop files for that when trash state changes.
Differential Revision: https://phabricator.kde.org/D10686
Summary:
This is a preparation step to unset QT_QPA_PLATFORM from the wayland
startup session script. Setting QT_QPA_PLATFORM breaks 3rd-party Qt
software which does not bundle QtWayland. Most prominent example is
the Qt installer itself (see
https://bugreports.qt.io/browse/QTBUG-60222).
On the other hand our Plasma workspace applications need to be forced to
Wayland on a Wayland system. So we have a conflict between we want to
set QT_QPA_PLATFORM and we don't want to set QT_QPA_PLATFORM.
This change adds new API to KWorkspace to address this problem. The new
method adjusts the QT_QPA_PLATFORM based on the XDG_SESSION_TYPE
enviornment variable. It is completely opt-in. Meaning applications need
to explicitly add the call prior to creating the QGuiApplication and if
the user specifies either QT_QPA_PLATFORM env variable or any of the
-platform command line argument variants, the platform detection is
skipped.
The change also adjusts all plasma-workspace applications which should
use Wayland on Wayland to use the new API. The startup script on the
other hand still sets QT_QPA_PLATFORM. We also have applications outside
of plasma-workspace which needs this detection. Examples are:
* powerdevil
* systemsettings
* kinfocenter
Once this change is merged those applications can be adjusted by linking
against PW::KWorkspace and afterwards QT_QPA_PLATFORM can be unset from
startplasmacompositor.
Test Plan: See added autotest
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10816
When seeking isn't possible but the track duration is known, show a progress bar instead of showing nothing.
A progress bar is also much nicer than a disabled slider here as it's then meant as an indicator instead.
Differential Revision: https://phabricator.kde.org/D11356
With shared QML engine this would affect all applets and since we properly escape HTML in notifications now this is unneccessary.
Differential Revision: https://phabricator.kde.org/D11109
Summary:
TaskGroupingProxyModel used to return QVariant() as the
AbstractTasksModel::VirtualDesktop role for task groups,
resulting in TasksModel to sort task groups indiscrimi-
nately at the front of the list. In this patch, it instead
returns the lowest virtual desktop found among the children.
BUG:384747
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11257
Summary:
Adds a button in the plasmoid header to clear the history, same as the context menu.
The icon used is the same as clear history in the klipper plasmoid.
BUG: 386068
FIXED-IN: 5.13.0
Test Plan: Please test the alignment on your screen, whilst I made sure to use provided units, due to the indentation of heading I had to use fractions, which might lead to odd results on different resolutions / dpi
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11261
Summary:
Do not force geometry or window hints when opening systemmonitor
This should let it position properly on a multi-monitor setup and reduce interference with user-set KWin preferences
BUG: 368158
BUG: 356706
Reviewers: #plasma_workspaces, aacid, mart
Reviewed By: mart
Subscribers: davidedmundson, sebas, aacid, graesslin, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3484
Friedrich W. H. Kossebau
Kai Uwe Broulik
Nathaniel Graham
Fabian Vogt
Marco Martin
l10n daemon script
Martin Flöser
Daniel Vrátil
David Edmundson
Eike Hein
Christian (Fuchs) Loosli
Laurent Montel
Valeriy Malov