Test Plan:
Before:
- Drag&Drop an item from the middle column into the Favorite column at the position 2 (index =1) -> it is always added at the last position
After:
- Drag&Drop an item from the middle column into the Favorite column at the position 2 (index =1) -> it is added at the wanted position 2
Reviewers: ngraham, hein, #plasma
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19893
Summary:
removing favorites crashed, next() has to be called
before accessing the item
Test Plan: crash--
Reviewers: #plasma, hein, ivan
Reviewed By: #plasma, ivan
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10177
Summary:
removing favorites crashed, next() has to be called
before accessing the item
Test Plan: crash--
Reviewers: #plasma, hein, ivan
Reviewed By: #plasma, ivan
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10177
Summary:
KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
of the KAStatsFavouritesModel, like the name implies.
It is set in initForClient.
If the activity changes before we have a client ID, there's no point
doing anything and trying to use the clientID will crash.
BUG: 386439
Test Plan: None.
Reviewers: #plasma, hein
Reviewed By: #plasma, hein
Subscribers: anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8608
Summary:
And remove custom DEBUG macro with formatting.
If a dev wants a QT_MESSAGE_PATTERN they should set one themselves,
otherwise we get double formatting.
Test Plan: compiles
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8611
Summary:
tools.js is supposed to support both KaStatsFavoritesModel (used for
favorite applications) and SimpleFavoritesModel (used for system actions,
like poweroff/reboot/logout). The latter did not work though, as tools.js
unconditionally calls methods only present in KaStatsFavoritesModel.
This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel
and changes the relevant code in tools.js to support both.
Additionally, this syncs applets/kickoff/package/contents/code/tools.js again.
BUG: 385463
Test Plan:
Before this patch it wasn't possible to remove system actions from
the favorites bar.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, davidedmundson, rikmills, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8178
Summary:
The favourites are based on KAStats (already released version) **and kactivitymanagerd master (to be released with the next Plasma release)**. It allows favourites to be set to all activities, or the user can choose which activities to show a specific favourite application on.
This change covers applications, files and contacts, other favourites are still based on the old model (now named SimpleFavoritesModel).
{F1028047}
Test Plan:
Tested in Kicker, Dashboard and Kickoff the following:
Transitioning mechanism:
- load default favorites for the blank user
- load custom default favorites set in the plasmoidsetupscripts script for Kicker
- transition old results - when transitioning, merge the favourites from all launchers. The ordering for each launcher is kept separate (newly added items due to the merge go to the end)
Favorite manipulation:
- right-click add favorite to all activities
- right-click remove favorite from all activities
- right-click add favorite to specific activity (current)
- right-click remove favorite from specific activity (current)
- right-click add favorite to specific activity (not current)
- right-click remove favorite from specific activity (not current)
- right-click move from all to specific
- right-click move from specific to all
- right-click move from one activity to another
- dnd reorder items in the model (up)
- dnd reorder items in the model (down)
- dnd add to favorites at a specific position
Other:
- launch the application
- ordering persists after restart
- ordering from the previous is kept on the activity that has no ordering
Reviewers: mart, hein
Reviewed By: hein
Subscribers: Zren, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3805
Bhushan Shah
Laurent Montel
Tranter Madi
Kevin Funk
Marco Martin
David Edmundson
Fabian Vogt
Ivan Čukić