Test Plan:
Before, no clocks: {F8246116}
After, no clocks: {F8246114}
[Now the vertical spacing between labels matches other tooltips]
Before, some clocks: {F8246113}
After, some clocks: {F8246115}
[Now the full date is displayed on the first line instead of being split across two]
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28970
Summary:
To increase consistency and reduce redundancy, widget tooltip icons are being removed
in D27847 and D27848, per discussion in T12778. This patch makes the Digital Clock
consistent what that initiative, since it has a custom tooltip.
Test Plan:
{F8150016}
{F8150021}
Reviewers: #vdg, #plasma, niccolove
Reviewed By: niccolove
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T12778
Differential Revision: https://phabricator.kde.org/D27849
Summary:
I noticed that on the first time I bring up the calendar by clicking the clock on my Plasma panel, it always shows "No event for today". If I click another day on the calendar and then click back on today, it shows today's events fine. It should display it correctly the first time.
To fix this bug, we need to compare the date without time.
BUG: 395956
FIXED-IN: 5.19.0
Reviewers: ngraham, #plasma, vkrause
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28354
Summary:
This patch fixes several errors in the code:
- The property is named `font.minimumPixelSize`, not `minimumPixelSize`
- The calculation in `minimumPixelSize` did not make sense
- Setting the height to `dateLabel.paintedHeight` is nonsensical
BUG: 417852
FIXED-IN: 5.18.4
Test Plan: {F8186873}
Reviewers: #vdg, #plasma, cblack, davidedmundson
Reviewed By: #vdg, #plasma, cblack, davidedmundson
Subscribers: davidedmundson, cblack, muesli, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28172
Summary:
The Pin buttons in the System Tray and Clock pop-ups are very small. This has
always felt slightly odd to me, and the recent change to add a defined header
area for the System Tray pop-up makes it even odder in my opinion, as the icon
is now much smaller than the area it visibly inhabits. This patch makes both icons
in both applets use the standard size with no local overrides. The clock pop-up's
pin button is ported to PC3 in the process.
Depends on D28228
Test Plan:
Before: {F8194101}
After: {F8194100}
Reviewers: #vdg, #plasma, ognarb, mart
Reviewed By: #vdg, #plasma, ognarb, mart
Subscribers: mart, ndavis, broulik, ognarb, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D28211
Summary:
This patch allows you to switch the timezone by clicking on your desired one in the
applet's expanded representation. This is much simpler than the mouse-wheel-based UI and
does not need a config setting to turn it on or off.
Test Plan: {F8183863}
Reviewers: #vdg, #plasma, jriddell, cblack
Reviewed By: #vdg, #plasma, cblack
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T9222
Differential Revision: https://phabricator.kde.org/D28133
Summary:
Various people were complaining that the calendar was too squished after D27903. This
patch restores its size to be closer to the old version. As a consequence, the whole
expanded representation is quite large now, but there really is no other way.
Test Plan:
Before: {F8181551}
After: {F8181550}
Reviewers: #vdg, broulik, mart, cblack
Reviewed By: #vdg, cblack
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28104
Summary:
Right now time zones are only shown in the tooltip, which is annoying since the tooltip
times out aftew a few seconds, so it often closes before I can find the timezone I'm
looking for.
This patch adds a view for the current tomezones in the expanded representation, and
implements a mockup in https://bugs.kde.org/show_bug.cgi?id=395655 showing a proposal
for how to present this information.
The Expanded Representation is also ported to Layouts in order to make this task easier.
FEATURE: 395655
FIXED-IN: 5.19.0
Test Plan:
Just calendar: {F8157434}
Calendar + events: {F8157435}
Calendar + time zones: {F8157436}
Calendar + events + time zones: {F8157437}
Reviewers: #vdg, #plasma, cblack
Reviewed By: #vdg, cblack
Subscribers: cblack, apol, plasma-devel
Tags: #plasma
Maniphest Tasks: T9222
Differential Revision: https://phabricator.kde.org/D27903
Summary: The clock was too close to the panel right edge when displaying hours beginning with 10, 11 and 12. Weirdly enough, the right margin was different based on the clock current time. This patch makes the margin constantly equal to the one that there was before when displaying 10,11,12 plus units.smallSpacing.
Reviewers: #vdg, #plasma, davidedmundson, ngraham
Reviewed By: #vdg, #plasma, davidedmundson, ngraham
Subscribers: gvgeo, davidedmundson, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27737
Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27304
Summary:
BUG: 381551
FIXED-IN: 5.18.0
Test Plan:
Before: {F7851382, size=full}
After: {F7851383, size=full}
Texted extensively because this code is so brittle. No regressions with long date in a
thick or normal-sized horizontal panel or short date in a thick or normal-sized
horizontal or vertical panel.
The one issue I could find is that sometimes switching between short and long date
formats in a double-thickness vertical panel causes the long date to be truncated again
until plasmashell is restarted. I was unable to determine why. Assistance would be
appreciated if this is a blocker.
Reviewers: #plasma, #vdg, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26312
Summary:
System tray dialog/popup can be tiled. This should not be allowed, in this case expanded representaiton should have fixed size. When tiled, it is no longer possible to restore original size.
This also applies to other plasmoids.
BUG: 386551
FIXED-IN: 5.18.0
Test Plan:
1. Open any applet from system tray (for example Clipboard or hidden items)
2. Use shortcut to tile window (by default Meta + Left/Righ/...)
3. Applet will change size and tile at the borded of the screen
4. Expected:
a) before fix: allowed and not possible to restore size
b) after fix: not allowed or restores size on next open
Reviewers: #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26545
Summary:
support the automatic shadow hint
When the hint is shadowedBackground, do an automatic shadow with a shader, and
change applet's color to complementary
Test Plan:
Tested the functionality on various applets. To test, the digital clock is enabling explicitly background configurability
{F7788553}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25591
Summary: Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use `i18ncp` because the number isn't integer.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25319
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Especially for the custom one it's useful to have a live preview rather than trial and error with the Apply button.
Differential Revision: https://phabricator.kde.org/D25091
Summary:
Fixed issue when time zone configuration page was not scaling corrently. As a result two
srollbars were rendered.
Fixed few QML layout warnings and undefined references.
Test Plan:
Open Time zones configuration page and shrink window - two scrollbars are rendered.
Expected: table is scalled correctly and only one scrollbar in table is rendered.
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24853
Summary:
If this entry is not added, kpackagetool5 tries to load the specific
packagestructure plugin, fails to load it and then writes the metainfo
as it is "application" instead of add-on
Reviewers: apol, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21991
Summary:
Changes the height of the date string to match that of the
time string so the date is readable with a vertical panel
BUG: 404611
Reviewers: #vdg, #plasma, davidedmundson, Zren, ngraham, rooty
Reviewed By: #vdg, ngraham, rooty
Subscribers: rooty, cfeck, mart, ngraham, davidedmundson, Zren, abetts, anthonyfieroni, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19194
Summary:
The use of a tri-state checkbox for the three possible states (12hr, 24hr, use locale
default) is not ideal because it violates the convention regarding what tri-state
checkboxes are used for: nested lists where some sub-items can be unselected.
This patch replaces it with a combobox that clearly indicates all three states.
While we're at it, we add a button to open the Formats KCM in case people want to change their region.
BUG: 402487
FIXED-IN: 5.16.0
Test Plan:
Tested functionality with `en_US` locale. Check out the clock in the bottom-right corner of
the following screenshots:
Default state: "Use Region Defaults": {F6645570}
Force 12 hour time: {F6645573}
Force 24-hour time: {F6645574}
Reviewers: #plasma, Zren, #vdg, davidedmundson, ndavis
Reviewed By: #plasma, #vdg, davidedmundson, ndavis
Subscribers: cfeck, totte, ndavis, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19230
In 12h system locales (eg: en_US), checked=1 is cast as
Qt::PartiallyChecked=1 which defaults to the system locale (12h).
Since it's no longer a tri-state button, the user can't select
Qt::Checked=2 which forces the 24h state.
BUG: 404292
FIXED-IN: 5.15.1
Nate Graham
Eugene Popov
Ahmad Samir
l10n daemon script
Niccol Venerandi
Heiko Becker
Marco Martin
Konrad Materka
Yuri Chornoivan
Guo Yunhe
Kai Uwe Broulik
Laurent Montel
Bhushan Shah
Antny Zilla
Chris Holland