The code already checks if the object to add to the container hasn't been
added before, no need for the QSet overhead; (unless the alphabetical order
if required, but I see nothing to support this theory).
If a QAction is destroyed, KGlobalAccel will automaticaly set it
to inactive. To prevent this put them on the heap and intentionally
leak them as it did before.
CCBUG:437364
Those were messed up in the clang-format reformatting, but there weren't
any complaints about the template not working.
Also the dataenines are about to be deprecated and still need a
replacement. Consequently we should not encourage users to write
third-party dataengines.
If there's no texture factory function, return the old node immediately.
Also, remove a guard against the code that calculates centered geometry
of the texture node. We cannot hit that case as we check whether the
factory function has returned a valid texture before that.
It's possible for the root volume to be on a removable disk. In this
case, don't offer the user the option to eject that disk as it does not
make sense and will fail.
This reverts part of a8ec95411a, KCModuleLoader can't load kcm_fontinst
if the library is installed in KDE_INSTALL_PLUGINDIR/kcms/; looks like that
only works for KCMs using QML.
BUG: 436306
FIXED-IN: 5.22.0
the desktop style forces a bit of padding onto the indicator which
combined with implicit small sizing in a layout means the indicator
comes out waaaaaay too small as half the available space is padding.
disable padding entirely, we don't really need it here
this caused an unnecessary warning. when the list is empty the join
results in "" which is considered invalid for the reference of %2
leading to ki18n warning that not enough arguments were supplied. simply
return an empty string when the message is not visible
the recycler did not really serve a purpose here. the delegates are
fairly cheap and there's a very finite amount of them and the amount
isn't going to be in the thousands either
it did however cause spurious warnings because there is a space of time
where model and index isn't available to the delegate and so trying to
get a role out of the model would cause warnings because model is null
initially.
removing the recycler gets rid of the warnings.
I've also changed parent.width to refer to the view explicitly as parent
isn't necessarily defined right out the gate causing excess warnings.
this is also typically what we do in other places.
We got some reports that the update did not work correctly.
The kconf update daemon watches for new files so we should
rename the file in addition to changing the IP.
Instead listen to KNS signals and only update the parts that are needed.
The signals from the qtquickengine also produce less unwanted noise
because the signal does not get emitted for intermediate states.
This also prevents the scrolling position from scrolling unnecessarily
to the top.
Instead listen to KNS signals and only update the parts that are needed.
The signals from the qtquickengine also produce less unwanted noise
because the signal does not get emitted for intermediate states.
This also prevents the scrolling position from scrolling unnecessarily
to the top.
To be consistent with what we generally do in other places, use the
trashcan icon for the remove button, and only show it when the list has
more than one item in it.
BUG: 437567
BUG: 437566
FIXED-IN: 5.22
This commit implements what was agreed upon in
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/690, but
does it correctly by simply disabling the menu item by default, not
removing it entirely. This ensures that the change is only made for new
installs. Existing users' configs will not be touched (because all
values are serialized to the config file already), and any new users
will be able to re-enable this item if they like it.
CCBUG: 437747
Ahmad Samir
Aleix Pol
l10n daemon script
David Redondo
Nicolas Fella
Alexander Lohnau
Vlad Zahorodnii
Kai Uwe Broulik
Benjamin Port
Nate Graham
Harald Sitter
Shubham Shubham
Ayushmaan jangid