In most cases the port is trivial and can even simplify the code like in
the case of the system tray applet. In the case of notifications applet,
this is causing a bigger refactor and it's now also using a TextArea
that provides the automatic scrolling when selecting behavior.
CCBUG: 437155
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.
Here was my full process for making this change:
1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+ " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
Instead of adding an unprintable character to the UI the history view is
closed and the text field it focused.
To prevent unprintable characters like backspace a regex is used,
just like we already do in the ResultsView Keys.onPressed slot.
BUG: 433723
FIXED-IN: 5.21.2
Qt 5.15 introduced new syntax for defining Connections. Fix warnings like this one:
QML Connections: Implicitly defined onFoo properties in Connections are deprecated. Use this syntax instead: function onFoo(<arguments>) { ... }
Simplifies the logic of the busy indicator since now it will already
fade out when it's not running.
Also addresses the logic of the timer which was off.
This made krunner freak out on Wayland for some reason to investigate,
both opacity animations were triggering a repaint and we tried to render
too often making the process block. With this change it works fine
again.
This begins the process of porting plasma-workspace to PlasmaComponents3. At
this point, only the relatively easy work is done. Every file not ported
now has been given the reason for still using PC2 in a comment on the import
line so you can see at a glance what the blocker is by running
`grep -r "org.kde.plasma.components 2.0"` in the repo.
Everything is tested and there are no breakages or functional regressions. In
the process, a few unused imports are removed.
Here are the remaining PC3 omissions blocking what's left from getting easily
ported:
- No Highlight
- No ListItem
- No PageStack
- No ContextMenu
- No QueryDialog
- No ModelContextMenu
- TabBar has no left and right tab states
- ToolButton has no built-in method to show a menu when clicked
Summary:
Shows a busy indicator in the TextField.
Depends D22723.
BUG: 409959
Test Plan: Searched things, eventually it disappears, I sometimes don't really know what's still doing, maybe we could add some more information at some point.
Reviewers: #plasma, #vdg, broulik
Reviewed By: #plasma, #vdg, broulik
Subscribers: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22514
Summary:
We are currentlly very inconsistent how we refer to KRunner, impairing comprehensibility
among both expert users (who know it as "KRunner") and novice users (for whom "Run
Command" has a literal and somewhat scary meaning).
This patch is a part of {T10966} and standardizes on "Show KRunner", helping to turn
KRunner into a user-visible brand name like Apple's Spotlight.
Test Plan:
{F6842497}
{F6842498}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Maniphest Tasks: T10966
Differential Revision: https://phabricator.kde.org/D21341
Summary:
Shows tooltips for buttons left and right of the search box.
FEATURE: 398943
{F6284809}
Test Plan: Manually test appearance of tooltips, unlikely to cause new issues.
Reviewers: #vdg, acrouthamel, ngraham
Reviewed By: #vdg, acrouthamel, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15749
Summary:
This change allows users to scroll through krunner output using their homerow.
- Ctrl+j: Scroll Down
- Ctrl+k: Scroll Up
This makes scrolling easier for those familiar with this convention but doesn't inhibit users who aren't.
Reviewers: broulik, #plasma_workspaces, davidedmundson
Reviewed By: #plasma_workspaces, davidedmundson
Subscribers: davidedmundson, #plasma_workspaces, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13686
Summary:
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.
BUG: 392197
Test Plan:
Deployed change, killed, restarted, and activated KRunner, typed a search term:
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moves to the previous item in the results list
Activating the {nav Open Containing Folder} button for the first result via the keyboard changes slightly with this patch:
- Currently, it's {nav down arrow > tab key}
- With this patch, it's {nav tab key three times} or {nav down arrow > shift + tab}
Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11611
Indicates that there's a "drop down" history similar to a ComboBox.
The fact that you can press the down arrow to bring it up is hardly discoverable.
BUG: 375207
FIXED-IN: 5.13.0
Differential Revision: https://phabricator.kde.org/D10652
Summary:
enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)
Test Plan:
tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: gladhorn, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7765
Jacopo De Simoi
Alexander Lohnau
Fushan Wen
Janet Blackquill
Nate Graham
Arjen Hiemstra
Carl Schwan
Felipe Kinoshita
Kai Uwe Broulik
Konrad Materka
Aleix Pol
Laurent Montel
Silas Lenz
Michael Eden
Marco Martin