Fushan Wen
470dcc511b
shell: use `std::copy_if` in `ShellCorona::panelsForScreen`
...
Consider using std::accumulate algorithm instead of a raw loop. (CWE-398)
in shell/shellcorona.cpp:1148
4 years ago
Fushan Wen
6f96fab365
Use `std::accumulate` in `ShellCorona::_availableScreenRegion`
...
Consider using std::accumulate algorithm instead of a raw loop. (CWE-398) in shell/shellcorona.cpp:1051
4 years ago
l10n daemon script
bd7f3bcc1b
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
4 years ago
Luca Carlon
ace8a4a351
Make widget popups resizable
...
See the discussion in https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/500 .
BUG: 411462
BUG: 332512
4 years ago
Jonathan Marten
012cfbbc0f
Klipper: Avoid a crash on exit with the legacy application
...
Caused by the context menu and the associated widget being set to the
same object, leading to an access after destruction.
Application: Klipper (klipper), signal: Segmentation fault
Content of s_kcrashErrorMessage: std::unique_ptr<char []> = {get() = 0x0}
#8 QObject::disconnect (member=0x0, ...)
#9 KStatusNotifierItem::~KStatusNotifierItem () at knotifications/src/kstatusnotifieritem.cpp:71
#10 KlipperTray::~KlipperTray () at plasma-workspace/klipper/tray.h:13
4 years ago
Jonathan Marten
0c39b51de9
Klipper config: Allow KConfigDialog to manage the GUI
...
So that the "Apply" and "Defaults" buttons work properly.
Mostly this involves just setting appropriate object names
for the GUI controls, with some special handling for the
radio button sets.
4 years ago
Jonathan Marten
9544906055
Klipper: More explicit wording for the "Clear History" confirmation
...
I18N:
4 years ago
Fushan Wen
36cbf57881
wallpapers/image: enable `reuseItems` in wallpaper `GridView`
...
This makes the scrolling smoother when there are many wallpapers in the
view.
4 years ago
David Edmundson
74a80aaac7
Lock screen: Avoid wiping password field when getting our first prompt
...
When the lockscreen is in the screensaver mode we want the keyboard key
pressed to wake the screen to go to the password box textfield. This did
work correctly, but a code path also reset it when we get the first
prompt.
In the (currently hypothetical) case of multiple prompts we would want
to clear anything in the prompt.
This uses the existing boolean flag to handle that appropriately.
BUG: 454108
4 years ago
Kai Uwe Broulik
f045cf306c
[System Tray] Emit pressed signal on compact representation in popup, too
...
Some actions, such as middle click to mute, trigger only on press. Some applets
also need a pressed-click because of some legacy autoclose on focus change
bug.
Unfortunately, QML does not disambiguate the "pressed" property and "pressed(mouse)"
signal with argument, so this has to be done awkwardly through QMetaObject on C++ side.
BUG: 426646
BUG: 452893
FIXED-IN: 5.25.0
4 years ago
Eugene Popov
853c29bf7d
[startplasma] Wait for the killed process to finish
...
Because we need all processes to be killed before startplasma exits.
BUG: 454173
4 years ago
l10n daemon script
dae0a5df5e
SVN_SILENT made messages (.desktop file) - always resolve ours
...
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
4 years ago
Ismael Asensio
b24b049cdf
kcms/colors: Fix un-setting accent color from wallpaper
...
Fix changes in 6e7a147e3 , where the property `accentColorFromWallpaper`
would get set but not un-set from the UI.
4 years ago
Volker Krause
09a5a7706e
Combine flags with the | operator
...
The + one is deprecated in Qt6.
4 years ago
Volker Krause
0cb48a1e96
Explicitly create QFileInfo from QString
...
Qt6 doesn't allows this implicitly anymore.
4 years ago
Volker Krause
74614801ae
Add various missing includes and link libraries
...
Those are no longer pulled in indirectly with KF deprecation level 5.94.
4 years ago
Alex Richardson
de45732b8d
libtaskmanager: Fix invalid dataChanged() signal emission
...
Calling dataChanged() with an invalid QModelIndex() triggered an assertion
inside QConcatenateTablesProxyModel (my Qt is built with assertions):
ASSERT: "from.isValid()" in file $HOME/cheri/qt5/qtbase/src/corelib/itemmodels/qconcatenatetablesproxymodel.cpp, line 623
4 years ago
Felipe Kinoshita
7f308065a7
applets/batterymonitor: make string translatable
...
This commit makes the string "No Batteries Available" translatable.
BUG: 454114
4 years ago
Alexander Lohnau
90d36545ea
Revert "[kcms/cursor] Port to required properties"
...
We can not use the required properties, because it breaks the property binding.
ec79af7396 apparently fixes that, however
it is not released as part of Qt6 or is part of the KDE patch collection.
This reverts commit f3293bc59e .
BUG: 453226
4 years ago
Fushan Wen
97a9a98ec5
wallpapers/image: Use QStringLiteral
4 years ago
Fushan Wen
f921af3e4e
wallpapers/image: Register KFileItem in registerTypes()
4 years ago
Fushan Wen
b23fa2d92d
wallpapers/image: Remove BackgroundListModel
4 years ago
Fushan Wen
451a6a0733
wallpapaers/image: Add autotests for ImageBackend
...
Use Qt Quick Test to test the backend can provide correct model images.
4 years ago
Fushan Wen
4e83485718
wallpapers/image: Adapt to model changes in ImageBackend and QML frontend
4 years ago
Fushan Wen
d63cf4a76b
wallpapers/image: Add autotests for SlideFilterModel
4 years ago
Fushan Wen
5a607c33b2
wallpapers/image: Add roleNames() in SlideFilterModel
4 years ago
Fushan Wen
cca481b79a
wallpapers/image: Add custom image provider for KPackage wallpapers
...
The url format is image://package/get?dir=<DIR>
DIR is package path.
4 years ago
Fushan Wen
3153540284
wallpapers/image: Add autotest for SlideModel
4 years ago
Fushan Wen
9fab17a67d
wallpapers/image: Rewrite SlideModel based on QConcatenateTablesProxyModel
...
SlideModel is inherited from QConcatenateTablesProxyModel, and its
source model is ImageProxyModel. Each folder will create its
corresponding ImageProxyModel.
4 years ago
Fushan Wen
b1b841a28c
wallpapers/image: Move openContainingFolder to SlideFilterModel
4 years ago
Fushan Wen
59188cf191
wallpapers/image: Add autotest for ImageProxyModel
4 years ago
Fushan Wen
f96b82b122
wallpapers/image: Add ImageProxyModel
...
A proxy model that aggregates data from ImageListModel and PackageListModel.
4 years ago
Fushan Wen
61de99dd64
wallpapers/image: Add autotest for PackageListModel
4 years ago
Fushan Wen
0d68f88850
wallpapers/image: Add PackageListModel
...
List KPackage wallpapers, usually in a folder.
4 years ago
Fushan Wen
c247589f4e
wallpapers/image: Add autotest for ImageListModel
4 years ago
Fushan Wen
d4a1c07a81
wallpapers/image: Add ImageListModel
...
List images that do not belong to any KPackages.
4 years ago
Fushan Wen
78df214f6c
wallpapers/image: Add AbstractImageListModel class
...
This serves as the base class for image list models.
4 years ago
Fushan Wen
9a473c8240
wallpapers/image: Remove testfindpreferredimage
...
It's moved to PackageFinderTest.
4 years ago
Fushan Wen
5ce62bd74c
wallpapers/image: Add autotest for PackageFinder
...
Test PackageFinder can find packages and choose a correct size.
4 years ago
Fushan Wen
523ed1e053
wallpapers/image: Add PackageFinder
...
Find KPackage wallpapers.
4 years ago
Fushan Wen
d0a580c539
wallpapers/image: Add autotest for ImageFinder
...
Test ImageFinder can find images.
4 years ago
Fushan Wen
bf006a4866
wallpapers/image: Add ImageFinder to find images
...
A runnable that finds all available images in the specified paths.
4 years ago
Fushan Wen
a1b63b685f
wallpapers/image: Add findSymlinkTarget()
...
This helps find the real file path.
4 years ago
Fushan Wen
ce6dbf90b9
wallpapers/image: Move distance and resSize to distance.cpp
4 years ago
Fushan Wen
8324f1188b
wallpapers/image: Move suffix check to suffixcheck.cpp
...
Will be used in finders.
4 years ago
Fushan Wen
ad0578e71e
wallpapers/image: Add autotest for ImageSizeFinder
...
Test the finder can return a correct image dimension.
4 years ago
Fushan Wen
5ac9042989
wallpapers/image: Move ImageSizeFinder to finder/imagesizefinder.cpp
...
Don't crowd the code in backgroundlistmodel.cpp
4 years ago
Fushan Wen
41697f9a1c
wallpapers/image: Add static library for autotests
4 years ago
Fushan Wen
13a6e77276
calendar: move translation domain from libplasma5 to plasmashellprivateplugin
...
The calendar component is in plasmashellprivateplugin now.
4 years ago
Fushan Wen
125c0ae189
GIT_SILENT libicu: move find_package to root CMakeLists.txt
4 years ago