The test should make sure the chrome bookmarks and profile reading
works properly and not test the conversion logic.
In the previous commit a dedicated test has been added
for the conversion and relevance logic.
This matches the install location scheme QT_PLUGIN_DIR/kcms/, which makes
it slightly easier to test stuff right from the builddir, without
installation, by exporting QT_PLUGIN_DIR=builddir/bin/.
Also install kcm_fontinst in QT_PLUGIN_DIR/kcms/, like the other KCMs.
If some elements in .fonts.conf were deleted (default), they weren't updated anymore, and cause inconsistency between the value displayed in the KCM and what is actually applied.
UI consistency : when the user uncheck enable AA, then the style is set to None instead of default value.
CCBUG: 416140
By lacking this, the global theme falls back to the default value.
However that default can be overridden by a distro. Let's always specify
the Breeze splash screen.
The KWin setting for whether or not to wrap around was not respected, so
wrap was always true even if the user has turned it off. This commit
fixes that.
BUG: 425787
The wallpaper infrastructure sutures multiple form layouts.
The image wallpaper adds its own Positioning combobox, but the combobox's width does not match that of the two comboboxes right above it.
This patch makes the Positioning combobox as wide as the other two by resuing code already present in ConfigurationContainmentAppearance.qml.
This allows a client to mark a notification as "resident" which means it will
not be closed by the sever when expired or an action is invoked, thus transferring
full control over notification life time to the client.
A notification popup still times out as normal (unless persistent, of course)
but the notification remains alive until the client revokes it or a user
explicitly closes it.
It is opt-in so that a client can expect the notification lifetime to be
indefinite and explicitly close it when an action is invoked on its end.
Making it a library instead of including the source from multiple places
has several advantages. We get proper dependency and include path
propagation. We can specify the krdb dependencies once instead of
repeating them for each kcm. This allows for a better separation between
the KCM's actual dependencies and krdb's dependencies.
Doing so causes some trouble for our translators since %1% is marked as
"this is a java printf" and then they can't translate it properly since
well, this is not really a java printf
For example, show "Open with Gwenview" with its icon after downloading
an image file, and "Open with..." in case there is no associated application.
While at it also give an icon to the "Open Containing Folder" button.
Also, port it to use a `KIO::mimetypeJob` to make it asynchronous
and work on remote locations. To make for a less jarring transition (icon suddenly
appearing, causing text reflow and the dialog to resize), take an initial
guess about the mimetype using the file extension while the job is running.
Furthermore, hide the "Open" actions in case the job fails which likely means
the file doesn't exist anymore or cannot be accessed, and as as result
probably cannot be opened anyway.
Lock screen avatar is blurry when using HiDPI scaling. This fixes that
by adding a multiplication factor to the size of the retrieved image.
CCBUG: 418546
Qt uses NewMenu signal to notify when new context menu is set.
It is not part of the official standard but already used by Qt
(starting from Qt 5.11).
BUG: 383202
FIXED-IN: 5.22.0
System Tray forgets Dropbox hidden state after logout+login
The SNI Id should be consistent between sessions, but Dropbox does not
follow the SNI specification - it adds PID as a suffix of Id.
As this is very popular application and it was not fixed upstream for
many years it is reasonable to add workaround in SystemTray.
BUG: 378910
FIXED-IN: 5.22.0
People are using this feature to work around Wayland's terrible
fractional scaling implementation that makes everything super blurry. I
can't in good conscience tell them to use it anyway because it really
does look so bad. :( See https://bugs.kde.org/show_bug.cgi?id=433269.
This reverts commit 65defddee95db6738d5e2c80f6c7b373fde451a1
This reverts commit 40afa58ab9bf0d0808edb891f9cd855316a82411
BUG: 433115
FIXED-IN: 5.21.2
In the past, this was considered to be a way to make KRunner more
discoverable by users.
However today Kickoff exposes all the same runners as KRunner, so its
full functionality is therefore more discoverable in a different way,
so making the KRunner UI itelf more discoverable is not as important.
Furthermore, this was always a questionable way to increase
discoverability in the first place, because the menu item did not expose
the keyboard shortcut, which is the typical way that people show
KRunner. Also, context menus are generally considered shortcuts for
experts; novice users don't tend to use context menus very much. But
experts are the people more likely to already know about KRunner and its
keyboard shortcut, and would never invoke it using the desktop context
menu.
Removing this menu item de-clutters the desktop context menu a bit, and
we do get complaints that the menu is overwhelming because it has too
many things in it. This is a fairly unimportant item that we can remove
without any real consequences.
Finally, Marco didn't like the change to refer to KRunner using the
actual term "KRunner" in the main UI, so this change removes one of the
two places where that happened. :)
The context property version is slower to access and won't be supported
in Qt6. Let's port away from it and use the singleton version instead.
Here was my full process for making this change:
1. Made the change with `find . -name '*.qml' | xargs perl -pi -e 's/units\./PlasmaCore\.Units\./g'`
2. Verified no more occurrences with `grep -r " units."`
3. Made sure this didn't change any comments in a silly way by inspecting the output of `git diff | grep "+ " | grep "//"`
4. Manually inspected the full git diff to make sure there were no other unintentional or silly changes (there were none)
5. verified that all changed files have the PlasmaCore import with the correct name with `for FILE in `git status | grep modified | cut -d ":" -f 3`; do grep -q "as PlasmaCore" $FILE || echo "$FILE needs the PlasmaCore import"; done`
consider an applet acceptable for the formfactor if at least one
of its formfactors are contained in KDeclarative::runtimePlatform
or if either KDeclarative::runtimePlatform or applet formfactors
are empty.
(before informFactor failed if even one of the applet supported
formfactors was not in runtimePlatform
BUG:433983
After getting the Icons KCM set up using an ActionToolbar for the row of
buttons at the bottom of the KCM, it seemed like a good idea to adapt
that method for more of the KCMs. This is the first of those patches,
and it adapts the Colors, Cursor Theme, Desktop Theme, Global Theme, and
Style KCMs to using an ActionToolbar (and consequently allowing them to
scale their UI more correctly).
ListUnitByNames did not quite work as the author (me) expected. Whilst a
search for "adsfasf" yeilded an empty list a well-formed name like
"asdfasdf.service" would return a result to say that service was not
loaded.
This means our runtime detection of xdg-autostart-generator failed.
By using ListUnitFilesByPatterns we can filter on the status in the
query, meaning this code works again. We also can query the case of it
being available but explicitly disabled.
BUG: 433333
It was broken because its visiblity was not bound to activeFocus
correctly. This would have broken in Qt6 anyway but fixing it now makes
the focus effect work as intended again.
BUG: 433755
FIXED-IN: 5.22.3
This is a workaround for the page being totally broken on when opened
again after the dialog was closed for the first time. Using a new controller
works around that.
BUG:424458
Instead of adding an unprintable character to the UI the history view is
closed and the text field it focused.
To prevent unprintable characters like backspace a regex is used,
just like we already do in the ResultsView Keys.onPressed slot.
BUG: 433723
FIXED-IN: 5.21.2
forward containmentDisplayHints from panel to the systray, adding the
systray specific ones which are
Plasma::Types::ContainmentDrawsPlasmoidHeading and
Plasma::Types::ContainmentForcesSquarePlasmoids
Alexander Lohnau
Ahmad Samir
Cyril Rossi
l10n daemon script
Nate Graham
Filip Fila
Kai Uwe Broulik
Nicolas Fella
Albert Astals Cid
Konrad Materka
Chandradeep Dey
Fabio Bas
Marco Martin
Fabian Vogt
Dan Leinir Turthra Jensen
David Redondo
David Edmundson