QtScript is deprecated and at least in this place it's a straight-forward port.
The Qalculate code path also doesn't need it, so remove it from CMake there.
Differential Revision: https://phabricator.kde.org/D4472
I don't know how this ever worked but I recall it showing correct results but it only
showed the applet id which makes no sense to show to the user
Differential Revision: https://phabricator.kde.org/D3960
Summary:
- make sure that chrome apps have lower relevance than chrome itself
- makes sure that konsole has higher relevance than yakuake (latter
only references onsole in the comment entry)
Test Plan:
- it passes and at a glance doesn't seem to break my production sycoca
Would be cool if @dfaure could take a look at the ksycoca setup to make sure the test doesn't negatively impact the production cache.
Reviewers: broulik, dfaure
Reviewed By: dfaure
Subscribers: dfaure, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3707
Previously, they were created on-demand, which was the wrong approach, I think.
Kicker checks for actions() being available before it even bothers getting actions for a match.
CHANGELOG: KRunner actions like "Open containing folder" and "Run in Terminal" will now show up in the application launchers as well
Differential Revision: https://phabricator.kde.org/D3688
disqualify() checks whether the service ought to be disqualified (i.e.
not processed) and then marks it seen. this allows us to boilerplate
call disqualify(service) whenever iterating services to decide whether
the service in question should be skipped.
also means we don't have to call noDisplay once a service is disqualified
reviewed by kbroulik on irc
Summary:
KService::noDisplay() includes qualification for
- NoDisplay entry itself
- OnlyShowIn and NotShowIn
- X-KDE-OnlyShowOnQtPlatforms
- authorization WRT KCMs
as such checking nodisplay is good enough to disqualify services in all
relevant scenarios
Test Plan: - read the code of noDisplay()
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3705
Summary:
refactor and qcdebug
::match was a super long spagetthi with multiple sub-matches.
This was supposedly primarily because it needed to be stateful across all sub-matches. To deal with this there's a new class which is taking care of the stateful service finding, this class is comprised of multiple matching functions that contribute to the full match set.
Good enough readability for now. Classes for this would be nicer though.
Also add qcdebug for this runner so we can get a better idea of why results are the way they are. Defaults to warning so it's silent by default.
Test Plan:
Careful refactoring so hopefully no problems.
- still matches binary names as best match
- still matches comments
- still matches generic names
- still matches names
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3687
Regardless of the current state of Baloo, it is not very deeply tied
into Plasma. Usage in plasma-workspace comes down to providing the
baloo runner. This makes it possible to prepare systems without a use
for indexing.
https://mail.kde.org/pipermail/kde-frameworks-devel/2016-September/037734.html
REVIEW: 128956
Summary: We won't have any results anyway.
Test Plan:
Disabled indexing and put a qDebug in the if branch
I'm not super convinced it's a good idea myself. It means parsing a config file every match
and it can't be cached without missing updates if the user enables/disables at runtime.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2995
Summary: Include is unused, and kdesu should die regardless
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2681
Kickoff traditionally prefers showing the application comment (ie. "File Manager", "Web Browser", etc)
over the actual application name. This allows to find applications this way.
Differential Revision: https://phabricator.kde.org/D2204
Kai Uwe Broulik
l10n daemon script
Harald Sitter
David Edmundson
Aleix Pol
Andreas Sturmlechner
Bhushan Shah
David Faure