Summary:
The copying/updating of the cache has been removed from the FetchSqlite class.
This allows the browsers to have handle the caching differently.
The firefox sqlite files are only copied if they changed. Before they were copied
for each match session.
The chrome favicon database is also only copied if needed
and the check is also made in the prepare method and not just when
the profile is initialized.
Test Plan:
For both firefox and chrome:
Plugin shows icons for results.
Add new bookmarks, close browser, the new bookmarks should show up with icons.
Reviewers: #plasma, ngraham, meven, broulik
Reviewed By: meven
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29726
Summary:
Before: A pointer to the favicon gets written in the BookmarkMatch and using this pointer the icon gets created when the Plasma::QueryMatch gets created.
Now: Using the favicon pointer the icon gets created and written to the BookmarkMatch, when the QueryMatch is created the icon value is read.
This makes the code easier to understand and the BookmarkMatch is independent of the Favicon class.
Test Plan: Should compile and display icons.
Reviewers: apol, broulik, davidedmundson
Reviewed By: davidedmundson
Subscribers: bruns, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28439
Instead of converting to QVariantMap first.
Also, port code touched as part of this to range for
Differential Revision: https://phabricator.kde.org/D17527
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Alexander Lohnau
Méven Car
Laurent Montel
Kai Uwe Broulik
Yuri Chornoivan
Aleix Pol Gonzalez