We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
The existing method was overly complicated given that KPackage can load packages
relative to the default package root. Also it didn't work because QStandardPaths
defaults to LocateFile, not finding any packages.
Summary: It was previously using the old style due to getting downcast too early
Test Plan: Compiles
Reviewers: #plasma, sitter
Reviewed By: sitter
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22840
Summary:
QActionGroup has no signal for when an action within the group changes
checked state. Only when an action within is triggered.
Without calling trigger InteractiveConsole::modeSelectionChanged is not
triggered and m_mode is not updated.
BUG: 408787
Test Plan:
qdbus to launch the console
Execute button went to the right place
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21852
Alexander Lohnau
Laurent Montel
Nicolas Fella
David Faure
David Redondo
Yuri Chornoivan
David Edmundson
Friedrich W. H. Kossebau
Aleix Pol Gonzalez
Marco Martin
Aaron Seigo