There were three principal sources of errors and warnings:
1. Un-ported `onFooChanged` statements
2. `config.fontSize` being unconditionally referenced from components
without access to it (it comes from the SDDM config)
3. Accessing units from the context property rather than the singleton
All are fixed now. Tested with:
1. `sddm-greeter --test-mode --theme ~/kde/usr/share/sddm/themes/breeze/`
2. `~/kde/usr/lib64/libexec/kscreenlocker_greet --testing --theme ~/kde/src/plasma-workspace/lookandfeel`
3. `/kde/usr/lib64/libexec/ksmserver-logout-greeter --fakearg`
No regressions found.
BUG: 425349
FIXED-IN: 5.20
Gives them a nicer icon.
The icon does not yet exist in Plasma but gaming-input does, so it falls back to that.
CHANGELOG: Battery Monitor can now show battery levels of gaming devices, such as wireless gamepads and joysticks
Differential Revision: https://phabricator.kde.org/D11571
This allows the theme to decide it does not want us to just show a battery frame
and then add the individual fill pieces but to provide a different battery for
every fill. The current Breeze theme does this by providing a red Fill20 and Fill0
and to prevent superimposing a full red battery ontop of a black one, the Battery svg
can have this item which hides the battery frame.
If a theme decides to manipulate the looks of the "empty battery",
like the current Breeze theme does by painting it red, it can now
provide a Fill0 svg. If it is not present, the old behavior, showing
just the battery "frame" that is, remains.
Nate Graham
Kai Uwe Broulik
Aaron Seigo