Summary:
Use '\0' as separator as '\n' is likely to appear in values.
BUG: 413130
Test Plan:
/etc/profile.d/mc.sh exported an mc() function,
which resulted in "syntax error: unexpected end of file" in the Plasma session.
Now the mc function is correctly set in the environment.
Reviewers: #plasma, apol, davidedmundson, adridg
Reviewed By: #plasma, apol, davidedmundson, adridg
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24750
According to the spec, xesam:artist should be a string array, but
majority of players uses string instead. This patch adds support for
both string array and string options to allow new software development
according to the spec but also maintain compatibility with existing
solutions.
BUG: 405762
FIXED-IN: 5.17.1
Differential Revision: https://phabricator.kde.org/D24740
Summary:
Icon should be highlighted hover, as any other icons in the system tray.
CCBUG: 400295
Test Plan: Hover mouse over over the icon - it should highlight.
Reviewers: #plasma, davidedmundson, #plasma_workspaces, broulik
Reviewed By: #plasma, #plasma_workspaces, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24738
And make it the default.
Kill Switch is only for when you think something off is happening or you
don't feel in control.
Reviewed by David Edmundson (see D24635)
Summary:
Right now windy conditions are not handled at all. I live in an area with very frequent
windy conditions especially during certain times of year so this is annoying because I
see the purple question mark icon a lot, which in the past has made me stop using the
weather widget.
This patch implements handling for windy + clear and cloudy conditions for NOAA. I
don't know how to implement this for Wettercom.
Depends on D24537
Test Plan:
Before: {F7568603}
After: {F7568554}
Reviewers: kossebau, #plasma, spstarr
Reviewed By: #plasma, spstarr
Subscribers: spstarr, plasma-devel, #vdg
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24483
Summary:
I just switched to openSUSE Tumbleweed and noticed that the session names in SDDM's
chooser don't include "X11" or "Wayland" like they do in other distros I've used before. This
makes it impossible to tell which one you're going to boot into.
This patch adds those identifiers into the translated string so it's always clear.
Ideally https://github.com/sddm/sddm/pull/997 would get done first, but even it it doesn't,
it's no big deal.
Reviewers: fvogt, davidedmundson, apol, #plasma
Reviewed By: davidedmundson, #plasma
Subscribers: fvogt, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24666
Summary:
Because this script copies things to /, it needs to be run with `sudo`. But two of the
copy operations also copy things to your home directory, and if you `sudo` the whole
script, this results in those files being copied with root ownership, which can cause
problems later.
This patch prepends `sudo` to just the copy operations that need it so that the ones
that don't aren't run with inappropriately elevated permissions.
Test Plan:
- Run `~/kde/build/plasma-workspace/login-sessions/install-sessions.sh`
- Get prompted for the root password
- Enter it
- See that `plasma-dev-prefix.sh` and `startplasma-dev.sh` in `~/kde/usr/lib64/libexec/` have user ownership, not root ownership
Reviewers: apol, #plasma
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24677
Summary:
SDDM until 0.18.1 appends " (Wayland)" to the name of any session file it
finds in wayland-sessions dir, and Plasma is relying on that behaviour to
distinguish between its X11 and Wayland sessions. This leads to duplicate
"Plasma" entries on any other DM not applying the same hack, e.g. lightdm,
and users are lost without downstream patching.
SDDM in 0.19 only appends " (Wayland)" in case the session name does
not already end with this, to avoid duplicating it.
CCBUG: https://bugs.kde.org/show_bug.cgi?id=368409
See also: https://github.com/sddm/sddm/pull/997
Reviewers: #plasma, davidedmundson, fvogt, ngraham
Reviewed By: #plasma, davidedmundson, fvogt, ngraham
Subscribers: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22210
Fixes erroneously enabling do not disturb mode in some situations when having screens mirrored and then closing the lid.
You'll have two overlapping screens but one of them is disabled so should be ignored.
Depending on the order of outputs this may or may not happen (which is why I didn't notice earlier when I tested with my new laptop).
CHANGELOG: Fixed erroneously entering do not disturb mode when there are overlapping *disabled* screens
Differential Revision: https://phabricator.kde.org/D24679
Summary: It's not visible in the desktop system tray, but it is visible in the Plasma Mobile drawer where it is the only colorful icon. Let's use a monochrome one that actually looks like a battery instead
Reviewers: #plasma, bshah, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24649
Summary:
Instead of a combo box, which is a bit harder on the wording.
Also get more texts from kuserfeedback itself, no reason to translate twice.
Test Plan: Tested manually
Reviewers: #plasma, ngraham, broulik
Reviewed By: #plasma, ngraham, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24470
Summary:
If available, always use 32-bit color. We don't need Composite extension to handle transparency - all client windows are our children and transparency in handled in QML, inside the panel (so no need to composite real windows).
BUG: 356937
FIXED-IN: 5.17.1
Test Plan:
Disable compositor, run:
- pidgin (make sure pidgin-libnotify is NOT installed)
- keepassx
- xchat
- liferea
Before changes: black backgroud
After changes: transparent background
Reviewers: davidedmundson, #plasma_workspaces, #plasma
Reviewed By: davidedmundson, #plasma_workspaces, #plasma
Subscribers: mlaurent, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24530
Original intention was that we would be globally off by default.
When enabling it would have a default setting for Plasma ready
That doesn't quite work out just yet.
See bug for details
This is a precautionary temporary fix just to be extra safe
CCBUG: 412913
Summary: Include duplication, no newline at the end of file and missing argument to the i18n() call
Test Plan: Should work fine but needs a review for i18n() calls
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24580
All the new QML KCMs have their library in kcms/ subfolder
Also improve error reporting a bit by reporting whether the library was not found or its symbol is missing.
Differential Revision: https://phabricator.kde.org/D24557
Summary:
XCB may return null pointer as a response. Add a check to prevent
segmentation fault.
BUG: 409652
FIXED-IN: 5.17.1
Test Plan: It is hard to reproduce, but the reason of the segmentation fault is pretty obvious, thanks to the debug dump from bug 409652
Reviewers: #plasma_workspaces, #plasma, davidedmundson
Reviewed By: #plasma_workspaces, #plasma, davidedmundson
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24514
Summary:
Do not scale up small icons to avoid quality detoriation. For small icons scaling should be done in SystemTray only. Currently XembedSNIProxy scales to 32x32, then SystemTray (usually) scales it down to 24x24.
BUG: 366047
FIXED-IN: 5.17.1
Test Plan:
I've run few applications with small icons:
- keepassx (22x22)
- liferea (16x16)
- tuxguitar (16x16)
It looks much better without scaling in xemebdsniproxy.
Reviewers: davidedmundson, #plasma, #plasma_workspaces
Reviewed By: davidedmundson, #plasma, #plasma_workspaces
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24531
Summary:
If needed, perform resize in each update().
Client window may be too big, it must be resized to a certain reasonable size. Sometimes resizing in the constructor is not enough because it is too early and the client window is not fully initialized. Even if client window is resized, on first update it reverts back to original size (or just ignores the first request - some kind of a race condition).
In addition, I applied some rules from: https://community.kde.org/Policies/Kdelibs_Coding_Style
BUG: 358240
Test Plan:
I tested it using keepass2, now it shows better results (still not perfect). Window is resized to 32x32, but icon is only 24x24 it top-left. Better than 273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.
I tested this change with several other apps for regressions, no issues:
pidgin
liferea
hexchat
tuxguitar
xchat
keepassx
stardict
and other I don't remember now. No regressions.
Reviewers: davidedmundson, #plasma, #plasma_workspaces, broulik
Reviewed By: davidedmundson, #plasma, #plasma_workspaces
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24529
l10n daemon script
Kai Uwe Broulik
Fabian Vogt
Denis Sheremet
Konrad Materka
Aleix Pol
Nate Graham
Andreas Sturmlechner
Guo Yunhe
Nicolas Fella
Filip Fila
David Edmundson
Yuri Chornoivan
Konrad Materka
Jonathan Riddell