Summary: KFileUtils::suggestName() is a drop-in replacement, just moved to another library
Test Plan: builds
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23996
Summary: We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21546
Summary: We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21546
Summary: We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21546
Doing this on startup can easily add up to 20ms startup time for every icon pointing to a file.
It is not an issue with application links that don't have open with actions fortunately.
Differential Revision: https://phabricator.kde.org/D18925
This reverts commit e37156b404.
Concept is fine, but currently we have severe CMake issues as well
as a major containment loading bug.
When re-reverting we need to be sure to test with clean install prefixes.
CC: plasma-devel@kde.org
Summary: use the new install macro which compresses packages in a bundled rcc
Test Plan: tried to load and use every single plasmoids
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11514
We used to always delete the backing .desktop file if we changed a property in a Link (to
a document) hoping that setUrl would call populate. However, it won't do that if the URL
didn't change, so if you only changed the icon, the .desktop file was removed and never
re-created, breaking the applet.
BUG: 380922
FIXED-IN: 5.10.2
Differential Revision: https://phabricator.kde.org/D6148
Summary:
This patch uses the new units.iconSizeHints.panel API to limit the
icon size to what the user sets for panel icons in System Settings,
avoiding them taking up too much space, particularly in wide vertical
panels.
See D5592 and D4550 for similar changes.
Depends on D5593.
CCBUG:378443
Reviewers: #plasma, mart, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5594
Take into account the label's height for minimum size. When we resize the applet super tiny,
it's likely text wraps onto two lines, so use a two line text as minimum (it already does that for preferredHeight anyway).
Differential Revision: https://phabricator.kde.org/D4477
Summary:
applets that acces their config in C++ needs to implement
configChanged() in order to still work correctly in the scripting
console
Test Plan: correct icon when created from scripting console and config written from there
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4461
Summary:
applets that acces their config in C++ needs to implement
configChanged() in order to still work correctly in the scripting
console
Test Plan: correct icon when created from scripting console and config written from there
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4461
Files in desktop:/ are local files but QUrl doesn't know this.
Also allows us to determin mime type and icon for files on a network share.
While at it, improve default naming logic.
BUG: 375103
FIXED-IN: 5.9.0
Differential Revision: https://phabricator.kde.org/D4157
This adds the "Open With..." option known from Dolphin to the icon applet when it points to a file.
Also adds a "Open Containing Folder".
While at it, moves the action logic for jump list actions to C++ side
Differential Revision: https://phabricator.kde.org/D3905
When applying KPropertiesDialog of a Link desktop file, the URL might have changed.
In this case nuke the local file and start afresh.
Differential Revision: https://phabricator.kde.org/D3906
The label is typically wider than the icon, so allow for 1.5x icon width as default
and also assume the label will be two lines of text which is the more common case imho.
This keeps a newly created icon applet from being cramped and tiny
For local files, the base name is used, for http(s):// URLs the host name
is used and only if that fails we'll fallback to fileName (which still can be empty)
When this restriction is enabled, KIO will refuse to run desktop files outside system-known locations
essentially breaking the icon widgetin this case. Since we still want to be able to have shortcuts
in locked-down setups, let's just use the source desktop file in this case and rather lose the ability
to customize it (which isn't really possible with this restrition anyway)