We do this sometimes, but not consistenly.
The benefit is twofold.
First it improves the diff when adding new values since no existing line needs to be touched.
Second it prevents clang-format from collapsing the definition into a single line, which is undesired for large enums.
Right now we have a usability problem: the Digital Clock applet has two
ways to let you change the timezone displayed in the applet itself, but
has no easy link to the correct way to change the timezone systemwide. As
a result, users change the timezone in the clock and wonder why times are
wrong everywhere else throughout the OS.
This commit removes the feature of changing the timezone in just the
clock, and replaces it with an overhauled Time Zones page in the config
dialog and a new button in the popup that links you to the Date & Time
KCM where you can change the systemwide time zone in the correct way.
I anticipate that this may cause some grumbling from people who currently
use the "mouse wheel to cycle through timezones" behavior, but now that
all the timezones and their times are displayed prominently in the popup,
you can just click on the applet to show the popup instead of rolling the
mouse wheel over it to cycle through times; it's different, but no worse.
BUG: 428096
FIXED-IN: 5.21
Update the list of country names to the current names in iso-codes
(as output by isoquery -c).
The motivation is updating the name of Czechia as a followup to
https://git.reviewboard.kde.org/r/129644/
As suggested by Albert Astals Cid, fixing the name in i10n is not
enough:
country names are hardcoded in many places and they need to be fixed
separately.
REVIEW: 129691
Instead of an hardcoded list of translations of country names, look
them up in the iso_3166 domain, provided by iso-codes. The names of
countries are changes to their ISO 3166 versions in iso-codes.
Look for iso-codes in cmake, but just as indication of it as runtime
dependency.
REVIEW: 126879
In kde4 times, the layout of clock's tooltip was nicely arranged using a
table. Now it's a bit of a mess so this brings back some nice layout.
Also simplifies the timeForZone function which is used only for the
tooltip.
BUG: 357005
BUG: 351472
CCBUG: 357004
FIXED-IN: 5.6.0
REVIEW: 124047
Adds a simple QSortFilterProxyModel on top of TimeZonesModel and
reimplements filterAcceptsRow using QStringMatcher (supposedly faster
according to qtdocs).
REVIEW: 123740
BUG: 346681
FIXED-IN: 5.3.1
This was added for KDeclarative 5.9 which we already depend on, so let's
just use it. Battery applet already does.
Backports parts of f5a177b6fa
BUG: 347032
FIXED-IN: 5.3.1
Not all zones have '/' so the splitting may not result in list of two
entries. Use last() instead of at(1) to avoid possible out of bounds
assert.
BUG: 339411
Still has couple missing features:
* no time in the tooltip yet (needs larger refactor)
* no order selection
* no default timezone (but last used is always saved)
* couple minor issues
REVIEW: 120314
CCBUG: 337564
Nicolas Fella
Nate Graham
Ahmad Samir
Yuri Chornoivan
Laurent Montel
Bernhard Schiffner
Friedrich W. H. Kossebau
Kai Uwe Broulik
Jiri Bohac
Aleix Pol Gonzalez
Elias Probst
Pino Toscano
Martin Klapetek
Imran Tatriev
Lukáš Tinkl
Jonathan Riddell