Summary:
This change allows users to scroll through krunner output using their homerow.
- Ctrl+j: Scroll Down
- Ctrl+k: Scroll Up
This makes scrolling easier for those familiar with this convention but doesn't inhibit users who aren't.
Reviewers: broulik, #plasma_workspaces, davidedmundson
Reviewed By: #plasma_workspaces, davidedmundson
Subscribers: davidedmundson, #plasma_workspaces, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13686
Summary:
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.
BUG: 392197
Test Plan:
Deployed change, killed, restarted, and activated KRunner, typed a search term:
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moves to the previous item in the results list
Activating the {nav Open Containing Folder} button for the first result via the keyboard changes slightly with this patch:
- Currently, it's {nav down arrow > tab key}
- With this patch, it's {nav tab key three times} or {nav down arrow > shift + tab}
Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11611
Indicates that there's a "drop down" history similar to a ComboBox.
The fact that you can press the down arrow to bring it up is hardly discoverable.
BUG: 375207
FIXED-IN: 5.13.0
Differential Revision: https://phabricator.kde.org/D10652
Summary:
enable actual keyboard navigation, as the previous
completely manual keyboard navigation in krunner completely broke
the screen reader support, rendering it inaccessible (while
potentially krunner is one of the most useful apps for blind
users)
Test Plan:
tested to navigate with keyboard (still similar behavior as before)
while having orca running, which correctly read the result entries
Reviewers: #plasma, davidedmundson, broulik
Reviewed By: #plasma, davidedmundson
Subscribers: gladhorn, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D7765
If no text is input "Search..." is shown to clarify what this window the user might
have accidentally triggered is all about. In single runner mode, the name of the
runner that will be queried will be shown.
REVIEW: 126878
When in single runner
This fixes KRunner seemingly stop working after entering single runner mode,
such as through the user switcher, and then continuing to use it normally later.
CHANGELOG: KRunner no longer stops showing results under certain circumstances
When a result is invoked, the query string is prepended to the history, query strings
are only added once. When KRunner is opened, the history will be displayed right away.
The old ComboBox approach caused bad usability because of two vertical lists conflicting
with each other.
REVIEW: 123888
The Milou.ResultView now notifies us when it thinks we should update the
queryString. The main use of this is the calculator runner. On executing
an action on that runner, it is expected that the text field be updated.
BUG: 342190
FIXED-IN: 5.2
Lets send the text instantly instead of waiting. It feels way more
responsive this way. We all can evaluate it and see if a short timer
should be added again.
We now only use a scroll area if we are larger than the screen height.
Otherwise we show all the results. This makes sense since we only show a
maximum of 20 results, so we will ideally always have a fixed size.
REVIEW: 118791
ColumnLayout tries to center vertically its items
that of course doesn't work when you have a container that resizes vertically,
and you want the items, in this case the text box to stay exactly still
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Jacopo De Simoi
Michael Eden
Kai Uwe Broulik
Nathaniel Graham
Marco Martin
Frederik Gladhorn
Vishesh Handa
Aleix Pol