I slapped a console.time in there and it would show 1ms even on some
of the subsequent invocations, so while QML engine should do some
caching magic, calling it once is better anway.
Differential Revision: https://phabricator.kde.org/D2719
Summary:
on vertical panels the systray could get
stretched to a size taller than it should, getting
a lot of empty space
BUG:368146
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2645
If all system tray icons are visible the arrow would hide but the reserved
space for the system tray would not change leavnig a gap.
BUG: 365636
FIXED-IN: 5.7.4
Differential Revision: https://phabricator.kde.org/D2387
There was a conflict between adding a config option [1] in master and a
fix to crop to the icon size [2] in the 5.7 branch. I still need the
cropping on my vertical panel, otherwise the icons are insanely big.
[1] https://git.reviewboard.kde.org/r/128400/
[2] https://phabricator.kde.org/D2160
Reviewed-By-Over-IRC: Marco Martin <notmart@gmail.com>
BUG: 365394
This prevents the entire list item to zoom in and out when a NeedsAttention
item is forcefully hidden in the popup.
Differential Revision: https://phabricator.kde.org/D2099
This should fix the icons growing so large that there's hardly any padding around
them so they would overlap the indicator strip. It also makes the icon size more
consistent with other icons on the panel but there's still some differences depending
on the panel size and screen resolution.
Differential Revision: https://phabricator.kde.org/D2160
the option is not user exposed, so can only either be set manually
or by the default configuration script in the look and feel kcm
patch by John Salatas jsalatas@gmail.com
REVIEW:128400
So far, the width was only adjusted when opening the config but not when
actually assigning a shortcut, causing the shortcut button to flow outside bounds.
Reviewed-By: notmart
This ensures contents of the popup gets mirrored and the sidebar is moved to the
right and applets don't overlap it.
The expander arrow is not (yet) adjusted as this is much more complicated to solve.
Differential revision: https://phabricator.kde.org/D2048
Summary:
This matches the base CompactApplet in plasma-desktop.
This prevents the panel autohiding when a popup is still showing.
BUG: 364847
Test Plan:
Opened popup panel didn't autohide.
Autohid once popup closed
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2034
This matches what the other plasmoids are doing but we didn't get for free as we don't
use the ordinary applet popup logic in system tray.
Differential Revision: https://phabricator.kde.org/D1907
Summary:
Width should not include top and bottom margins
BUG: 364543
FIXED-IN: 5.7
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D1966
When you click an item it might show a menu of some sort which will grab the mouse
and the ToolTipArea never gets a leave event causing the tooltip to show up above
the menu.
Differential Revision: https://phabricator.kde.org/D1847
The model has changed and is now created in JS but the code that changes the shortcuts was never adjusted
Differential Revision: https://phabricator.kde.org/D1567
it's way simpler and more reliable than using it trough ObjectModel
ObjectModel seems good enough if items are always owned by one
but not when going back and forth between 2 models