KCMs can be individually disabled by KIOSK if desired but wallpaper configuration cannot (unless you lock down
Plasma completely). Hence, at least honoring the ghns restriction here, until we have a proper solution
(that is a QtQuick equivalent of KNS3::Button).
Also, KNS3::DownloadDialog refuses to open when ghns is restricted *but* this applies only to using open()
or exec() but not a blatant show() we do from QML.
Differential Revision: https://phabricator.kde.org/D7086
This allows to open the location of the folder the wallpaper is in.
BUG: 371247
FIXED-IN: 5.11.0
Differential Revision: https://phabricator.kde.org/D6450
Summary:
Currently the selected wallpaper is deselected when the "Apply"
button is clicked, as if no wallpaper is selected. This patch
fixes that. I didn't understand what the original restoreIndex
thing was trying to do by passing the count, so I gutted it and
wrote code that makes more sense to me.
Reviewers: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D5440
Summary:
Whilst using units is generally good, the wallpaper transition time is
way too short. It's a different type of animation to the others,
especially in a slideshow, where the transition is an important part of
the behaviour.
This patch loads it from a hidden configuration option with a duration
of 1000ms, if and only if animations are enabled.
Value determined through brief trial and error.
BUG: 365979
Test Plan:
Opened wallpaper. Clicked next.
Also changed static wallpaper manually, transition looked fine
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4370
Summary:
Currently the we create previews with QPixmapItem from KDeclrarative and
when a wallpaper is set to centered sets it to an enum value that
doesn't exist.
PreserveAspectFit displays the wallpaper in the correct proportions as
when it will be applied, but will still be big enough to make it
actually previewable.
BUG: 375675
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4840
Summary:
qml gridview don't have an official way to ensure the
current index is visible when the view is first instantiated,
the only way we have is to do positionViewAtIndex when we know the
proper space has already been allocated (Component.onCompleted
is way too early) we used to do that on onCountChanged, but that
too seems to early sometimes, as the selected wallpaper
is visible only sometimes, attaching it to onContentHeightChanged
seems to be more reliable (for all branches)
Test Plan: proper wallpaper is visible every time the window opens
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4648
Summary:
qml gridview don't have an official way to ensure the
current index is visible when the view is first instantiated,
the only way we have is to do positionViewAtIndex when we know the
proper space has already been allocated (Component.onCompleted
is way too early) we used to do that on onCountChanged, but that
too seems to early sometimes, as the selected wallpaper
is visible only sometimes, attaching it to onContentHeightChanged
seems to be more reliable (for all branches)
Test Plan: proper wallpaper is visible every time the window opens
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4648
Summary:
qml gridview don't have an official way to ensure the
current index is visible when the view is first instantiated,
the only way we have is to do positionViewAtIndex when we know the
proper space has already been allocated (Component.onCompleted
is way too early) we used to do that on onCountChanged, but that
too seems to early sometimes, as the selected wallpaper
is visible only sometimes, attaching it to onContentHeightChanged
seems to be more reliable (for all branches)
Test Plan: proper wallpaper is visible every time the window opens
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: hein, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4648
Summary:
f6ce91499a replace the height/width property of Image with
targetSize, and phone image configuraiton was not adopted for that
change resulting in broken configuration window for plasma mobile
Test Plan: tested on phone
Reviewers: broulik, #plasma
Reviewed By: broulik, #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4528
Directly expose "targetSize" as property. The wallpaper is already initialized with
the correct size for some time now but the fact that we had two properties width and height
in there had it still do unneccessary work when it emitted "sizeChanged(2560, 0)" and
then the final "sizeChanged(2560, 1440)" afterwards.
Also, I didn't really see a point in storing the wallpaper size in its config,
it's overwritten by the wallpaper anyway and only used in the wallpaper config dialog
for the aspect ratio. We can just ask the view directly then.
BUG: 374689
FIXED-IN: 5.9.0
Differential Revision: https://phabricator.kde.org/D4001
Summary:
select the correct index upon loading when the count changes.
this removes the flicker at startup and the view is at the correct
wallpaper since the first frame. Also, now when a wallpaper is
downloaded with knewstuff, the old wallpaper stays selected,
it doesn't get resetted to the first wallpaper anymore
Test Plan:
open wallpaer dialog, no more flicker
install a new wallpaper, the currently selected one stays selected
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3532
Summary:
This caused it to be cropped on some translations.
This patch only sets the minimum size to force it to line up with the form layout,
but still allow the text to be larger if needed.
Also tidy up other use of directly setting width/anchors in a layout.
BUG:368487
Test Plan:
Checked English layout matched up
Changed text to "asdfasdfadsfasdfljasdfjadlf" and checked that still fit
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D2729
"syspal" is referenced by the WallpaperDelegate but added by the Containment
Appearance Configuration QML which isn't there when loading the wallpaper config
into a different view like the lock screen UI.
Differential Revision: https://phabricator.kde.org/D2752
When simultaneously fading two items (one from fully opaque to transparent and the other
one vice-versa) you can briefly see the black background through the images leading to an ugly flicker.
By only doing this when the old image could be seen (when the new one has a smaller
size) we avoid this in the common case of full-size wallpapers.
Ideally, crossfading would be done using a ShaderEffect.
Differential Revision: https://phabricator.kde.org/D2484
Summary:
If user is using svg wallpaper with opaque area, then this allows users to fill opaque area with color.
BUG: 351012
Reviewers: #plasma, bshah
Reviewed By: #plasma, bshah
Subscribers: bshah, broulik, plasma-devel
Projects: #plasma
Differential Revision: https://phabricator.kde.org/D1008
Moving the opacity change from a ScriptAction to a parallel OpacityAnimator. That seems to cause a repaint in whatever weird environment happens to be the root of this bug.
BUG: 345405
REVIEW: 124093
If there are no metadata, showing "by Unknown" is a bit strange and
serves not much purpose. So let it show only the filename when no
metadata available.
REVIEW: 122622
Do not bind the image's sourceSize to the root item's size since that will reload the image
immediately whenever the size changes. Instead, wait 1 second and then gradually fade to the
new size.
REVIEW: 121294
QQC.ScrollView tries hard to set interactive=false on the
flickable item if the system has no touchscreen, which
disables GridView's keyPressEvent handling.
On the flip side the GridView code doesn't handle Home/End,
while this does.
The GridView needs to receive focus for keyboard navigation. Also, make
sure that we're not changing the current wallpaper on deselection, this
might happen when the currentIndex is changed through the keyboard.
- Minimize overdraw by showing the color Rectangle only if it would be visible
- Use an Animator for the image transition and defer animation until image is loaded
(-> no more stuttering when choosing a heavy wallpaper such as the Plasma Next one)
REVIEW: 121162
The parent item has opacity == 0.8, which means both the preview icon
and the actual preview are sligtly transparent and the icon bleeds
through; let's hide it completely
BUG: 339628
Reviewed-by: Bhushan Shah
Kai Uwe Broulik
Eike Hein
David Edmundson
Marco Martin
Bhushan Shah
l10n daemon script
Bhavisha Dhruve
Martin Klapetek
David Edmundson
William Lieurance
Antonis Tsiapaliokas
Sebastian Kügler
Lukáš Tinkl