Added a ban on disabling the last checkbox in the widget settings.
There will always be at least one graph.
If the user disables the last checkbox, all other checkboxes will automatically get enabled in the settings.
It may be inconvenient for users to uncheck a large number of checkboxes.
I'm planning to use it in job notifications, too.
This should also make it easier to migrate away from a custom drag implementation to using Qt's if we were to do that.
Differential Revision: https://phabricator.kde.org/D25751
Summary:
This removes hacks and does things in a cleaner way.
Credits go to @broulik.
Reviewers: #plasma, broulik, ngraham
Reviewed By: ngraham
Subscribers: ngraham, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25614
When e.g. connecting to a network with captive portal, it leaves you sitting there wondering what's going on.
The notification won't time out until it becomes visible again but still there's been complaints that the notifications go missing.
This patch makes them move out of the way vertically.
It is pretty crude but covers the majority ("System Tray covers notifications") case.
Differential Revision: https://phabricator.kde.org/D25566
Summary:
support the automatic shadow hint
When the hint is shadowedBackground, do an automatic shadow with a shader, and
change applet's color to complementary
Test Plan:
Tested the functionality on various applets. To test, the digital clock is enabling explicitly background configurability
{F7788553}
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25591
Summary: Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use `i18ncp` because the number isn't integer.
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25319
Summary:
The TableView in digital clock widget time zone configuration is replaced with ListView. Other UI didn't change.
{F7635385}
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: GB_2, ahiemstra, broulik, kmaterka, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24798
Summary:
Most group have icons, this one did not. A new icon just got created for
all applications, it makes sense to be consistent.
This has no effect in the kicker-dash as that does not show icons, nor
kicker/kickoff as they don't show the all applications group.
Only third party menus will be affected.
Test Plan:
Looked at my custom menu
Looked at kicker-dash
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25294
Summary:
Adding support for Attention Icon to StatusNotifier tray icons.
Binding is working correctly only when "Status" is used, not derived "status".
BUG: 341255
Test Plan: As described in bug report, Konversation can be used for tests.
Reviewers: #plasma, broulik, #plasma_workspaces
Reviewed By: #plasma, broulik, #plasma_workspaces
Subscribers: lbeltrame, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24865
Summary:
Currently the code that draws plasmoid popups utilizes an anchor based approach.
I think layouts are a more elegant solution so this patch makes use of them.
Test Plan:
{F7616902}
{F7616901}
{F7640510}
Reviewers: #plasma, #vdg, ngraham, mart
Reviewed By: #plasma, #vdg, ngraham, mart
Subscribers: safaalfulaij, manueljlin, ognarb, ngraham, kmaterka, mart, GB_2, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24720
Especially for the custom one it's useful to have a live preview rather than trial and error with the Apply button.
Differential Revision: https://phabricator.kde.org/D25091
Summary:
Fixed issue when time zone configuration page was not scaling corrently. As a result two
srollbars were rendered.
Fixed few QML layout warnings and undefined references.
Test Plan:
Open Time zones configuration page and shrink window - two scrollbars are rendered.
Expected: table is scalled correctly and only one scrollbar in table is rendered.
Reviewers: #plasma, #plasma_workspaces, ngraham
Reviewed By: ngraham
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24853
Summary:
{F7665577}
Keep it as before on the desktop to be consistent with the other plasmoids
Test Plan: run plasmashell with/without QT_QUICK_CONTROLS_MOBILE
Reviewers: #plasma, #vdg, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, KonqiDragon, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24934
Summary:
some optimizations for tablet mode (touch first, but also on
transformable laptops flipped to tablet)
and some for specifically the mobile case (mobile phone)
* hide the top toolbar in phone mode
* in tablet mode (and therefore on phone mode too) don't select text but drag the item laterally to dismiss it
Test Plan:
* on phone form factor for the new behavior
* on touch laptop in tablet mode
* on desktop for its behavior not changing at all
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: nicolasfella, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24765
Summary:
Adding support for Attention Icon to StatusNotifier tray icons
BUG: 341255
Test Plan: As described in bug report, Konversation can be used for tests.
Reviewers: #plasma, davidedmundson, apol, mart, ngraham
Reviewed By: #plasma, davidedmundson, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24767
According to the spec, xesam:artist should be a string array, but
majority of players uses string instead. This patch adds support for
both string array and string options to allow new software development
according to the spec but also maintain compatibility with existing
solutions.
BUG: 405762
FIXED-IN: 5.17.1
Differential Revision: https://phabricator.kde.org/D24740
Summary:
Icon should be highlighted hover, as any other icons in the system tray.
CCBUG: 400295
Test Plan: Hover mouse over over the icon - it should highlight.
Reviewers: #plasma, davidedmundson, #plasma_workspaces, broulik
Reviewed By: #plasma, #plasma_workspaces, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24738
Summary: It's not visible in the desktop system tray, but it is visible in the Plasma Mobile drawer where it is the only colorful icon. Let's use a monochrome one that actually looks like a battery instead
Reviewers: #plasma, bshah, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24649
Summary: Include duplication, no newline at the end of file and missing argument to the i18n() call
Test Plan: Should work fine but needs a review for i18n() calls
Reviewers: #plasma, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24580
The inhibition handling (e.g. combining time-based, screen mirrored, etc) is done inside the applet.
The Server knows nothing about it and only reports Inhibited as true when an external application
requested one, not when the user enabled it in the applet.
This patch exposes the NotificationManager.Server as singleton QML type and adds a way for the
applet to tell it the effective inhibition state.
Exposing the server to QML could also be used in the future to provide better error reporting
to the user when the service isn't running and/or owned by someone else (e.g. Dunst)
Differential Revision: https://phabricator.kde.org/D24486
l10n daemon script
Pavel Mars
Kai Uwe Broulik
Filip Fila
Marco Martin
Yuri Chornoivan
Guo Yunhe
David Edmundson
Konrad Materka
Nicolas Fella
Denis Sheremet