Modify applicationjobs dataengine so that "error" value
now contains job's error code and "errorText" error message.
This depends on commit 812d0b440e7f08e3acdd1c9bb95779bd871b75b3
to kjobwidgets.
REVIEW: 122928
Check for job error when job finishes and in case of error, set notification
summary to "%job_message%: Error", body to error text and clears the
actions (no open url).
It only works with jobs that actually sets the error text (KJob::setErrorText),
because KJob::error is not exposed in dataengine.
REVIEW: 122921
Especially the first ones ("Just now", "10s ago", "30s ago") come in quick succession
making it feel weird for them to only update when opening the dialog.
It also simplifies the code thanks to triggeredOnStart
REVIEW: 122230
Especially the first ones ("Just now", "10s ago", "30s ago") come in quick succession
making it feel weird for them to only update when opening the dialog.
It also simplifies the code thanks to triggeredOnStart
REVIEW: 122230
There were situations when the same notification popup could be be
inserted twice into the available popups list, breaking the positioning
as it would create more notifications than it was able to but they would
never get closed and would offset the whole stack.
One of such scenarios was when user manually closed the popup with the
close button. After it was hidden, the hiding timer still went on to
fire and close it again, causing the above.
Should be all fixed now.
BUG: 342605
- All of this ugly conditional anchoring has been replaced by layouts where applicable
- The details have been outsourced into a separate file which is loaded on demand
- Removes code duplication by using fancy Repeaters
REVIEW: 121057
Whenever a job disappears for whatever reason (cancelled, finished, error, ...) we display
a persistent "Job Finished" notification. When the user explicitly cancels the job, there's
no need to confirm since the job will be gone. This solution is not ideal since we just track
it inside the plasmoid (ie. when you click Cancel in a "Override this folder?" dialog, it will
still show the notification) but at least the obvious "You don't say" moment is gone that way.
Ideally in the future whoever is responsible for the job (KIO, ...) should be given the
responsibility for an appropriate notification since the owner knows best why a job quit.
CCBUG: 340068
According to the notification spec, the body is a subset of HTML which implies that it's the
client's responsibility to take care of escaping things that look like tags.
REVIEW: 121155
- Some minor code styling (new Array() -> [], new Object() -> {} etc)
- Pass the notification object we get from the data engine to addNotification verbatim
instead of having an ugly function with dozens of parameters we just use to construct
a similar object ourselves anyway
- Push actions into array directly instead of creating a new Object, setting its properties
and then pushing it
REVIEW: 120993
According to the notification spec, the body is a subset of HTML which implies that it's the
client's responsibility to take care of escaping things that look like tags.
REVIEW: 121155
- All of this ugly conditional anchoring has been replaced by layouts where applicable
- The details have been outsourced into a separate file which is loaded on demand
- Removes code duplication by using fancy Repeaters
REVIEW: 121057
David Rosca
Montel Laurent
Jonathan Riddell
l10n daemon script
Kai Uwe Broulik
Martin Klapetek