Summary:
kde4_add_app_icon is fairly deprecated. additionally the call itself
was madness because it actually pulls the icon out of oxygen in the install
location. that is assuming the icon theme is even installed at build time
(which is probably always not true in our binary factorization
environments). lastly the app_icon helper is only useful to pick up
icons for osx and windows, neither are target platforms for plasma.
remove the app_icon call entirely until a use for it arises, which should
be... never... unless we decide that we want to replace explorer.exe ;)
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21766
Summary:
- hasn't been installed for years and no one missed it
- not actually ported
- using tech we want to get rid of (soliduiserver)
Test Plan: workspace still builds
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21747
Summary:
The macro is on its way to getting deprecated, so we better start
adopting the suggested alternative just as well.
Test Plan: plasmashell runs fine
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21493
Summary:
If the desktops are already visible, there's no much need to hold on the KSplash. Panels should be ellegantly displayed when they're ready.
As discussed in T10958.
Test Plan:
Made sure that it gets emitted at the right time.
Timing-wise, my system takes about 1s to show the DesktopView and 2s to show the PanelView (I have 1 panel)
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21494
* Don't autostart KRunner, use actions in the desktop file to
define global shortcuts and actions
* install its desktop file in share/kglobalaccel to make shortcuts default
* expand commandline options to permit more control via commandline
Differential Revision: https://phabricator.kde.org/D9037
Summary: When we updated the fonts in the sddm-theme, we bumped the default size from 9pt to 10pt. We missed adding the relevant code to the virtual keyboard button so it remained 9pt. This patch brings it up to 10pt.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21614
Summary: Starting from Plasma 5.16 we have the Next wallpaper is available in 5K resolution so we can make use of it in the login screen as well.
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: davidedmundson, ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10269
Differential Revision: https://phabricator.kde.org/D18007
Summary: This patch sets the source size for wallpapers used in the login screen to screen size. The goal is to save resources.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21611
This edge touches the notification text and as such shouldn't "bleed in" as with the other edges that touch the dialog borders.
Previously this wasn't an issue as there was a bug causing excess bottom padding on the dialog.
Differential Revision: https://phabricator.kde.org/D21569
Summary: Our current preview has become inaccurate so this patch updates it.
Reviewers: GB_2, ngraham, #vdg
Reviewed By: ngraham, #vdg
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21560
Ensures it doesn't overflow its bounding box. Shouldn't make a visual differences (save for the margin) as it is PreserveAspectFit
BUG: 408101
FIXED-IN: 5.16.0
Differential Revision: https://phabricator.kde.org/D21557
This tries to use fontSizeMode but in conjunction with QtRendering to achieve better number alignment.
Since this is more "part of an icon" than "proper text" using QtRendering is acceptable.
Differential Revision: https://phabricator.kde.org/D21408
Summary: We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21546
Summary: We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21546
Summary: We changed the desktop shadows in 10278e79f116, but we also need to reflect this change in the Icon applet which renders its own label and shadows.
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21546
Summary:
In file applets/kicker/package/contents/config/main.xml an option 'showIconsRootLevel' is mentioned. It has following description:
"Whether to show icons on the root level of the menu."
This change provides implementation for this option.
Test Plan:
Manual test:
1. Change menu to 'classic menu' (kicker), notice root level menu items have no icons
2. Open menu settings widget
3. Notice new checkbox 'Show icons on the root level of the menu'
4. Check that checkbox and hit 'Apply' button
5. Root menu items should now have icons similar which look similar to icons in 'modern menu' (kickoff)
Reviewers: hein, #plasma, #vdg, GB_2
Reviewed By: hein, #plasma, #vdg, GB_2
Subscribers: GB_2, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19829
Summary: Put load in queue of the event loop to wait for the whole set of containments to have been deleteLater(), as some like FolderView operate on singletons which can cause inconsistent states
Test Plan:
now switching look and feel between 2 themes that use both FolderView
as desktop containment, the icons are still there
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21513
during l&f switch, use destroy() which does a proper cleanup
and gives applets time to react to destroyedChanged, so we're sure they
properly cleaned up their states.
This among other things makes the in-app menubar work again when the
user switches from a style with a global menu bar to one without
This was meant to provide some separation but since the arrow icon has so much padding around it anyway and more importantly,
it breaks alignment in the list, remove it.
Differential Revision: https://phabricator.kde.org/D21471
Since the Notification Server knows nothing about what notifications were sent, it tells us a notification was replaced and
uses the ID supplied by the application. Only in the model we then realize it didn't exist.
This means we will potentially reuse the notification ID sent by the application as we just increment a counter.
However, in practice I haven't encountered this issue before (maybe we just never noticed?) but I think this is an
acceptable workaround.
BUG: 407881
FIXED-IN: 5.16.0
Differential Revision: https://phabricator.kde.org/D21474
Since there is timeout for when it is considered a separate notification and we don't even close the previous one properly.
Just remove that stopgap and if we need something like this again, do it properly.
Differential Revision: https://phabricator.kde.org/D21473
Harald Sitter
Laurent Montel
l10n daemon script
Aleix Pol
Jonathan Riddell
Kai Uwe Broulik
Filip Fila
Björn Feber
Aleksei Nikiforov
Marco Martin