By setting the deprecation version for KRunner to 5.91,
the negated deprecation wrapper will evaulate to true and
we get compatibility typedefs.
This way we do not need to add the typedefs manually or
add `using namespace Plasma` to the plugins.
Task: https://phabricator.kde.org/T15140
This saves us the custom implementation of mimeDataForMatch and
allows us to get the urls for example in milou, just like we already can
with the DBus runners.
If folders are marked as executable the runner will skip them
but we only want to skip files, because they are handled by
the shellrunner.
BUG: 432653
FIXED-IN: 5.21
Before the variables would get expanded later and consequently
go through another code path than file locations. This leads to the
text being differently displayed and users getting confused.
Also this allows us to check if the file actually exists.
BUG: 358221
FIXED-IN: 5.21
- Do not use deprecated RunnerContext::type()
- Write the url always in the data, this way we don't
need to do all the parsing twice.
- The concept of the case insensitive search does not make
sense in this runner. If the user want to have case insensitive
file search the baloo/recent docs/places runners should be used.
- Do not show a match when we are sure the file does not exist. This would
only show a KIO error message when launching it, consequently there is
no point in showing the message in the first place.
KProtocolInfo handles only protocols KIO knows but apps can also register to be
a URL scheme handler independently of this.
This patch makes the location runner also query for the preferred URL scheme handler
when no known protocol is found. It also prefers the scheme handler over the helper
protocol since a service has a name.
While at it, also format the protocol "exec" using DesktopExecParser to avoid
showing placeholders like '%u' to the user. Also use PreferLocalFile for "go to".
BUG: 416257
path.split may return empty string list if path contains only separator,
check the result before access it with last().
REVIEW: 126060
BUG: 355290
FIXED-IN: 5.5.0
In commit 983bacb8 (plasma-framework - 2011-05-20) the mimeDataForMatch
signature was changed. It now accepts a reference instead of a pointer,
but the runners don't seem to have been updated.
This is why we need proper automated tests.
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Alexander Lohnau
Nicolas Fella
Kai Uwe Broulik
Friedrich W. H. Kossebau
Méven Car
David Faure
Weng Xuetian
Montel Laurent
Vishesh Handa
Aleix Pol