Summary:
When a job is terminated, it isn't necessarily removed from the job
owners queue to handle pending requests.
If a service unregisters and the job is already finished, we don't want
to mark it as an error.
Test Plan:
kioclient5 (when running with fixed interactive-ness) quits when there's an error.
We used to always show the client died error.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17711
Summary:
If the host of a kjob crashes or is killed kuiserver currently reports
that the job has been completed successfully. This is seriously wrong as
it could lead a user to perform a potentially destructive operation.
Setting any error (that's not 0 or 1) will cause plasmashell, the main
kuiserver view, to show a persistent notification that a job has failed.
For master I will use a more correct new enum, new error text, and a way
to tell for KIO operations to report to the uiserver if the host
crashing is important or not.
CCBUG: 352761
Test Plan:
Whilst copying a million files killed dolphin
Got a persistent error instead of a success message on the last file it was on
Moving files successfully then killing the app remained fine
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17171
Use own copy of org.kde.JobView interface file to make it possible to
extend the interface without breaking build.
This also fixes 2 cases where error/errorText would be incorrect in
applicationsjob dataengine.
REVIEW: 123046
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-runtime, frameworks branch, at commit
85b1a18736650e28d8addd441f83083987298233
David Edmundson
Friedrich W. H. Kossebau
Montel Laurent
David Rosca
Aleix Pol