Otherwise the positioner will get completely confused.
When a notification is closed, the popup will already be closed in response to sourceRemoved.
Also, when triggering an action, call closePopup instead of hiding the popup.
(cherry picked from commit b97fdfa293)
Differential Revision: https://phabricator.kde.org/D4632
Summary:
if there is no battery don't show 0%, but a - on
the badge. still show the badge to show the option is not broken,
but don't show a weird 0% of a non existing battery
Test Plan: works on both systems with or without battery
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: broulik, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4606
Summary:
Make sure clicking on them will work the same on the popup and the delegate,
there were some issues on one or the other, now all the code is centralized
in NotificationItem.
Test Plan: Been testing locally, repeatedly
Reviewers: #plasma, davidedmundson, mart, albertvaka
Reviewed By: mart, albertvaka
Subscribers: mck182, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4545
Summary:
This is a patch to make the Network Monitor desktop plasmoid widget display the upload and download speeds in bits per second (Mbps, Kbps or bps as the case may be) rather than the fixed "KiB/s" unit.
It appears the input data is always in KiB units so the bps part may never be called but left it in there anyway.
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: broulik, sebas, Zren, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4551
Summary:
This uses the feature introduced here [1] on KNotifications, so default
actions don't appear as a regular action button. Instead, they are
activated by clicking on the notification itself.
If the default action is not set, it uses the previous behavior of close
on click.
This changes both the notification popup and the notifications inside the
plasmoid.
[1] https://phabricator.kde.org/D4142
Test Plan: Manual testing.
Reviewers: #plasma, colomar, mart
Reviewed By: mart
Subscribers: mart, broulik, apol, mck182, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4215
Instead of calling it in response to any of the properties it depends on.
This also saves some calls to this function on startup (80 instead of 90 for me with 14 tray icons)
and keeps plasmoids from shifting around just because their status changed from e.g. Active
to AcceptingInput (like touchpad when it asks for whether you really want to disable touchpad
with no mouse attached) although the item's effective visibility didn't actually change.
BUG: 375112
CCBUG: 365630
FIXED-IN: 5.10.0
Differential Revision: https://phabricator.kde.org/D4488
This part reverts commit b9af991403 which
changes plasmoids and SNI items to activate on mouse release instead of
mouse click.
This messes with xembedsniproxy which is relaying the mouse press
signals to the exembed client. Now at the time of relay, if the client
application queries the mouse state itself it's going to be wrong and
that breaks GTK.
BUG: 375930
FIXED-IN: 5.9.2
Reviewed-By: David Edmundson
Summary:
We somehow ended up with two applets named Application Menu; kicker and
the global menu bar. Both having the same name is confusing.
This is a translation break on a stable branch, but it's a bug fix.
CCMAIL:kde-i18n-doc@kde.org
BUG: 375478
Reviewers: #plasma, mart
Reviewed By: mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4454
Take into account the label's height for minimum size. When we resize the applet super tiny,
it's likely text wraps onto two lines, so use a two line text as minimum (it already does that for preferredHeight anyway).
Differential Revision: https://phabricator.kde.org/D4477
Summary:
applets that acces their config in C++ needs to implement
configChanged() in order to still work correctly in the scripting
console
Test Plan: correct icon when created from scripting console and config written from there
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4461
Summary:
applets that acces their config in C++ needs to implement
configChanged() in order to still work correctly in the scripting
console
Test Plan: correct icon when created from scripting console and config written from there
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4461
This belongs in a header only (where it already is) and my IDE complains about it.
Since the macro expands to nothing anyway this doesn't change anything.
Differential Revision: https://phabricator.kde.org/D4456
This is the same Plasma ContainmentInterface does. Otherwise QtQuick gets confused about mouse state.
Differential Revision: https://phabricator.kde.org/D4455
This belongs in a header only (where it already is) and my IDE complains about it.
Since the macro expands to nothing anyway this doesn't change anything.
Differential Revision: https://phabricator.kde.org/D4456
This is the same Plasma ContainmentInterface does. Otherwise QtQuick gets confused about mouse state.
Differential Revision: https://phabricator.kde.org/D4455
childAt expects coordinates relative to the item, so we need to mapFromScene before we do that.
BUG: 375535
FIXED-IN: 5.9.1
Differential Revision: https://phabricator.kde.org/D4452
This patch primarily is aimed at applications using libappindicator.
For example:
* Steam
* Discord
* Deluge
libappindicator doesn't provide functionality for raising an application,
but only a context menu. Since it also doesn't even provide the corresponding
DBus method, we use the resulting error to try to display the context menu
instead, which matches the behaviour on Unity and Gnome.
BUG: 375351
Reviewers: #plasma, davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4301
Summary:
::createMenu sometimes creates a new menu, sometimes returns a pointer
to a menu from libdbusmenu that we shouldn't delete.
This patch makes any newly created menu delete itself on closure.
It then shuffles some code so that we only call createMenu after
doing checks.
Test Plan:
Ran in compact mode, clicked menu a few times
Ran in full mode, clicked a menu a few times
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4393
Files in desktop:/ are local files but QUrl doesn't know this.
Also allows us to determin mime type and icon for files on a network share.
While at it, improve default naming logic.
BUG: 375103
FIXED-IN: 5.9.0
Differential Revision: https://phabricator.kde.org/D4157
Kai Uwe Broulik
l10n daemon script
Marco Martin
Aleix Pol
David Edmundson
Albert Vaca
Roman Gilg