registerService() isn't sufficient, this has probably been broken
since the port from DCOP. The exported object is used by ksmserver
to talk to kcminit during startup
kstartupconfigfiles contains a list of files to compare mtimes on to see
if we need to rebuild kstartupconfig. This wasn't being created
correctly so we failed to rebuild if any configs updated.
This was broken in Qt5 porting:
- const QStringList dirs =
KGlobal::dirs()->kfsstnd_prefixes().split( KPATH_SEPARATOR, QString::SkipEmptyParts);
+ const QStringList dirs =
QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation);
REVIEW: 119669
kstartupconfigfiles contains a list of files to compare mtimes on to see
if we need to rebuild kstartupconfig. This wasn't being created
correctly so we failed to rebuild if any configs updated.
This was broken in Qt5 porting:
- const QStringList dirs =
KGlobal::dirs()->kfsstnd_prefixes().split( KPATH_SEPARATOR, QString::SkipEmptyParts);
+ const QStringList dirs =
QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation);
REVIEW: 119669
If ~/.config does not exist readlink will not output anything,
causing startkde to write configs to /kstartupconfigkeys, which
is not a writable path for a regular user.
Since the original commit mentions that relative paths weren't working,
I've taken a alternative approach of using ${HOME} instead.
REVIEW: 119522
kstartupconfig was looking in .config/share/startupconfigkeys
startkde and kdostartupconfig write to .config/startupconfigkeys
End result settings such as those in ksplash were ignored
REVIEW: 119425
kstartupconfig was looking in .config/share/startupconfigkeys
startkde and kdostartupconfig write to .config/startupconfigkeys
End result settings such as those in ksplash were ignored
REVIEW: 119425
Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found.
This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown").
As a plus, kf5-config is no longer used in startkde.
CCBUG: 333793
REVIEW: 119145
KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
language to show. This environment variable is no longer used by the qml
based ksplash. It makes no sense to have it.
Additionally, this means we can stop linking against kdelibs4support.
This is important cause kdostartupconfig blocks the rest of the boot
sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
longer linking to kdelibs4support it takes less than 0.1 seconds and no
longer shows up in the bootchat logs.
REVIEW: 119103
This is the beginning of revision history for this module. If you
want to look at revision history older than this, please refer to the
techbase wiki for how to use Git history grafting. At the time of
writing, this wiki is located here:
http://community.kde.org/Frameworks/GitOldHistory
If you have already performed the grafting and you don't see any
history beyond this commit, try running "git log" with the "--follow"
argument.
Branched from the monolithic repo kde-workspace, frameworks branch, at commit
049113e719dd2fc4446d054fa1a3aada330094f0
Marco Martin
Lukáš Tinkl
Jonathan Riddell
David Edmundson
Rohan Garg
Hrvoje Senjan
Ömer Fadıl Usta
Vishesh Handa
Luca Beltrame
Sebastian Kügler
Martin Gräßlin
Aleix Pol
Àlex Fiestas
Kevin Ottens