- All of this ugly conditional anchoring has been replaced by layouts where applicable
- The details have been outsourced into a separate file which is loaded on demand
- Removes code duplication by using fancy Repeaters
REVIEW: 121057
Whenever a job disappears for whatever reason (cancelled, finished, error, ...) we display
a persistent "Job Finished" notification. When the user explicitly cancels the job, there's
no need to confirm since the job will be gone. This solution is not ideal since we just track
it inside the plasmoid (ie. when you click Cancel in a "Override this folder?" dialog, it will
still show the notification) but at least the obvious "You don't say" moment is gone that way.
Ideally in the future whoever is responsible for the job (KIO, ...) should be given the
responsibility for an appropriate notification since the owner knows best why a job quit.
CCBUG: 340068
According to the notification spec, the body is a subset of HTML which implies that it's the
client's responsibility to take care of escaping things that look like tags.
REVIEW: 121155
- Some minor code styling (new Array() -> [], new Object() -> {} etc)
- Pass the notification object we get from the data engine to addNotification verbatim
instead of having an ugly function with dozens of parameters we just use to construct
a similar object ourselves anyway
- Push actions into array directly instead of creating a new Object, setting its properties
and then pushing it
REVIEW: 120993
According to the notification spec, the body is a subset of HTML which implies that it's the
client's responsibility to take care of escaping things that look like tags.
REVIEW: 121155
- All of this ugly conditional anchoring has been replaced by layouts where applicable
- The details have been outsourced into a separate file which is loaded on demand
- Removes code duplication by using fancy Repeaters
REVIEW: 121057
Persistent notifications now get a timestamp that shows then the notification has been
received, such as "Just now", "30 s ago", "1 min ago", "13:37", "Yesterday" ...
REVIEW: 120997
Whenever a job disappears for whatever reason (cancelled, finished, error, ...) we display
a persistent "Job Finished" notification. When the user explicitly cancels the job, there's
no need to confirm since the job will be gone. This solution is not ideal since we just track
it inside the plasmoid (ie. when you click Cancel in a "Override this folder?" dialog, it will
still show the notification) but at least the obvious "You don't say" moment is gone that way.
Ideally in the future whoever is responsible for the job (KIO, ...) should be given the
responsibility for an appropriate notification since the owner knows best why a job quit.
CCBUG: 340068
- Some minor code styling (new Array() -> [], new Object() -> {} etc)
- Pass the notification object we get from the data engine to addNotification verbatim
instead of having an ugly function with dozens of parameters we just use to construct
a similar object ourselves anyway
- Push actions into array directly instead of creating a new Object, setting its properties
and then pushing it
REVIEW: 120993
Martin Klapetek
Kai Uwe Broulik
Montel Laurent
l10n daemon script