The default image is set in MediaProxy ctor. When the default image is
still in loading status, the model image can change and be already
loaded before the default image is loaded, therefore there could be a
race condition that the default image is loaded later and overrides the
true image.
This stores the pending image and destroys the previous pending image
to fix the race condition.
BUG: 456189
FIXED-IN: 5.26
The login/logout script files need to be executable. To avoid the user
wondering why their script isn't executing, warn them if the file is not
executable and offer to fix it.
CCBUG: 391609
Given that the wayland protocol does not have window positions a recent
change to Qt development branch avoids having a mismatch of positions
and tells client code the window is at the topleft of the screen. This
fixes multiple bugs.
Unfortunately this breaks a few usages within plasma where a
side-channel sends that absolute positional information over a bespoke
protocol. Currently we proxy this all through QWindow geometry where the
new Qt behaviour will throw is askew.
Whilst our longterm plans are to find future options away from the
plasmashell protocol we may as well have our Qt6
build work given the patch is trivial and harmless.
It also allows for potential backporting if our software is
already secured against issues. Hence the cherry-pick.
When the target size changes while the provider type is single image
or the current wallpaper is animated, the frontend is required to force
update the wallpaper.
Instead of having Qt::red hardwired for the text colour.
New function KlipperPopup::showStatus() to implement setting
the filter line edit colours and showing the status.
Show an explicit error for an invalid regular expression.
Simplify filter regexp generation, add comment regarding case sensitivity.
No need to have single use strings as member variables.
I18N:
Right now it opens the color picker dialog with the current first accent color.
Remembering the user's prior custom accent color (if any) is nicer.
BUG: 455894
FIXED-IN: 5.26
This bug was introduced by plasma/plasma-workspace!1754.
`lockScreenUi.hadPrompt` was set to `false` in `onFailed()` to avoid
unintentionally clearing the password after the text field had faded
out after 10 seconds and the user pressed a button. Unfortunately this
also caused the password field to not clear right after the failed event.
So instead the statement is moved into the trigger of `fadeoutTimer` which
fixes both issues.
BUG: 455227
FIXED-IN: 5.25.3
Whilst iterating through m_proccesses we make them finish. An existing
connect removes them from the vector.
Iterating through a volatile vector is unsafe.
BUG: 454159
The custom color buttons don't need to be made conditionally transparent
or use a custom cursor, as they are mostly just normal radio buttons just
with a different background color. So let's remove these unnecessary
custom overrides.
In task manager, switching between icon task manager and text task manager
loses the old settings, which is inconvenient. This copies the old
configuration to the new applet to fix that behavior.
BUG: 355588
FIXED-IN: 5.26
When separateLaunchers is false and there are two opened pinned tasks
and one launcher icon, dragging the launcher icon to a position between
the two pinned tasks always fails for the first time.
The general idea of this fix is to make sure after every move operation,
pinned launhcer item and the corresponding opened window still stay
together.
BUG: 448912
FIXED-IN: 5.26
Tint the window titlebars even if the option to make them accent-colored is not
explicitly enabled; in this case you want them tinted anyway because they're a
part of the fill window which will get tinted.
BUG: 455395
FIXED-IN: 5.25.2
KSMServer sets which session to use on startup
`KSmServer::restoreSession(QString)`
When the session is up and ready either systemd or plasma-session invoke
`restoreSession()` that actively starts restoring clients.
At some point we need to notify kwin which session we're using so that
it can handle restorng window properties such as the virtual desktop.
This was done in the first call, but this has no guarantee that kwin has
started yet. Without kwin getting the DBus call it has no information to
match up restoration information.
The state RestoringWMSession is dropped as it does nothing useful.
BUG: 442380
ksmserver has two services. One for the service itself, and a single
shot invoked later when we want to restore the session.
They currently both have the same description which isn't very helpful.
This text is not user facing in our UIs anywhere, only for devs.
In `combineImages`, the width and the height were calculated
incorrectly. This makes the preview image correctly obey the device
pixel ratio of the primary screen, so the preview image can be clear
and sharp.
BUG: 413673
FIXED-IN: 5.25.1