And use KPluginMetaData instead. It's what we get from the PackageLoader anyway.
Unlike KPluginInfo KPluginMetaData supports multiple authors. To keep the current behaviour of the model the code picks the first one and ignores the potential others.
Instead of using KPluginTrader's contraint system pass a filter function to KPackage::PackageLoader.
Also move the later filtering into said filter function.
Summary:
We don't emit anything or use properties or anything else that requires
MOC. We want to keep model items light.
The emitDataChanged in setRunning still works because that's part of
QStandardItem. Memory management is the same beacuse the
QStandardItemModel takes ownership in appendRow().
Test Plan: Opened widget explorer.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4218
Summary:
There was no role exposed for isFavorite and it has no other impact.
Removing it not only cleans up the code but also saves us parsing a
config file for no reason.
I don't think it's worth putting in the UI; no-one is adding so many
plasmoids that they would go out of their way to mark one as a favourite
for quicker future access.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D4217
setting the application name and the provides
resets the model two times in a short time, so don't
reset on startup, until componentCompleted arrived
BUG:375105
Otherwise we'll crash. This is the only occurrence I stumbled upon this right now
but there may be others in the port away from Qt4Support.
CCMAIL: apol@kde.org
This saves applets writing their plugin name twice in the metadata
files, and also leaves the metadata icon entry free for more semantic
purposes for use in tooltips and notifications
REVIEW: 126046
As suggested by the VDG, add the possibility to have screenshots for plasmoids.
the widget explorer will be modified as well to show the screenshots
in the applet list when available
REVIEW:125134
It is not meant to be shown in widget explorer. It is not being shown
when english language is used because
i18n("Containments") == "Containments"
but in other languages for example x-test
i18n("Containments") == "xxContainmentsxx" and hence this condition
doesn't pass and it shows up in UI