Instead of using highlight as background and painting over that with a
transparent colour, make the chart empty out but flip it so the
direction is the same. This removes any aliasing artifacts that occur
due to antialiasing.
BUG: 423079
Summary:
When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself.
BUG: 421344
Reviewers: ngraham, plasma-devel, broulik
Reviewed By: ngraham, broulik
Subscribers: broulik
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29651
Summary: The negative top margin was not necessary and causes missing round corners.
Test Plan:
No visual change on master
With D29479, rounded corners should appear again
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29490
Summary: This hides the plasmoidHeading on history for not grouped notifications
Test Plan:
After:
{F8288756}
Reviewers: broulik, ngraham
Reviewed By: broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D29474
When setting "until turned off" it effectively sets it to today in a year. Now with leap year this appears to have broken.
Instead, just use 100 days, which is plenty, even if we come up with a "for 1 month" option maybe.
Differential Revision: https://phabricator.kde.org/D28740
Summary:
The Clipboard and Notifications applets live in plasma-workspace; port them to use
Kirigami.PlaceholderMessage
Test Plan:
Clipboard: {F8253980}
Notifications: {F8253981}
Reviewers: #vdg, #plasma, broulik, niccolove, cblack
Reviewed By: #vdg, #plasma, niccolove, cblack
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T13021
Differential Revision: https://phabricator.kde.org/D29109
Summary:
Somehow the notification pop-up's positioning has never felt quite right to me. When it's
in a bottom corner, it blocks the view of the latest messages in chat apps, or the text
I'm searching for in Kate. When it's in a top corner, it blocks part of the open app's
toolbar or tab bar that I often use. The best place I've found for is in the top-middle,
which doesn't block very many of the thing I'm active using, and its centered position
feels aesthetically pleasing. I've been using this for a bit and quite like it.
However there is ony deficiency: the pop-up is not very wide, so it becomes quite tall
when displaying multi-line messages from chat apps in particular, which makes the
notification stack intrude into the middle of the screen where it definitely blocks things
you want to be looking at. This is annoying.
This patch resolves that issue by making the pop-up's size wider and the spacing between
pop-ups smaller when the pop-ups are positioned in the top or bottom middle.
Test Plan:
Centered pop-ups now look like this:
Single pop-up: {F8247020}
Stack of pop-ups: {F8247025}
There is no visual change for pop-ups in the corner, where they are by default.
Reviewers: #vdg, #plasma, broulik, ndavis, cblack, bshah
Reviewed By: #vdg, #plasma, broulik, ndavis, cblack, bshah
Subscribers: bshah, IlyaBizyaev, ndavis, cblack, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28989
Summary:
As per D28575, converted the FullRepr to be a Page and added a PlasmoidHeading
Result:
{F8215954}
Depends on D28575
Test Plan: Test with D28575
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: ngraham, plasma-devel
Tags: #plasma
Maniphest Tasks: T10470
Differential Revision: https://phabricator.kde.org/D28576
This mutates the source array.
In practice actions don't really change in existing notifications but still better to not do that.
Differential Revision: https://phabricator.kde.org/D28650
This ensures that newer notification popups don't push old ones out.
Some applications are notorious for spamming the user which right now results in a firework
of notification popups. With this patch only the number that fits on screen is displayed and
everything beyond that is off screen until there's enough room for new popups which are
then gradually lowered.
It also reduces the likelihood of the notification the user is interacting with being shifted
away by an incoming notification. Furthermore, since notifications that are off screen will
have their timeout reset, it can happen that you have a bunch of recent notifications at the
bottom but then get some old ones that were off screen sliding back in because some middle ones
have expired already, leading to awkward results.
Notification scoring (e.g. critical before normal) is untouched, so a "battery is critical" notification
will show up even if it's still chugging through the backlog of browser notifications.
Differential Revision: https://phabricator.kde.org/D28646
Summary:
any other position doesn't really make sense on mobile, so ignore popup location
settings
Reviewers: broulik
Reviewed By: broulik
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27968
Summary: With other two patches, this aims to make leftMargin consistent in widgets (See https://phabricator.kde.org/D26945 and https://phabricator.kde.org/D26944)
Test Plan:
System tray
Before:
{F7977382}
After:
{F7977379}
Notifications
Before:
{F7977359}
After:
{F7977357}
Battery monitor
Before:
{F7977362}
After:
{F7977361}
Self reminder: networkmanager is still slightly badly aligned
Reviewers: #vdg, #plasma, ngraham
Reviewed By: #vdg, ngraham
Subscribers: gvgeo, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26946
Avoids repeatedly resizing the dialog when copying many files.
It will still resize when the speed label comes and goes but at least when copying many tiny files it won't be as obnoxious.
BUG: 417489
FIXED-IN: 5.18.1
Differential Revision: https://phabricator.kde.org/D27344
Summary:
plasma.kde.org doesn't exist anymore and causes the appstream test to
to fail.
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27304
Summary:
We use this centered style in many other places and are moving towards using it
everywhere. This patch applies the same style to the System Tray popups for
notifications and devices, which were still using the old style.
Test Plan:
Notifications, before: {F8090822}
Notifications, after: {F8090777}
Device Notifier: before: {F8090825}
Device Notifier, after: {F8090776}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: davidedmundson, ndavis, trmdi, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27219
This wasn't an issue before as notification popups could never have focus.
However, now with quick reply they can, leading to funky results and gaps when a notification appears while answering another one.
Differential Revision: https://phabricator.kde.org/D27134
Makes it more obvious that there is an inline reply rather than having a "Reply" button where the user must guess what it'll do.
Differential Revision: https://phabricator.kde.org/D26796
It is only attached to the delegate item itself.
Broke when it got shuffled around when swiping got added.
Differential Revision: https://phabricator.kde.org/D26422
This adds a quick reply feature with a text field inline in the notification popup.
An action named "inline-reply" will spawn the text field and a NotificationReplied signal is emitted then.
There's additional kde hints for changing the placeholder text (defaults to "Type a reply..."),
submit button text (defaults to "Send") and submit button icon name (defaults to "document-send",
that paper aeroplane icon).
When a plasmoid collapses in Active state, the popup is hidden.
In Passive state, however, one is returned to the hidden items list, as it cannot tell whether
the plasmoid collapsed on its own or because the user clicked the same one in the hidden items list again.
When we clear notifications, plasmoid state updates immediately as a result of model signals,
and when we then try to collapse the plasmoid we're already hidden and just returned to the hidden items list.
This patch addresses this by delaying the state change slightly.
Futhermore, don't collapse the plasmoid when already hidden as that would just return the user to the hidden items list.
Differential Revision: https://phabricator.kde.org/D26091
Summary:
Both the popup header size as well as units.smallMargin depend on font
size. This causes problems with the new circular timeout indicator.
Rather than trying to somehow fix the margins, this patch changes things
to use units.iconSizes.smallMedium as close button icon size instead,
stopping it from relying on font size and hopefully fixing any layout
issues.
Test Plan: Change font size to 10/11/12 pt. Icon size remains the same.
Reviewers: #plasma, #vdg, ndavis, ngraham
Reviewed By: #vdg, ndavis, ngraham
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26093
This adds a file icon to a finished job for a single total file which can be dragged anywhere for convenience.
Differential Revision: https://phabricator.kde.org/D25782
Summary:
This uses the new KQuickCharts framework to render the notification timeout bar as a small
circular progress bar, around the close button.
Video:
{F7818131}
Test Plan:
notify-send -t 15000 test will first show a notification with no indicator, then once the
timeout gets to 10s or less it will show a decreasing circular progress bar.
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25993
Summary:
During the port to Qt5 the circular progress bar was lost, since there is no
simple way to do circular progress bars. Now that KQuickCharts is available
as a framework, we can restore the circular progress bar in the notifications.
Video:
{F7819233}
Test Plan: Start a long-ish running job like copying a file.
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26012
When Plasma notification service isn't available or provided by someone else, disable the plasmoid.
Do not disturb controls are disabled and the applet stays in the popup crossed out.
Effectively D25097 of plasma-desktop for the applet itself.
Differential Revision: https://phabricator.kde.org/D25917
There's something really funky going on in this...
Avoid using ViewTransition attached property be just setting the animation target before triggering the model removal.
BUG: 414066
Differential Revision: https://phabricator.kde.org/D25861
Kai Uwe Broulik
Arjen Hiemstra
l10n daemon script
Bhushan Shah
Niccolò Venerandi
Nate Graham
Eugene Popov
Heiko Becker