Summary:
When we load and position the Image the height is constrained, the width
is not. The image fillMode is set as PreserveAspectFit so the width
will adjust to fit the aspect ratio,
Therefore we only want to set a fixed height on the sourceSize, it will
automatically match the resultant width.
BUG: 413087
FIXED-IN: 5.17.3
Test Plan:
I was unable to reproduce the state.
Patch is based on reading the code and docs
Reviewers: #plasma, broulik, ngraham
Reviewed By: #plasma, broulik, ngraham
Subscribers: broulik, filipf, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D25252
Summary:
This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.
BUG: 410801
FIXED-IN: 5.17.0
Test Plan:
Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.
**Before this patch:**
Lockscreen on small display (1366x768): {F7330101}
Lockscreen on big display (1920x1080): {F7330096}
**After this patch:**
Lockscreen on small display (1366x768): {F7342190}
Lockscreen on big display (1920x1080): {F7342191}
Reviewers: #plasma, #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: filipf, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23786
Summary:
TL;DR version: whenever you currently would be taken to a session switcher page where the only possible action is to go to SDDM and start a new session, instead just show SDDM immediately instead.
Currently, the session switcher screen suffers from a few UX problems:
- There's a fake "start new session" item that looks like a button but isn't clickable
- Asking to switch users always goes to the screen where you can switch to existing sessions even if there are no existing sessions to switch to, which is an unnecessary extra step
This patch aims to solve those problems in the following ways:
- Don't show a fake "start new session" item in the Breeze theme; instead add a real button in the UI to do this
- When asked to show the session management screen and there is only one session so the on;y thing you could do on that screen is create another session, instead just go to session creation directly
- For themes where the fake "start new session" button is shown, use a better icon that doesn't make it look like a clickable button
BUG: 386361
FIXED-IN: 5.17.0
Depends on D23279
Test Plan:
1. Have only one session > Kickoff/Kicker/dash/Krunner > Switch User -> you go directly to SDDM where you can start a new session
2. Start a new session, then Switch user again -> you go to the session management screen where you can switch to the other session, or start a new one
Videos:
Clicking "Switch User" when there are no other sessions: {F7264475}
Clicking "Switch User" when there is another session to switch to, and then switching to it: {F7264476}
Clicking "Switch User" when there is another session to switch to, and then starting a new session: {F7264480}
Switching between multiple sessions in the session switcher: {F7264483}
If the fake "New Session" item is shown (e.g in other themes), here's what it now looks like: {F7264485}
Reviewers: #plasma, #vdg, GB_2, mart
Reviewed By: #plasma, #vdg, GB_2, mart
Subscribers: GB_2, gregormi, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23283
Summary:
Shows a busy indicator in the TextField.
Depends D22723.
BUG: 409959
Test Plan: Searched things, eventually it disappears, I sometimes don't really know what's still doing, maybe we could add some more information at some point.
Reviewers: #plasma, #vdg, broulik
Reviewed By: #plasma, #vdg, broulik
Subscribers: mart, davidedmundson, ngraham, aspotashev, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22514
Summary:
Because the fake {nav Switch User} item in the switcher UI counts as a session, the button
was always being shown. But if and when that changes and the fake item is no longer shown,
the {nav Switch User} button itself will stops being shown potentially locking out
non-logged-in users in multi-user computers where the only logged-in user has locked the
screen.
This patch drops the conditional check entirely and always shows the {nav Switch User}
button when session creation/switching is possible.
Test Plan: No change; {nav Switch User} button is still shown.
Reviewers: mart, #plasma, #vdg, filipf
Reviewed By: #vdg, filipf
Subscribers: filipf, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D23279
Summary:
We're currently using a custom tyle for song titles and artist info in the lock screen's media controls.
This patch applies common KDE title & subtitle style as seen in e.g. Kickoff or plasma-nm applet-
Because the lock screen has increased font sizes, corrections for the title and subtitle have also been made.
Test Plan:
Before:
{F6960714}
After:
{F6960717}
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D22231
Look and feel stuff is loaded into various other places so it needs to set a domain explicitly
CHANGELOG: Media controls on the lock screen are now properly translated
Differential Revision: https://phabricator.kde.org/D21947
Summary:
We are currentlly very inconsistent how we refer to KRunner, impairing comprehensibility
among both expert users (who know it as "KRunner") and novice users (for whom "Run
Command" has a literal and somewhat scary meaning).
This patch is a part of {T10966} and standardizes on "Show KRunner", helping to turn
KRunner into a user-visible brand name like Apple's Spotlight.
Test Plan:
{F6842497}
{F6842498}
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Tags: #plasma
Maniphest Tasks: T10966
Differential Revision: https://phabricator.kde.org/D21341
Summary: The action buttons were missing a visual indication of when they were being pressed so this patch adds it by drawing another an animated rectangle when the button is pressed.
Test Plan: {F6819154}
Reviewers: #vdg, #plasma, ngraham, davidedmundson
Reviewed By: #vdg, #plasma, ngraham, davidedmundson
Subscribers: broulik, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D21062
Summary:
This patch replaces the PlasmaComponents labels in Clock.qml with QQC2 ones. This resolves the issue of the clock letters/numbers getting clipped.
BUG: 404651
FIXED-IN: 5.15.3
Test Plan:
Before and after
{F6680490}
Reviewers: #plasma, #vdg, filipf, ngraham, hein
Reviewed By: #plasma, #vdg, ngraham, hein
Subscribers: mart, davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19647
Summary:
This patch:
- tells the login screen to modify the font size specified in theme.conf and the lock screen to modify the user's default theme's font size instead
- makes sure that the login screen session and keyboard buttons take this new approach too
- raises the font size of "Start New Session" on the lock screen (to match the rest)
- raises the artist/track font sizes (to match the password field)
Test Plan:
This patch resolves the problem of
(1) The fonts on the login screen and
{F6676520}
(2) the fonts on the lock screen
{F6676524}
not having matching sizes.
Reviewers: #vdg, #plasma, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: davidedmundson, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19631
When the flag to reboot into BIOS/UEFI setup is set, show a hint on the logout screen.
For simplicity and to avoid the layout from shifting, and since the user had to explicitly enable the flag
and probably know what they're doing, it is shown regardless of what action is highlighted.
Differential Revision: https://phabricator.kde.org/D19562
Summary: This patch improves the appearance of the sddm theme and the lock screen with software rendering in place (QT_QUICK_BACKEND=software) by adding an outline to the action buttons, correcting the error that prevented the username outline from appearing and by adding a background to the action buttons that are otherwise impossible to see on top of a very bright background in software rendering mode.
Test Plan:
Before (white background):
{F6673579}
After (white background):
{F6673580}
Before (Next):
{F6673581}
After (Next):
{F6673582}
Reviewers: #plasma, #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham
Subscribers: plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19609
Summary: This patch removes the shadow from the usernames on the login and lock screens. It also restricts the clock shadow to just the opaque (unfocused) versions of each screen.
Test Plan:
{F6648570}
{F6648571}
Reviewers: #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: filipf, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19468
Summary: Added in D16879, the background circle was designed to work on a blurless login screen. Since we have abandoned that idea, it's good to adjust it to our present needs. This patch lowers the opacity of the circle and removes the double border it created.
Test Plan:
Before:
{F6649241}
{F6649240}
After:
{F6649244}
{F6649243}
Reviewers: ngraham, #vdg, #plasma, rooty
Reviewed By: ngraham, #vdg, rooty
Subscribers: abetts, plasma-devel
Tags: #plasma
Maniphest Tasks: T10325
Differential Revision: https://phabricator.kde.org/D19478
Jacopo De Simoi
Apurv Jyotirmay
David Edmundson
Filip Fila
Kishore Gopalakrishnan
Nate Graham
l10n daemon script
Kai Uwe Broulik
Aleix Pol
Björn Feber
Krešimir Čohar
Laurent Montel
Filip Fila