Summary:
This way the text doesn't get cut off the screen on at least the
PinePhone
Test Plan:
1. Open the Language KCM on a small screen without this patch
2. Open the Language KCM on a small screen with this patch
Reviewers: davidedmundson
Reviewed By: davidedmundson
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27781
Summary:
BUG: 417747
FIXED-IN: 5.18.1
Test Plan:
Better default size when showing the most info: {F8107763}
However window is too now big when showing the least amount of info: {F8107762}
...But that seems kind of unavoidable unless we want to dynamically resize the window,
which people seem to hate.
Reviewers: #plasma, #vdg, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27448
Summary:
Before loading the view, query all plasma processes and show why they're using
KUserFeedback.
Depends on D26569
Test Plan: Manual testing
Reviewers: #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26570
Summary:
If the kcm's property changes externally we don't update the slider
after the initial load, which is before KConfigModule::load which actually sets
the property.
Whilst there is an alternative fix calling load() a second time, we need
this anyway for default and reset buttons to work correctly.
I also think the original code was broken, I don't see why we would map
the value back to modeOptions[idx], we want the slider value to be the
index of the array, not the enum value. They just happen to be the same.
Test Plan: Opened KCM changed it, opened KCM repeat
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26678
Summary:
Adjust to the string changes in D26551 and improve the presentation
overall to make it more likely that people will feel comfortable
using it and submitting information.
Depends on D26551
Test Plan: How it looks now: {F7875839}
Reviewers: #vdg, #plasma, apol
Reviewed By: apol
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26552
Summary:
This is not really needed here due to the size of the delegates and of
the list which is generally short. I ended up getting rid of it because
it makes this config module crash somewhere in the QML runtime when the
user clicks reset. I couldn't track down why DelegateRecycler does this
so far.
Reviewers: #plasma, mart, davidedmundson, crossi, bport
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26241
Summary:
At the moment we were merging two different concepts into a same KCM and it was
too confusing.
Simplify making the kcm only about Plasma by removing the kill switch and
making sure the text only affects Plasma components.
Reviewers: #plasma, vkrause, davidedmundson, ngraham
Reviewed By: #plasma, davidedmundson, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24733
And make it the default.
Kill Switch is only for when you think something off is happening or you
don't feel in control.
Reviewed by David Edmundson (see D24635)
l10n daemon script
Nicolas Fella
Bart Ribbers
Nate Graham
Aleix Pol
David Edmundson
Kevin Ottens
Laurent Montel
Bhushan Shah